From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60DD0DDC3 for ; Mon, 14 Apr 2025 20:35:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744662945; cv=none; b=eEwjjtdD301dKvOM7g4Fk0GYXiodfj0ABPx1hnKINKJL3YwSOCVuwSr073kNQfe/wiP52JiE/hrNOWeZUlJ0XxHOWcskGCBOl7lj/a9dP4GpPho7J+OPmViEPkmNA6KhWvk8aXfDCn+v7hXL9ZNJUA8D+DQOgYSJVOjcScrUknw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744662945; c=relaxed/simple; bh=treTBaIxZoc3jdxAPHMCYgFICz5n9kyVrC8UeP9/WSA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uSOOPl2mRL+FAbG5BR7u2f2hvEYt3E+YTuAdqHoJFXsuD2a/Aalx1zSxR9kkQWKiaKHWcnu4EdA0Z2Caltgb1ZxswmPuTZOcgUtlsW6lcOv6BZAC5lB2G54V18w1+/VPCfRxsOfOFXi6n4t+jc/GJlLTV+qjnC6jj/QwKW7ihGs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ikVxrvTU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ikVxrvTU" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53EJMtYg013707 for ; Mon, 14 Apr 2025 20:35:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TcfeZVOyedKWdzur922HOzg3A7r2ZIv8dN0aYlvohuY=; b=ikVxrvTU13ys9n6N jaLLgH1FaPL+nIYUpFJPW7Q409nPG1nghVHIT6Cx2I1bRUnGTqQYaYpcknUVlAZW Qd515P9l5wS0CXUIXBha6uLcHrCyNbrn1gg+cn8BqUsMIPb2arDJOAuU/ED9u1Co ornb1tJSAxhEU4uRJZ3pHG2Ct4p/LS22YDGHOu1dsBCUam9Znu1hp3Fg6EJ+T4JT S4P5Ph/luMP/LjxzNt27frSZMeHtEOMRCC61liIXC+rmIW3wYIjF3n4+/6s5nYHz KE2ouncoT/DaqRlTIPQJu3RNpP9ykc51eXyvXr72x9Fr/aFf4Qf/bwrLUgihG2Wq jRfY0A== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45yhfcwn2j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 14 Apr 2025 20:35:41 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6eeb8a269a7so14617126d6.0 for ; Mon, 14 Apr 2025 13:35:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744662940; x=1745267740; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TcfeZVOyedKWdzur922HOzg3A7r2ZIv8dN0aYlvohuY=; b=YPdI8h37XCs8QF7CV0R/eVOgOsNyct6Yt1Vc0+eUWI1lw6VdB1NRgD2DpurA4MGqfU CVCv4nuRsg00HjRkbdSRpBr5xmBQ40dqc4kOZIKM12o9oTmnLWIr6jAJ1bkMgDJF58z/ bnan7iBNz4WZs0AEOJEfdlV1eKnoXbBSIdn96Tf3oChSYumW/qqybPQr/u8VCxVWriG1 lILu7L6vf+2Z0yZsGX6ZqIu6wLcJYF0Ngj+H72HiwsXzeTOUlz+5mrU1kuums7B1uXH3 PTOsXqhkrMSI8qbwjD+0SaVy7t4pXCVfd2gcvKJz6twe92cx3WjqmFPwGBcQeSudL1ut XCqA== X-Forwarded-Encrypted: i=1; AJvYcCWf7Pjb3B2WgrLARTZaAxLQWaEnSpdtG+saC7PS2YM9E0/5e46fpkjbGHv8XSJ6u/fv0jFtxJBnzZK9nkw=@vger.kernel.org X-Gm-Message-State: AOJu0YzX3HR/JQJWkZejEhBBU5tFtiyDtzb5vjGPg7qzChn3X5uVCAvb 4878sMRZqJLJ2ptN2hZfVbdGCCA34HW9q9ZRIt3XoKijKt329/LlIaW1RzDTS/9YMxghyaawcJl f20OvthsziGqegSJW8Ff85YUck9w+PkN0IeS7yAxz/G5AlJDaGzgRJd+ecqMF9LM= X-Gm-Gg: ASbGncsgeZXeOkhcXphS7PbBl9woGFMPMmuG2N6LzMryM45BE3glFyLQTrSRfCTly0M JKUUEOtoKEsFMpXHdXj5z3GbVxctHlcj0N7HcVlT1afRskHiNZLuFpf6eTwcRdQxvIupC/GmflJ yr7iZaCIRdWUKSiabGNPlMB2Tqn1URxky09Yap6Ut51RV6Iw3SCwR1zfoMmh9sPS8U+urNMy+Ft 3kSFgi7N5d3Fa3gLrnWESJSmb6DlxNMgLQmawYd5SuY3wTW3m+10NteTYmT+Is5BerRGFOjDPQx SMSR68YfqbKFxkMi9jfroqCBxmtVPTSyrqcBj9WMbfhITB5MWpLddD9LLDazjNOj2g== X-Received: by 2002:a05:620a:4405:b0:7c3:c406:ec10 with SMTP id af79cd13be357-7c7af1d0611mr694925185a.14.1744662940200; Mon, 14 Apr 2025 13:35:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IES94yre95taymhy/asOVTUHtSDJQP8JMi6CuPlrYL55wGW9j9JqYzSQvw7vL4wpMWwbjEpGw== X-Received: by 2002:a05:620a:4405:b0:7c3:c406:ec10 with SMTP id af79cd13be357-7c7af1d0611mr694923685a.14.1744662939794; Mon, 14 Apr 2025 13:35:39 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccc195sm993479766b.143.2025.04.14.13.35.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Apr 2025 13:35:39 -0700 (PDT) Message-ID: <9c21f321-1aec-4b36-9e3b-026ea9a810fd@oss.qualcomm.com> Date: Mon, 14 Apr 2025 22:35:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/6] clk: qcom: gcc: Add support for Global Clock controller found on MSM8937 To: =?UTF-8?B?QmFybmFiw6FzIEN6w6ltw6Fu?= , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , =?UTF-8?Q?Otto_Pfl=C3=BCger?= , Linus Walleij , Lee Jones , Srinivas Kandagatla , Joerg Roedel , Will Deacon , Robin Murphy , Konrad Dybcio , Rob Clark , Sean Paul , Abhinav Kumar , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, iommu@lists.linux.dev, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org, Daniil Titov References: <20250315-msm8937-v4-0-1f132e870a49@mainlining.org> <20250315-msm8937-v4-2-1f132e870a49@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250315-msm8937-v4-2-1f132e870a49@mainlining.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=CfUI5Krl c=1 sm=1 tr=0 ts=67fd719d cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=pGLkceISAAAA:8 a=OuZLqq7tAAAA:8 a=XF3jJdBvCvMoejL92xsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-GUID: X6AcF6icwmePV5o6EuVuo_WpDGL7MHwi X-Proofpoint-ORIG-GUID: X6AcF6icwmePV5o6EuVuo_WpDGL7MHwi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-14_07,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 malwarescore=0 impostorscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 clxscore=1015 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504140150 On 3/15/25 3:57 PM, Barnabás Czémán wrote: > From: Daniil Titov > > Modify existing MSM8917 driver to support MSM8937 SoC. Override frequencies > which are different in this chip. Register all the clocks to the framework > for the clients to be able to request for them. Add new variant of GDSC for > new chip. > > Signed-off-by: Daniil Titov > Signed-off-by: Barnabás Czémán > --- [...] > +static void msm8937_clock_override(void) > +{ > + /* GPLL3 750MHz configuration */ So this is a variable rate PLL, I'm not sure how it plays out with your frequency table - it looks a little different to the 3.18 version The patch looks good otherwise Konrad