From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B429232B9A3 for ; Thu, 13 Nov 2025 23:45:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763077528; cv=none; b=emZJ0xop3oSPHnVVzsznqVgegB8uUuSIqHcytvcl4/90ehgbMrdy3a0/bhGlEq2DMzA0ER7tkf25BoZNp0hNGptbl0a2i3TOpXOyqUwxjxh/1WSBRu+w4UBPYChjD5gHWFdl/MSXkT76N8aibhrwXVuLH00wJtV4ydyFEUqdoMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763077528; c=relaxed/simple; bh=eCwNx7UCHT50KyonwB7Byy+ImylXXQeSc4yNT1WQeJk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Bl/TsmQEBxGbaFjIcCkl/POgR++xWMtfX7I0vKJrLu/d+303L6bYe8NIv6YX/SriQteyN/4mcaEcssgmsMNpqt1/uy870PtJQ6Xitsr0hXeR6NP1OycYPaaKgM8LiUWzRohohWdSPMSoDag1LN+X/eUlUyZ4L3uWdbSuTgwUfQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=MLGukuy/; arc=none smtp.client-ip=209.85.166.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="MLGukuy/" Received: by mail-io1-f46.google.com with SMTP id ca18e2360f4ac-948d45692b1so51458239f.0 for ; Thu, 13 Nov 2025 15:45:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1763077526; x=1763682326; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NVF0yijrr5gty/zacqzc8QZEE4dNrsypQNW1zUau4Pg=; b=MLGukuy/UKTYp1gTYm6bCxqjNgNdRD8sHpCjzK6+Rt/Ryxd15tgknKk+KgKnSTOut7 Q1TfvQeirYlYfmtjgs9TxQQ1WUuIMnzXLBgJW/6MFroVss3ogV2N10BuEV5/AtJiTqud K4SHPRs5Jqz71s6HrAlNrgFLV59a85bn1ypi0684lPdq4Rk0Z4pX63xEdFlLOXMaiaph 7tFlfHHyW+s4iKStq2+sS7iNsMyQYCdHytBOnIWe3zBTepnLKXAMH6ltxEkMMeNfbD2K 7A63ekJHsdmDRdZRogDxnt7WAHIxLAezJG4pwKfbdzZ8fKgVfqkPM8hImdNQrbCT9U4X Dxjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763077526; x=1763682326; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NVF0yijrr5gty/zacqzc8QZEE4dNrsypQNW1zUau4Pg=; b=fqlr68TAoWoks4tdcIu4cXgSYcsChkNjgFxi4MxZzN9kWMoXjcfrW7RfqyOr5JM1ZB g1tvNzV9G2gIrp4xbDqBHJdZX40Szk/AXQ5TuGANbNQUd62SiSbo10CgyEeizRfhVQ+A 5n3rapVSPZlpZgqsNktVHfx800ZdtXCO7ztK0nq87aoB7+aGQBqxK+oC+hDwjmHkdIMk 26/dU6oqEL7sq5adt7/Zm0ZJHtLHOizIZ8BJ3Et71zczh/Mz1h+8r6Se1YAZPoPEnglB kha+I3FX9BofQBWebDHjJ2xgoIVAVcGm/J9KjxmLrZk6q91dSVCCEyFuibWVY84kcyGj 2LmA== X-Gm-Message-State: AOJu0Yyv5VWwqkqT+VvG6+nqHJ/TGqpFYJmuCflSik7yNOqlts020rrP 9Z8PNC7R5TP6fowDkWDK/UY1sUWBO7FyACGyx65LtK5GPROOuQ2scpLot6BiyItIvxA= X-Gm-Gg: ASbGncsMnr4Q1mJS+7B7gX18YOWalBnuDWBuzv04kH2B55SNK8d/tbASsAyOm12BJYF hmH7mbb/mNZci+HlMX+z623hPpU5DCfwBp9Ry1kBjd5HtFxzS3SnjiYsgu9427RPlj2/5fJHmHe oxyJkTBUFYwRKq/0xm7ylDpOxfJwrLKZJqGH4klMV52PTSOC/edGWIjcI7atnPBKdMWrwmt+0nq ZFyxjwfrmN2c+LZ4B5SHfeu8vX3TvHs6K+8feUaTbN3oW2jqndXLtTCeF557oxMLcZPPlIXxC+c ZF+OpBjvT6NKe1K6GKvE9CNEB978Z1arZkb0LKapPbXFeCRei7xc/gv+S30oRBa5pZ84F2NkTG9 NxYUraI7tQF4KojdJiMnPc5ZyJdqclU9Fd+lwAp9rlnRE7XVzV0mFaXahvk8tslWYhRz03iF+Zw == X-Google-Smtp-Source: AGHT+IHMgHtuZpIzINlZtruEMB33QXbUec5A/gH1FBbp7q4lfQQJoqPtISDmGosjbkfyu20ErSZFTQ== X-Received: by 2002:a05:6e02:1fcf:b0:433:68ab:e2a with SMTP id e9e14a558f8ab-4348c93ef8bmr19216535ab.23.1763077520917; Thu, 13 Nov 2025 15:45:20 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-4348398f2e5sm12037335ab.18.2025.11.13.15.45.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Nov 2025 15:45:20 -0800 (PST) Message-ID: <9c2267cc-6b5a-40ce-b428-05d6ace6f2c9@kernel.dk> Date: Thu, 13 Nov 2025 16:45:18 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: linux-next: Fixes tag needs some work in the block tree To: Damien Le Moal , Stephen Rothwell Cc: Linux Kernel Mailing List , Linux Next Mailing List References: <20251114090436.2811f38e@canb.auug.org.au> <48eff55b-f100-4057-8ff3-1d4b2089533d@kernel.dk> <3459d7a5-f49c-4c5e-b010-a3732c3b0e00@kernel.org> Content-Language: en-US From: Jens Axboe In-Reply-To: <3459d7a5-f49c-4c5e-b010-a3732c3b0e00@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/13/25 4:38 PM, Damien Le Moal wrote: > On 11/14/25 8:07 AM, Jens Axboe wrote: >> On 11/13/25 3:04 PM, Stephen Rothwell wrote: >>> Hi all, >>> >>> In commit >>> >>> 7b2038b1b1d4 ("dm: fix zone reset all operation processing") >>> >>> Fixes tag >>> >>> Fixes: db9aed869f34 ("block: introduce disk_report_zone()"). >>> >>> has these problem(s): >>> >>> - Target SHA1 does not exist >>> >>> Maybe you meant >>> >>> Fixes: fdb9aed869f3 ("block: introduce disk_report_zone()") >> >> Guys, that's now three funky shas that have never existed in my tree. >> Can we please exercise a bit more diligence in actually tagging patches >> correctly? > > My apologies about this. I was careful to take these from a fresh pull of > block/for-next but I obviously screwed-up the copy paste, missing the first > character. Just add something like this to your git config: [core] abbrev = 12 [pretty] fixes = Fixes: %h (\"%s\") [alias] fixes = log -1 --format=fixes and then you just do: axboe@m2max ~/gi/linux (for-next)> git fixes fdb9aed869f34d776298b3a8197909eb820e4d0d Fixes: fdb9aed869f3 ("block: introduce disk_report_zone()") and then you're just copying that entire line, making an error much less likely. Still won't catch someone using the wrong SHA, but it would've prevented your issue at least. -- Jens Axboe