From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABD96367296 for ; Mon, 1 Jun 2026 10:40:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780310444; cv=none; b=sFNVB3klLnQ8Sg4/JxMMDNC1MCBF2A917xvf4gdRMhQiItTmnYYOA+U8ab8QbyzrLQUp0NMsNjA/VfRW5fEhEw18JPBVXDCXN/awhOq29BNOQc3qXFrphzF1Vtwbjz4tMi/G7AHrybyQgm5Y2l7Ufo4LHwOpn0CDHsx7wz+kDBk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780310444; c=relaxed/simple; bh=EkCsVuOS3etedE64cU5lX0jbTdkAp04wTWAI6ZlqVKY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t8m7hHSokBg+a2Cffqdhu1QPD3WGBWBGPCRimVsFnDnbtEGtSWOVH/P5SsATqDP1/l2P64UF4bFzP1ZlbZaK+W0rJ+PsKw2qwMYUyMzT5yPX4NA/Oxipo+9ndXqxf5rMTo/ZKw9p5hMBvKUk4lqMogFDMfMlJWw6WRRW1GSdZoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=priaKdKm; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="priaKdKm" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-45eeea039ebso1668219f8f.1 for ; Mon, 01 Jun 2026 03:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780310439; x=1780915239; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gJiKzGg+XgzIdTa55YrtzezJxfroZkkm8edW9QS1BLY=; b=priaKdKmslSbMiI8n5US3NE/6QDvofetu0jTV1/3oXolLwPqtnHDBoAoc4JUSnDmaS ctfSIGuDSlGV+zkkWjDSIIKlPbrlQ7/I26rjyonk3g40G9UEeG6isKmfLP0hKsmlkBKM O3Xjl3bLxJfRhq5m7p/krWUX0R5ZDw7FBNqrSmKz5wlSwV+FIyba0A18i18z2aT8Yv8R CnKF2p89XUbw7UZKjG9T3u/ShaDPc/WFMRxAMcKapdReEkWfhAENNxn1i4MpK3l3l6cX ihBRfq08V9T7IVCVtvNP/CtxFy/x5OYr7O4SUvKRZAmSb3YBWt3N+6tjOjOS/LTOM7bc yqIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780310439; x=1780915239; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gJiKzGg+XgzIdTa55YrtzezJxfroZkkm8edW9QS1BLY=; b=W9aMeYfrI27KMKJ/ZuRZnjefGtDcyhlEr+RhRkkkX5rnQ/MNNEiX1YN21uPBNfNcdC +cR72f3w7uslRctOKYAakUxEZhqQ8VixVII99HXvnGBfcbHDoDWBPy7BiAss+4Uqy3KO 69TYv4A97bZvP9YRiHbRJYHh4JjR1na6a7AT/ZHT/yB1in81uiXGIanqK/eHMThQYmWj 4sMIxWIfJv6VlAVly6XTcTP1LyKMqtkjcJmaH6QHCOK7HAGIVuK2twdhMNOXJo0CCRM3 9ZrrlDWlDPOlfotlHk8BYaMY0VpaJZR+ZIuSqpewimqeJNt4fl+f3nbCtV78TgLpBCwr sJZQ== X-Forwarded-Encrypted: i=1; AFNElJ8KFddMGaKr/BVr1P05nKZK8ezL1msyTKa2ntAB1y6Jn27pQkDaJx+PxJG9vRHamz5eSZfRQsGwFeidCLU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4kqIdNV4MD8W/N7cIBB9px7mR+hbeN+rWgiRmAFBmaoJkYv5z M1FqwuWhQaqul4rlqvC14dvAbKWCxBnoGkQelQo4N7q3F7KeVPsJB/lI X-Gm-Gg: Acq92OGTUcN5LTq7b/+SAcx2AlgubpkFtnc8Lzn2BvcLqxrQ7DEyK6qwAmOh2GwD6BI Laj/1h3OZK9COoM+FzOMUGtVKJZ0GN5RngSgdkgQ9SehS62A/OaxggxV49A7ok3jxjHNOC1CXGP +9Y6v5V72ajT3YViju5vxVIYdU0oouB0K9Vte58FjRQq64xVNW9iUPohyD5WNLMgwq2rlhnFImc GBJ7dQe40KdBjN9AIa/xShjgBx0DOP9ZhQDylIWad8heGuXtLwRzUNdwZkXt7WSpBtnliEgOzzg 0LJcyfEsskL1nP5ekc8lxaEGmT4BpN19Iq6JirEtNbRpXAOqdf1igOf0h4Jh9IE6NZQ8Du3Ttyk YN2U2mAPzXWd2dKeTTbFejEmM21ePIj0evl1YXFLaDbpynIGlivwoU+UoeXQrOp6w7dRs58Lnp4 nO9j5/u4TjXebIfT8XykDCGmVCEdl6sFEwzUxGxH5hZ2utd3CBttryMsW+n61VSsVxSH3qIH/gm RswUZ1QC41q4WSu5Af4 X-Received: by 2002:a05:600c:35d1:b0:490:af90:f9c2 with SMTP id 5b1f17b1804b1-490af90f9e3mr2266775e9.12.1780310438751; Mon, 01 Jun 2026 03:40:38 -0700 (PDT) Received: from [10.1.0.164] (cust-east-par-46-193-119-166.cust.wifirst.net. [46.193.119.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909d68980csm265739915e9.1.2026.06.01.03.40.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2026 03:40:38 -0700 (PDT) Message-ID: <9c28fb8e-da52-40b3-8dd3-c0bd06ac3434@gmail.com> Date: Mon, 1 Jun 2026 12:40:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v7 1/3] net: dsa: microchip: implement KSZ87xx Module 3 low-loss cable errata To: Nicolai Buchwitz Cc: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , Maxime Chevallier , Simon Horman , Heiner Kallweit , Russell King , Tristram Ha , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Fidelio Lawson References: <20260524-ksz87xx_errata_low_loss_connections-v7-0-1cd49cfa24f0@exotec.com> <20260524-ksz87xx_errata_low_loss_connections-v7-1-1cd49cfa24f0@exotec.com> Content-Language: en-US From: Fidelio LAWSON In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Nicolai, Thanks again for the detailed testing and feedback. On 5/28/26 13:43, Nicolai Buchwitz wrote: > > The cached state lives on struct ksz_device, but ksz8_r_phy() is > invoked per port. Setting the preset on one port is reported back as > active on the others: > >   phytool write swp1/1/0x1a 1 >   phytool read  swp1/2/0x1a -> 0x0001 >   phytool read  swp1/3/0x1a -> 0x0001 > > The commit message already notes that the erratum applies switch-wide. > So writes from non-primary ports could either be rejected or at least > produce > a dev_info_once() so userspace can see the setting is shared? > I will add a dev_info_once() to inform userspace that the configuration is shared across all ports. > > dev->eq_init starts at zero from the kzalloc, but the header added by > this patch defines KSZ87XX_DSP_EQ_INIT_FACTORY = 0x0F as the hardware > default. After a fresh boot on my setup (no writes), the read returns 0: > >   phytool read swp1/1/0x1c -> 0x0000 > > Should probe set dev->eq_init = KSZ87XX_DSP_EQ_INIT_FACTORY (and > dev->lpf_bw = KSZ87XX_PHY_LPF_90MHZ), or read the indirect registers > once on probe, so the cache reflects what the hardware actually holds? > Good point, I will fix this by setting dev->eq_init = KSZ87XX_DSP_EQ_INIT_FACTORY and dev->lpf_bw = KSZ87XX_PHY_LPF_90MHZ during probe. Thanks, Fidelio