From: Bart Van Assche <bvanassche@acm.org>
To: 胡连勤 <hulianqin@vivo.com>, "Christoph Hellwig" <hch@lst.de>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <mkp@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Jens Axboe <axboe@kernel.dk>, Hannes Reinecke <hare@suse.de>,
Mike Christie <michael.christie@oracle.com>,
Damien Le Moal <dlemoal@kernel.org>,
John Garry <john.g.garry@oracle.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"usb-storage@lists.one-eyed-alien.net"
<usb-storage@lists.one-eyed-alien.net>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: 答复: [PATCH v5 1/2] scsi: sd: mark disk dead on surprise host removal to avoid I/O hang
Date: Tue, 13 Oct 2026 08:22:53 -0700 [thread overview]
Message-ID: <9c28fbe7-089f-4d72-86be-5805bfebb213@acm.org> (raw)
In-Reply-To: <TYUPR06MB62172FD04314EFE34D8091EAD29E2@TYUPR06MB6217.apcprd06.prod.outlook.com>
On 10/12/26 7:14 PM, 胡连勤 wrote:
> diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
> index 064c7fc8e368..3a5a0cac2b78 100644
> --- a/drivers/usb/storage/usb.c
> +++ b/drivers/usb/storage/usb.c
> @@ -930,6 +930,9 @@ static void quiesce_and_remove_host(struct us_data *us)
> if (us->pusb_dev->state == USB_STATE_NOTATTACHED) {
> set_bit(US_FLIDX_DISCONNECTING, &us->dflags);
> wake_up(&us->delay_wait);
> +
> + /* Device is physically gone, cannot handle I/O */
> + set_bit(SHOST_SURPRISE_REMOVAL, &host->flags);
> }
Why is a new member variable introduced in struct Scsi_Host instead of
e.g. changing the state of all SCSI devices that are associated with the
host to SDEV_OFFLINE?
Thanks,
Bart.
next prev parent reply other threads:[~2026-10-13 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 11:29 胡连勤
2026-10-12 14:49 ` Christoph Hellwig
2026-10-13 2:14 ` 答复: " 胡连勤
2026-10-13 15:22 ` Bart Van Assche [this message]
2026-10-14 2:20 ` 答复: " 胡连勤
2026-10-14 19:50 ` Bart Van Assche
2026-10-15 1:48 ` 答复: " 胡连勤
2026-10-13 8:14 ` [usb-storage] " Oliver Neukum
2026-10-13 9:14 ` 答复: " 胡连勤
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c28fbe7-089f-4d72-86be-5805bfebb213@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=hulianqin@vivo.com \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=mkp@kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®