From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7CDEC77B7A for ; Fri, 2 Jun 2023 07:07:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233662AbjFBHH5 (ORCPT ); Fri, 2 Jun 2023 03:07:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233168AbjFBHHy (ORCPT ); Fri, 2 Jun 2023 03:07:54 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7251FE5C for ; Fri, 2 Jun 2023 00:07:27 -0700 (PDT) Received: from kwepemm600005.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QXYpy6GQPzqTmt; Fri, 2 Jun 2023 15:02:34 +0800 (CST) Received: from [10.67.103.158] (10.67.103.158) by kwepemm600005.china.huawei.com (7.193.23.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 2 Jun 2023 15:07:16 +0800 Subject: Re: [PATCH v10 3/5] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver To: Jason Gunthorpe CC: , , , , , References: <20230408074224.62608-1-liulongfang@huawei.com> <20230408074224.62608-4-liulongfang@huawei.com> <81e11acf-0ede-d515-bb5a-3964c302f384@huawei.com> From: liulongfang Message-ID: <9c2a68f6-7ee4-03a0-eb9b-49137b37ed10@huawei.com> Date: Fri, 2 Jun 2023 15:07:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.103.158] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600005.china.huawei.com (7.193.23.191) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/5/16 19:50, Jason Gunthorpe wrote: > On Tue, May 16, 2023 at 05:40:36PM +0800, liulongfang wrote: >> On 2023/4/21 22:31, Jason Gunthorpe wrote: >>> On Fri, Apr 21, 2023 at 11:32:47AM +0800, liulongfang wrote: >>> >>>> Thank you for your suggestion, but the current debugfs method can already >>>> meet the functional requirements of verification testing and >>>> problem location. >>> >>> To be clear, I'm against adding selftest code in this manner. We have >>> many frameworks for kernel teesting, please pick one and integrate >>> with it. >>> >> >> Hi, Jason: >> The purpose of this hisi_acc_vf_debug_restore function is to obtain the >> migration status data of the migration device. It is a debug operation. >> Just to obtain this status data, user need to complete the few steps >> of live migration. >> Therefore, it is a debug function here, not a self-test function. > > A debug function should not alter the device state, or do a trial migration. > OK Then I delete this migration and restore the test operation. Does this meet your requirements? Thanks, Longfang. > Jason > . >