From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC88B244667 for ; Wed, 28 Jan 2026 15:30:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769614249; cv=none; b=KMY3GfJmS3TI4rDq9pwKeNoL2rU3Z09NXnq2hyDIjiUI9BQQFNTouVA8hXEC3BgwFPhpHK1vhvVUgcyI4bMrE8K5cr/r8UPBLOSWS97yOdR5Hsn4K0SuYmgt0PBfOp3CbBWDkpiPUkuyVPgzriVOJhP6aU6cQ120pZ+5eJfTiIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769614249; c=relaxed/simple; bh=XYAPBfBbLogIdfQzqy4JL/5bdxCR18ImMKIyx9mJGuk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VpptnklxyOcgOHbDt810CLY5oHwyjzzhtM617AZQQSy34wKbz244g3mJ9w1ZETpqwtKnW+gVetN1tbQt1s5Q5+tBr3UlLdjTa5tmIC1uSATlrmr9KeLd70O9Lwnov+ydcKBEPFxuNSWreflmSD76q6g8BA6BDg6As3/W0CF5tnc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HjlKuflm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MLJzPIkp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HjlKuflm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MLJzPIkp" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60SCwn0i3906103 for ; Wed, 28 Jan 2026 15:30:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cfAWH0J+bT1TfO8Eut9bd0nqaaFvU1SsEogfvfC3c/s=; b=HjlKuflmfSJLO7jW U0sgqjrUlREdzZtsYIYn4oXlvuPiiKP/hw0OvH9IR48pW7b6VM6oAUqB7FbRSaDc 2mjpYeUwTEH5E88QsGplKLgQPD+FLR5ue4gDs9hlwsjMaAGmGGCdYII+u8XpzjA1 zh/xhAoCJXrDjpzUNwJparQ1NaEpDE/GYk+pVR+wnTi/OuW4LsVB0gCEVpftkYtN AuXQ77v8xKMBEizGRp4DpajJ2zygZM6z09AdiWSew3Y046pXk+tA59TUuKA5o2GR BRcxGC3xdpxyX7MSqJMBx2nZCq875G01ik56H2SpulX+GsfsTIHHHAftdmNqV4Fp ieVBpQ== Received: from mail-dl1-f69.google.com (mail-dl1-f69.google.com [74.125.82.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4byjxhrjta-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 28 Jan 2026 15:30:46 +0000 (GMT) Received: by mail-dl1-f69.google.com with SMTP id a92af1059eb24-1247bb4db53so9394946c88.1 for ; Wed, 28 Jan 2026 07:30:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769614246; x=1770219046; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cfAWH0J+bT1TfO8Eut9bd0nqaaFvU1SsEogfvfC3c/s=; b=MLJzPIkpo4Lf34pb19Xj0FJPwdho1UvMnwH/i92twZIlQ/x5uzORYuT6WBebWcvxpZ qNWE5IXxprHxAqq7kqWbGrJt+EwyQiBOi1MMg0CGfMVt/xGi8BOiabibmZ8hNaSwFNKn WpAYJHtrDLyLl+SjfoqxP+4k3xtV3lx1pt01E1X3lLnzUZl6iCHBh1WEZ9q4dcPs6nKJ z2wQZkG7jzQbAWpB1zK1pMklMFRk0ojF6myPDvmaX+OpLQ7Qw65wv8LXBNc4h6tXV/dF peom58IKkAL9QZ0wdA8frTV1fHBQFMMyZ7bstSPtWKW26hxMvJ3402BBjRPIH+W1i1Gz b9QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769614246; x=1770219046; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cfAWH0J+bT1TfO8Eut9bd0nqaaFvU1SsEogfvfC3c/s=; b=Hn9s18rdPdjBYQtYRoYVNW5SoRvOAbrAblDXoEK+CLNM+JBFa519Sxo7zd31fl6y7n I0fWBGFsrz5qycZKaYwNRc66hSrvl5l1RDrVYCMkfESDHa4bqUakMtjtnMl6wGnFf/0E aPr6SNduOlC9UnYjeVh1AuuHFZ2+gTnMmAXoHJ/rrFu0+9fjSnNo7ez04tx0dScWnvjJ RIb5/Q59F+y6US65UllpDCxw5OkKK8gmVEeA5gYZEkTM7UjNbG61Fepr7Msc6iIzQf2u 4jmDDo6FEuR3Y6a5YfToLM/6E/Z5zLy3vUva0XxgfeuD6F4hqC9jsGOjTRzyweFQCSLz rqvQ== X-Forwarded-Encrypted: i=1; AJvYcCXwpkYPkxc0gjTADFS5rWn5r9cWwedNrMzaW9wOVjjtaXLA12ndBiQfVzPVq45RTBvhJ1cYf6WaY54/jeo=@vger.kernel.org X-Gm-Message-State: AOJu0Ywgg+bIl2KJHpS47GIjE3DvXqR8hwJ1n9a+8sICfF+HOP66TgPP NFEbyzLEZ8al3yDF4Xl7yESKpWk42+562vt7IMD8UBeZJ7G1w9JvkIXcAwvj5xVIPyPYis3mKVH /9oZu9Mg7d3iLfPA1PgPv9E5cXq9QOFeF3mqk8IvE5JLXFUe/z7SYYvWJ6AtwcWPv/9M= X-Gm-Gg: AZuq6aLSX6p5Wh/vU3UdRAJJ81KDYBrG5q/J805ZzCVleEQ7zY1HJ+n/0V+5ftYDraZ OLFQrQXrPfeZSNPoR8Ogv877RMKSx1OnW5i7j89D2iAf+Ij/Lr/sYDJQfgGYuKU0Cljik+noGwI dl6VhMGVTAciw1qT4RQtzsdi+d1zusigiy7cRaAQiuHkvzU6scEJyLMmgisxy7OflB0pa5Bb9GC sFlf1UNC/d8IerFhmszaWoBsIkDCLWvxHlsdX148PyKoaUNttfbHHgH4XKMVk5PdFw0QcQdwWxn 8zHIRh1hSBJtnd4xZCbk2zQgW8HT+ZOU++/1PNz1QzKM2I+psNcKLyp7xAcmJpd94g77YqfEt4t LC+KdpI1aP0pGXjB5olpxES368Uo0wyjKaF53mdDze/5z4dxmEn/3jMdC4boA6aHbNZB/mg== X-Received: by 2002:a05:7022:f97:b0:122:8d:3688 with SMTP id a92af1059eb24-124a00aad75mr3507981c88.22.1769614245533; Wed, 28 Jan 2026 07:30:45 -0800 (PST) X-Received: by 2002:a05:7022:f97:b0:122:8d:3688 with SMTP id a92af1059eb24-124a00aad75mr3507956c88.22.1769614244895; Wed, 28 Jan 2026 07:30:44 -0800 (PST) Received: from [10.227.110.203] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-124a9d6b906sm2993776c88.4.2026.01.28.07.30.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jan 2026 07:30:44 -0800 (PST) Message-ID: <9c2e80eb-1585-46eb-a0c4-95c0b50f25fd@oss.qualcomm.com> Date: Wed, 28 Jan 2026 07:30:43 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 ath-current 0/2] wifi: ath11k: add usecase firmware handling based on device compatible To: Krzysztof Kozlowski , Miaoqing Pan , jjohnson@kernel.org, johannes@sipsolutions.net, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, jonas.gorski@gmail.com References: <20260121095055.3683957-1-miaoqing.pan@oss.qualcomm.com> <74176aab-03d4-4095-890d-7ef1739b914b@oss.qualcomm.com> <32845805-5758-4c35-8818-ebccbfd9546a@kernel.org> From: Jeff Johnson Content-Language: en-US In-Reply-To: <32845805-5758-4c35-8818-ebccbfd9546a@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: pSp8eJx_ZCNdqeWay3BN-D1_OmQcCKYq X-Proofpoint-GUID: pSp8eJx_ZCNdqeWay3BN-D1_OmQcCKYq X-Authority-Analysis: v=2.4 cv=b9G/I9Gx c=1 sm=1 tr=0 ts=697a2ba6 cx=c_pps a=kVLUcbK0zfr7ocalXnG1qA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Zvf348k4SDH0cqSWWfIA:9 a=QEXdDO2ut3YA:10 a=vr4QvYf-bLy2KjpDp97w:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI4MDEyNyBTYWx0ZWRfX/pewMyuvE7X4 2OWgBnoS0egMr4uIy7XT8Kns9ikLDlEx45+wLwtsJOPi9CwsxHPA48vIg1K6J+4l1buCobgcJy9 L/KXpzvFM+0XtuJLj7SMJlPfJ/nNUssGIhPJdVhfmKSB68cU0d6Vfv3LdY3DpZ6U/m4xNlM6T+e TFTRB5rsy8DdbRwnxcqRq1Y8ghO1bHfybDHX1jCY85i9oSYyEyElbV5pm3e+y0UqNqzeNqiaTjd +I+YM9iTBvECOC6ABY6a0f740rceqJ2jAX58LNqB9cGxbf3ZBRao1sCrQ3jO2sbB/fkoQbUrYqn KEm2KqlKaOAwe9MFfQEg2o57+UyM5hQJ1aX8PFBfLPZ/ZKjNmo5FD+c8RpCDdmSsyY57RghVwVu DPQxDQrlXxfWxN8ZLZqUAU+XvqqkCMAZMsRErrxtpxvINl88XhsNNlOrvwVIXahU7lQy6GYWf0q U8D1eOZNMDOmVjERurQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-28_03,2026-01-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 suspectscore=0 bulkscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601280127 On 1/28/2026 12:01 AM, Krzysztof Kozlowski wrote: > On 27/01/2026 18:31, Jeff Johnson wrote: >> On 1/21/2026 1:50 AM, Miaoqing Pan wrote: >>> The 'firmware-name' property was introduced to allow end-users and >>> integrators to select use-case-specific firmware for the WCN6855. >>> But for M.2 WLAN chips, there is no suitable DTS node to specify >>> the 'firmware-name' property. In addition, assigning firmware for >>> the M.2 PCIe interface causes chips that do not use use-case-specific >>> firmware to fail. Therefore, abandoning the approach of specifying >>> firmware in DTS. As an alternative, propose a static lookup table >>> mapping device compatible to firmware names. >>> >>> --- >>> v2: >>> - Drops `firmware-name` from completely. >>> - Updates the commit message to clearly state that the property is >>> obsolete and the change is ABI-breaking but safe for upstream. >>> v3: >>> - Deprecate 'firmware-name' property instead of obsolete. >>> - Keep the ABI backwards compatible. >>> v4: >>> - Use of_machine_is_compatible() to simplify the code. >>> - Add back Acked-by tag. >>> --- >>> >>> Miaoqing Pan (2): >>> wifi: ath11k: add usecase firmware handling based on device compatible >>> dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' >>> property >>> >>> .../net/wireless/qcom,ath11k-pci.yaml | 1 + >>> drivers/net/wireless/ath/ath11k/core.c | 27 +++++++++++++++++++ >>> drivers/net/wireless/ath/ath11k/core.h | 4 +++ >>> 3 files changed, 32 insertions(+) >>> >>> >>> base-commit: d8e1f4a193101a72235416f189b01131a57e26e9 >> >> Krzysztof, >> Since you previously NAKed this series, can you confirm that your review >> comments have been addressed? > > > Binding looks fine, but I did not check the driver. Thanks Krzysztof for your re-review. Although tagged for ath-current, we are too far in the v6.19 release cycle for this, so I'll be taking it through ath-next for the v7.0 merge window. /jeff