From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933007AbdK2PVu (ORCPT ); Wed, 29 Nov 2017 10:21:50 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:53788 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932079AbdK2PVs (ORCPT ); Wed, 29 Nov 2017 10:21:48 -0500 Subject: Re: [PATCH] perf annotate: Fix objdump comment parsing for Intel mov dissassembly To: Thomas-Mich Richter , acme@kernel.org Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, Ravi Bangoria References: <20171128075632.72182-1-tmricht@linux.vnet.ibm.com> <69859e3b-cb22-a536-79ca-ffc44c3f86a8@linux.vnet.ibm.com> From: Ravi Bangoria Date: Wed, 29 Nov 2017 20:52:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 17112915-0016-0000-0000-0000050700C1 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17112915-0017-0000-0000-00002842E968 Message-Id: <9c33e7e2-9101-27fa-d1f4-cbdb4777fcc5@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-29_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711290200 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/29/2017 08:33 PM, Thomas-Mich Richter wrote: > On 11/29/2017 02:24 PM, Ravi Bangoria wrote: >> >> On 11/28/2017 01:26 PM, Thomas Richter wrote: >>> The command 'perf annotate' parses the output of objdump and also >>> investigates the comments produced by objdump. For example the >>> output of objdump produces (on x86): >>> >>> 23eee: 4c 8b 3d 13 01 21 00 mov 0x210113(%rip),%r15 >>> # 234008 >>> >>> and the function mov__parse() is called to investigate the complete >>> line. Mov__parse() breaks this line into several parts and finally >>> calls function comment__symbol() to parse the data after the comment >>> character '#'. Comment__symbol() expects a hexadecimal address followed >>> by a symbol in '<' and '>' brackets. >>> >>> However the 2nd parameter given to function comment__symbol() >>> always points to the comment character '#'. The address parsing >>> always returns 0 because the character '#' is not a digit and >>> strtoull() fails without being noticed. >>> >>> Fix this by advancing the second parameter to function comment__symbol() >>> by one byte before invocation and add an error check after strtoull() >>> has been called. >> Yeah, looks like it fails to get correct value in 'addrp'. >> >> Can you please show the difference in perf annotate output before >> and after patch. >> >> Thanks, >> Ravi >> > > There is no difference in output of --stdio. The adress value is not > read and remains 0x0 in ops->source.addr or ops->target.addr. > That is not visible because in function mov__scnprintf() that wrong > address is not printed: > > static int mov__scnprintf(struct ins *ins, char *bf, size_t size, > struct ins_operands *ops) > { > return scnprintf(bf, size, "%-6.6s %s,%s", ins->name, > ops->source.name ?: ops->source.raw, > ops->target.name ?: ops->target.raw); > } Looks good.  Ack-by: Ravi Bangoria Thanks, Ravi