From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 838E3C433F5 for ; Thu, 23 Sep 2021 14:05:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 676B560E54 for ; Thu, 23 Sep 2021 14:05:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241493AbhIWOGe (ORCPT ); Thu, 23 Sep 2021 10:06:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52140 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241395AbhIWOGc (ORCPT ); Thu, 23 Sep 2021 10:06:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632405901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VsAts9Q4cwqRnECWV/CpOEJx7x5ko4DvOI5TTEhPoyU=; b=HWe+CtaXpnMiGrX/XPJN+jstMirnjbwFvGJab+bWnNjJRVKHefGBhVd6/9Vi0HOLGP/Vzf xbMGWFAveHzldwPewFEUUdo1qtgZavLpqtIPJsOICGzUqbLarNRqqjgMgqdMSkzKfW1p2B WFVcbE9BK5aLwABGbJtE05cCILVCCfU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-273-4d0WIrzQNhSoC_fra7rOAA-1; Thu, 23 Sep 2021 10:04:59 -0400 X-MC-Unique: 4d0WIrzQNhSoC_fra7rOAA-1 Received: by mail-wr1-f71.google.com with SMTP id k2-20020adfc702000000b0016006b2da9bso5235673wrg.1 for ; Thu, 23 Sep 2021 07:04:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VsAts9Q4cwqRnECWV/CpOEJx7x5ko4DvOI5TTEhPoyU=; b=rqfrHL8pCk43HhEMVYQrLjSfI34+Hyl3dOjtn3pDkuxFbY+/G1HqBV9scJvtXqAcH8 8Py4JuNB9YF79Dn2RdOy9pDhVJtiEq4I96+Mu5z0UC7cOgis/n6YroDQ6AniBN76mpAi X7VyXRE2A8glf7ticPJ+DpHEvjNMTlrCyFlxDDzUcrkAcdWUTzV3S88mqwl5TGWoTIjI c1Wrj9oqPd82F1Zu1td5PSF16RP1Iv6rvDfVgSW6AowFPe7o3c0nNt0I7Y94BXEBbRAb pdAiaog2WUYNJHzLjrMf7GnoOnO2jIHSSxPjsJg6oK27kAbB2SCuvhCASVmX67OHx7gi TvUQ== X-Gm-Message-State: AOAM532lHADrHO2/GnW49+V6GjLZ4WSVqJc6+KNwQUvFHz3R48dD6xkc EppZZTzQNf1jevS3ca15qNObMtwMQ0fDp6j0ESlWeUvGIavUe6n5xzEhSN1JPtiPHTetcESl3QV sQwfaSl080cpDoeflpt9xqlth X-Received: by 2002:a05:600c:2046:: with SMTP id p6mr16758901wmg.88.1632405898435; Thu, 23 Sep 2021 07:04:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxmPeUhckrz1cu6qABX4N/FH2VAW6CuQg+dvlzGXvc88NpDgdsJEVUaRU+ivTZuzMNimKwCg== X-Received: by 2002:a05:600c:2046:: with SMTP id p6mr16758789wmg.88.1632405897446; Thu, 23 Sep 2021 07:04:57 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id e28sm5656512wrc.10.2021.09.23.07.04.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Sep 2021 07:04:56 -0700 (PDT) Subject: Re: [PATCH 01/14] KVM: x86: nSVM: restore int_vector in svm_clear_vintr To: Maxim Levitsky , kvm@vger.kernel.org Cc: Vitaly Kuznetsov , Borislav Petkov , Bandan Das , open list , Joerg Roedel , Ingo Molnar , Wei Huang , Sean Christopherson , "open list:KERNEL SELFTEST FRAMEWORK" , "H. Peter Anvin" , Jim Mattson , Thomas Gleixner , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Shuah Khan , Wanpeng Li References: <20210914154825.104886-1-mlevitsk@redhat.com> <20210914154825.104886-2-mlevitsk@redhat.com> From: Paolo Bonzini Message-ID: <9c368022-aee6-3790-2c43-28035c7e44e6@redhat.com> Date: Thu, 23 Sep 2021 16:04:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210914154825.104886-2-mlevitsk@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/09/21 17:48, Maxim Levitsky wrote: > In svm_clear_vintr we try to restore the virtual interrupt > injection that might be pending, but we fail to restore > the interrupt vector. > > Signed-off-by: Maxim Levitsky > --- > arch/x86/kvm/svm/svm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c > index 05e8d4d27969..b2e710a3fff6 100644 > --- a/arch/x86/kvm/svm/svm.c > +++ b/arch/x86/kvm/svm/svm.c > @@ -1566,6 +1566,8 @@ static void svm_clear_vintr(struct vcpu_svm *svm) > > svm->vmcb->control.int_ctl |= svm->nested.ctl.int_ctl & > V_IRQ_INJECTION_BITS_MASK; > + > + svm->vmcb->control.int_vector = svm->nested.ctl.int_vector; > } > > vmcb_mark_dirty(svm->vmcb, VMCB_INTR); > Queued, thanks. Paolo