From: Andrew Lunn <andrew@lunn.ch>
To: Alexandru Ardelean <alex@shruggie.ro>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk,
olteanv@gmail.com, marius.muresan@mxt.ro
Subject: Re: [PATCH 2/2] dt-bindings: net: phy: vsc8531: document 'vsc8531,clkout-freq-mhz' property
Date: Sat, 8 Jul 2023 20:25:31 +0200 [thread overview]
Message-ID: <9c37e2d5-a430-4a0f-b6b9-5de0dc14033f@lunn.ch> (raw)
In-Reply-To: <20230706081554.1616839-2-alex@shruggie.ro>
On Thu, Jul 06, 2023 at 11:15:54AM +0300, Alexandru Ardelean wrote:
> For VSC8351 and similar PHYs, a new property was added to generate a clock
> signal on the CLKOUT pin.
> This change documents the change in the device-tree bindings doc.
>
> Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
> ---
> Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> index 0a3647fe331b..133bdd644618 100644
> --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> @@ -31,6 +31,10 @@ Optional properties:
> VSC8531_LINK_100_ACTIVITY (2),
> VSC8531_LINK_ACTIVITY (0) and
> VSC8531_DUPLEX_COLLISION (8).
> +- vsc8531,clkout-freq-mhz : For VSC8531 and similar PHYs, this will output
> + a clock signal on the CLKOUT pin of the chip.
> + The supported values are 25, 50 & 125 Mhz.
> + Default value is no clock signal on the CLKOUT pin.
It is possible this could cause regressions. The bootloader could
turned the clock on, and then Linux leaves it alone. Now, it will get
turned off unless a DT property is added.
I prefer to explicitly have the property, so there is no dependency on
the bootloader, so lets leave it like this. But if we do get
regressions reported, this might need to change.
Andrew
next prev parent reply other threads:[~2023-07-08 18:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 8:15 [PATCH 1/2] net: phy: mscc: add support for CLKOUT ctrl reg for VSC8531 and similar Alexandru Ardelean
2023-07-06 8:15 ` [PATCH 2/2] dt-bindings: net: phy: vsc8531: document 'vsc8531,clkout-freq-mhz' property Alexandru Ardelean
2023-07-06 19:11 ` Rob Herring
2023-07-06 19:54 ` Alexandru Ardelean
2023-07-08 18:25 ` Andrew Lunn [this message]
2023-07-12 17:34 ` Alexandru Ardelean
2023-07-08 18:28 ` [PATCH 1/2] net: phy: mscc: add support for CLKOUT ctrl reg for VSC8531 and similar Andrew Lunn
2023-07-12 17:34 ` Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c37e2d5-a430-4a0f-b6b9-5de0dc14033f@lunn.ch \
--to=andrew@lunn.ch \
--cc=alex@shruggie.ro \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marius.muresan@mxt.ro \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®