From: Jack Zhu <jack.zhu@starfivetech.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Eugen Hristev <eugen.hristev@collabora.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <changhuang.liang@starfivetech.com>
Subject: Re: [PATCH v7 3/6] media: starfive: camss: Add basic driver
Date: Thu, 27 Jul 2023 06:18:58 +0800 [thread overview]
Message-ID: <9c38930b-4bd9-4956-74c7-3be2915f4676@starfivetech.com> (raw)
In-Reply-To: <d939d08d-9e5a-b620-5d4f-cc805bcc76b7@linaro.org>
Hi Bryan,
Thank you for your comments.
On 2023/7/26 18:58, Bryan O'Donoghue wrote:
> On 19/06/2023 12:28, Jack Zhu wrote:
>> Add basic platform driver for StarFive Camera Subsystem.
>
> Another nit here.
>
> "Add basic driver" isn't a great title. Recommend "Add core driver".
>
> Basic implies a thing that will be added to or improved upon but, this code here is your "core" interface where you do your probing and resource parsing/allocation etc.
>
> Use "core" not "basic" to describe this.
>
Ok, I will modify this title.
> ---
> bod
>
--
Regards,
Jack Zhu
next prev parent reply other threads:[~2023-07-26 22:19 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 11:28 [PATCH v7 0/6] Add StarFive Camera Subsystem driver Jack Zhu
2023-06-19 11:28 ` [PATCH v7 1/6] media: dt-bindings: Add JH7110 Camera Subsystem Jack Zhu
2023-06-19 11:28 ` [PATCH v7 2/6] media: admin-guide: Add starfive_camss.rst for Starfive " Jack Zhu
2023-07-26 11:26 ` Bryan O'Donoghue
2023-07-26 22:26 ` Jack Zhu
2023-07-27 10:23 ` Laurent Pinchart
2023-07-31 3:39 ` Jack Zhu
2023-06-19 11:28 ` [PATCH v7 3/6] media: starfive: camss: Add basic driver Jack Zhu
2023-07-26 10:55 ` Bryan O'Donoghue
2023-07-26 22:14 ` Jack Zhu
2023-07-26 10:58 ` Bryan O'Donoghue
2023-07-26 22:18 ` Jack Zhu [this message]
2023-07-27 11:33 ` Laurent Pinchart
2023-08-01 3:24 ` Jack Zhu
2023-08-01 18:45 ` Laurent Pinchart
2023-08-02 1:22 ` Jack Zhu
2023-06-19 11:28 ` [PATCH v7 4/6] media: starfive: camss: Add video driver Jack Zhu
2023-07-27 8:49 ` Hans Verkuil
2023-08-01 6:23 ` Jack Zhu
2023-08-01 18:47 ` Laurent Pinchart
2023-08-02 1:26 ` Jack Zhu
2023-07-27 15:25 ` Laurent Pinchart
2023-08-02 2:57 ` Jack Zhu
2023-08-02 9:13 ` Laurent Pinchart
2023-06-19 11:28 ` [PATCH v7 5/6] media: starfive: camss: Add ISP driver Jack Zhu
2023-06-22 3:29 ` kernel test robot
2023-07-26 9:11 ` Hans Verkuil
2023-07-26 10:01 ` Jack Zhu
2023-07-27 20:41 ` Laurent Pinchart
2023-08-02 9:57 ` Jack Zhu
2023-08-02 10:48 ` Laurent Pinchart
2023-08-03 2:41 ` Jack Zhu
2023-08-03 22:07 ` Laurent Pinchart
2023-06-19 11:28 ` [PATCH v7 6/6] media: starfive: camss: Add VIN driver Jack Zhu
2023-07-27 20:49 ` Laurent Pinchart
2023-08-02 9:58 ` Jack Zhu
2023-08-02 10:38 ` Laurent Pinchart
2023-08-03 2:44 ` Jack Zhu
2023-08-03 22:18 ` Laurent Pinchart
2023-08-04 11:14 ` Jack Zhu
2023-08-24 13:38 ` Laurent Pinchart
2023-07-10 5:45 ` [PATCH v7 0/6] Add StarFive Camera Subsystem driver Jack Zhu
2023-07-26 7:28 ` Jack Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c38930b-4bd9-4956-74c7-3be2915f4676@starfivetech.com \
--to=jack.zhu@starfivetech.com \
--cc=bryan.odonoghue@linaro.org \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®