From: Alex Elder <elder@ieee.org>
To: Jaehee Park <jhpark1013@gmail.com>, johan@kernel.org
Cc: elder@kernel.org, gregkh@linuxfoundation.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH 0/2] staging: greybus: fix warnings reported by checkpatch
Date: Mon, 11 Apr 2022 20:55:14 -0500 [thread overview]
Message-ID: <9c3bdbce-e898-696b-b645-6e566faffa85@ieee.org> (raw)
In-Reply-To: <cover.1649712572.git.jhpark1013@gmail.com>
On 4/11/22 8:50 PM, Jaehee Park wrote:
> The first patch corrects a typo in a comment. The second patch fixes
> 'void function return statements are not generally useful' warning.
>
> Jaehee Park (2):
> staging: greybus: correct typo in comment 'Atleast' to 'At least'
> staging: greybus: remove return in an empty void function
>
> drivers/staging/greybus/arche-apb-ctrl.c | 2 +-
> drivers/staging/greybus/audio_codec.c | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
These are really trivial patches. Whether the second
one is even worth changing is questionable (it represents
"code churn" without really adding value).
That said, you've properly submitted the patches and I
have no problem with either one. So someone else can
object, but if they do not:
Reviewed-by: Alex Elder <elder@linaro.org>
prev parent reply other threads:[~2022-04-12 1:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 1:50 Jaehee Park
2022-04-12 1:50 ` [PATCH 1/2] staging: greybus: correct typo in comment 'Atleast' to 'At least' Jaehee Park
2022-04-12 1:50 ` [PATCH 2/2] staging: greybus: remove return in an empty void function Jaehee Park
2022-04-12 7:04 ` Julia Lawall
2022-04-12 20:02 ` Jaehee Park
2022-04-12 7:28 ` Dan Carpenter
2022-04-12 20:03 ` Jaehee Park
2022-04-12 1:55 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c3bdbce-e898-696b-b645-6e566faffa85@ieee.org \
--to=elder@ieee.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=jhpark1013@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®