From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
WANG Chao <chaowang@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/4] x86, kdump: Set crashkernel_low automatically
Date: Sun, 14 Apr 2013 20:26:12 -0700 [thread overview]
Message-ID: <9c406d9c-e69c-4d09-bdfc-6cecb53f373a@email.android.com> (raw)
In-Reply-To: <CAE9FiQUGxGveg__VHE0-f0zfuY1ivuDMpQmMb9p0ic5=Hyf91A@mail.gmail.com>
Then make the comment so it is actually possible to understand that.
Yinghai Lu <yinghai@kernel.org> wrote:
>On Sun, Apr 14, 2013 at 6:59 PM, H. Peter Anvin <hpa@zytor.com> wrote:
>> On 04/11/2013 11:54 PM, Yinghai Lu wrote:
>>
>>> + /*
>>> + * two parts from lib/swiotlb.c:
>>> + * swiotlb size: user specified with swiotlb= or
>default.
>>> + * swiotlb overflow buffer: now is hardcoded to
>32k,
>>> + * round to 8M to cover more others.
>>> + */
>>
>> This comment is incomprehensible. "Cover more others"?
>
>i mean other buffers that may need to stay low, but we do not know
>them eactly yet.
>
>Thanks
>
>Yinghai
--
Sent from my mobile phone. Please excuse brevity and lack of formatting.
next prev parent reply other threads:[~2013-04-15 3:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 6:54 [PATCH -v5 0/4] x86, kdump: Fix crashkernel high with old kexec-tools Yinghai Lu
2013-04-12 6:54 ` [PATCH v5 1/4] x86, kdump: Set crashkernel_low automatically Yinghai Lu
2013-04-15 1:59 ` H. Peter Anvin
2013-04-15 2:59 ` Yinghai Lu
2013-04-15 3:26 ` H. Peter Anvin [this message]
2013-04-12 6:54 ` [PATCH v5 4/4] kexec: use Crash kernel for Crash kernel low Yinghai Lu
2013-04-12 6:54 ` [PATCH v5 2/4] x86, kdump: Retore crashkernel= to allocate under 896M Yinghai Lu
2013-04-12 6:54 ` [PATCH v5 3/4] x86, kdump: Change crashkernel_high/low= to crashkernel=,high/low Yinghai Lu
2013-04-15 0:20 ` HATAYAMA Daisuke
2013-04-12 20:07 ` [PATCH -v5 0/4] x86, kdump: Fix crashkernel high with old kexec-tools Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c406d9c-e69c-4d09-bdfc-6cecb53f373a@email.android.com \
--to=hpa@zytor.com \
--cc=chaowang@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome