Re: [PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible

[Satya Priya Kakitapalli <quic_skakitap@quicinc.com>]

On 7/3/2025 12:55 PM, Krzysztof Kozlowski wrote:
> On Thu, Jul 03, 2025 at 01:29:06AM +0300, Dmitry Baryshkov wrote:
>>> -      - qcom,sc7180-videocc
>>> -      - qcom,sc7280-videocc
>>> -      - qcom,sdm845-videocc
>>> -      - qcom,sm6350-videocc
>>> -      - qcom,sm8150-videocc
>>> -      - qcom,sm8250-videocc
>>> +    oneOf:
>>> +      - enum:
>>> +          - qcom,sc7180-videocc
>>> +          - qcom,sc7280-videocc
>>> +          - qcom,sdm845-videocc
>>> +          - qcom,sm6350-videocc
>>> +          - qcom,sm8150-videocc
>>> +          - qcom,sm8250-videocc
>>> +      - items:
>>> +          - const: qcom,sc8180x-videocc
>>> +          - const: qcom,sm8150-videocc
>>>   
>>>     clocks:
>>>       minItems: 1
>>> @@ -111,6 +115,7 @@ allOf:
>>>         properties:
>>>           compatible:
>>>             enum:
>>> +            - qcom,sc8180x-videocc
>> Is there a need for this? Isn't it already covered by the SM8150 entry?
> Yes and no. Yes - some change here is needed as I explained. No - this
> exact change does not work, so it is obviously redundant.


Yes, I agree. I'll add 'contains:' throughout the schema and remove this 
compatible since anyway it matches with sm8150 compatible.


Thanks,

Satya Priya