mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Yan <yanaijie@huawei.com>
To: Xingui Yang <yangxingui@huawei.com>, <john.g.garry@oracle.com>,
	<jejb@linux.ibm.com>, <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linuxarm@huawei.com>, <liyihang9@h-partners.com>,
	<liuyonglong@huawei.com>, <kangfenglong@huawei.com>
Subject: Re: [PATCH] scsi: libsas: handle linkrate change in sas_rediscover_dev
Date: Tue, 12 May 2026 21:18:26 +0800	[thread overview]
Message-ID: <9c4a1438-bd8f-4107-a519-a222e20f5da6@huawei.com> (raw)
In-Reply-To: <20260512071226.2299741-1-yangxingui@huawei.com>

在 2026/5/12 15:12, Xingui Yang 写道:
> When a device attached to an expander phy experiences a linkrate change
> (e.g., due to cable reconnection or negotiation), the current code in
> sas_rediscover_dev() treats it as "broadcast flutter" and takes no action
> if the SAS address and device type remain unchanged.
> 
> However, for drivers like hisi_sas, the ITCT entry needs to be updated to
> reflect the new linkrate. Without this update, the hardware continues
> using stale linkrate information, which can cause performance issues or
> protocol errors.
> 
> This patch introduces a new LLDD callback lldd_dev_info_update() to notify
> the low-level driver when a device's linkrate changes, allowing the driver
> to update its hardware structures accordingly.
> 
> Additionally, refactor sas_ex_to_ata() to use a new helper function
> sas_ex_to_dev() which returns any device type attached to an expander phy,
> improving code reuse.

Could you split this refactor to another patch? This makes it easier to 
review.

祝一切顺利
Jason

  reply	other threads:[~2026-05-12 13:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12  7:12 Xingui Yang
2026-05-12 13:18 ` Jason Yan [this message]
2026-05-13  2:06   ` yangxingui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c4a1438-bd8f-4107-a519-a222e20f5da6@huawei.com \
    --to=yanaijie@huawei.com \
    --cc=jejb@linux.ibm.com \
    --cc=john.g.garry@oracle.com \
    --cc=kangfenglong@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=liuyonglong@huawei.com \
    --cc=liyihang9@h-partners.com \
    --cc=martin.petersen@oracle.com \
    --cc=yangxingui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®