From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>,
Mark Rutland <mark.rutland@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Helen Koike <helen.koike@collabora.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Collabora Kernel ML <kernel@collabora.com>,
dafna3@gmail.com
Subject: Re: [PATCH] dt-bindings: fix compilation error of the example in intel,lgm-emmc-phy.yaml
Date: Fri, 24 Jan 2020 15:29:07 +0100 [thread overview]
Message-ID: <9c4a971f-6a65-594e-4a79-9e2aa16e58cb@collabora.com> (raw)
In-Reply-To: <CAL_JsqKgNzY=KF8XzuGjw2NogBawfi0gh9ytrk_nw_Ewg2QDdg@mail.gmail.com>
On 24.01.20 15:03, Rob Herring wrote:
> On Fri, Jan 24, 2020 at 5:49 AM Dafna Hirschfeld
> <dafna.hirschfeld@collabora.com> wrote:
>>
>> Running:
>> export DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
>> 'make dt_binding_check'
>>
>> gives a compilation error. This is because in the example there
>> is the label 'emmc-phy' but labels are not allowed to have '-' sing.
>> Replace the '-' with '_' to fix the error.
>>
>> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
>
> There's a fix from the author, but you're first to get the fix correct, so:
Oh, sorry, I was not aware of that.
Dafna
>
> Fixes: 5bc999108025 ("dt-bindings: phy: intel-emmc-phy: Add YAML
> schema for LGM eMMC PHY")
> Acked-by: Rob Herring <robh@kernel.org>
>
> Kishon, Please apply these soon as linux-next is broken.
>
> Rob
>
next prev parent reply other threads:[~2020-01-24 14:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 11:49 Dafna Hirschfeld
2020-01-24 14:03 ` Rob Herring
2020-01-24 14:29 ` Dafna Hirschfeld [this message]
2020-01-27 12:24 ` Kishon Vijay Abraham I
2020-01-31 14:56 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c4a971f-6a65-594e-4a79-9e2aa16e58cb@collabora.com \
--to=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=helen.koike@collabora.com \
--cc=kernel@collabora.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®