From: Jie Luo <quic_luoj@quicinc.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<hkallweit1@gmail.com>, <linux@armlinux.org.uk>, <corbet@lwn.net>,
<netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v6 3/6] net: phy: at803x: add QCA8084 ethernet phy support
Date: Tue, 28 Nov 2023 15:16:45 +0800 [thread overview]
Message-ID: <9c4c1fe7-5d71-4bb2-8b92-f4e9a136e93d@quicinc.com> (raw)
In-Reply-To: <8e4046dd-813c-4766-83fb-c54a700caf31@lunn.ch>
On 11/27/2023 9:22 PM, Andrew Lunn wrote:
> On Mon, Nov 27, 2023 at 02:21:46PM +0800, Jie Luo wrote:
>>
>>
>> On 11/27/2023 1:31 AM, Andrew Lunn wrote:
>>>> + /* There are two PCSs available for QCA8084, which support the
>>>> + * following interface modes.
>>>> + *
>>>> + * 1. PHY_INTERFACE_MODE_10G_QXGMII utilizes PCS1 for all
>>>> + * available 4 ports, which is for all link speeds.
>>>> + *
>>>> + * 2. PHY_INTERFACE_MODE_2500BASEX utilizes PCS0 for the
>>>> + * fourth port, which is only for the link speed 2500M same
>>>> + * as QCA8081.
>>>> + *
>>>> + * 3. PHY_INTERFACE_MODE_SGMII utilizes PCS0 for the fourth
>>>> + * port, which is for the link speed 10M, 100M and 1000M same
>>>> + * as QCA8081.
>>>> + */
>>>
>>> How are these 3 modes configured? I don't see any software
>>> configuration of this in these drivers. Can it only by configured by
>>> strapping?
>>
>> The interface mode is passed in the .config_init, which is configured
>> by the PCS driver, the hardware register is located in the PCS, this
>> driver will be pushed later.
>
> Is this the same as how the syqca807x works? Can the PCS driver be
> shared by these two drivers?
I am not sure syqca807x, would you point me the code path of this driver?
>
> What i don't like at the moment is that we have two driver
> developments going on at once for hardware which seems very similar,
> but no apparent cooperation?
>
> Andrew
The PCS of qca8084 is the PHY PCS, which should be new PCS driver,
in the previous chips, we don't have this kind of PHY PCS.
next prev parent reply other threads:[~2023-11-28 7:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 6:07 [PATCH v6 0/6] add qca8084 ethernet phy driver Luo Jie
2023-11-26 6:07 ` [PATCH v6 1/6] net: phy: introduce core support for phy-mode = "10g-qxgmii" Luo Jie
2023-11-26 17:20 ` Andrew Lunn
2023-11-27 6:12 ` Jie Luo
2023-11-27 8:43 ` Russell King (Oracle)
2023-11-26 6:07 ` [PATCH v6 2/6] dt-bindings: net: ethernet-controller: add 10g-qxgmii mode Luo Jie
2023-11-26 17:20 ` Andrew Lunn
2023-11-26 6:07 ` [PATCH v6 3/6] net: phy: at803x: add QCA8084 ethernet phy support Luo Jie
2023-11-26 17:31 ` Andrew Lunn
2023-11-27 6:21 ` Jie Luo
2023-11-27 13:22 ` Andrew Lunn
2023-11-28 7:16 ` Jie Luo [this message]
2023-11-28 9:00 ` Russell King (Oracle)
2023-11-28 9:50 ` Jie Luo
2023-11-28 10:35 ` Russell King (Oracle)
2023-11-29 10:34 ` Jie Luo
2023-11-29 12:04 ` Vladimir Oltean
2023-12-01 8:05 ` Jie Luo
2023-11-26 6:07 ` [PATCH v6 4/6] net: phy: at803x: add the function phydev_id_is_qca808x Luo Jie
2023-11-26 6:07 ` [PATCH v6 5/6] net: phy: at803x: Add qca8084_config_init function Luo Jie
2023-11-26 6:07 ` [PATCH v6 6/6] net: phy: qca8084: add qca8084_link_change_notify Luo Jie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c4c1fe7-5d71-4bb2-8b92-f4e9a136e93d@quicinc.com \
--to=quic_luoj@quicinc.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®