From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DFD2286A9 for ; Sun, 15 Mar 2026 00:51:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773535889; cv=none; b=KoOPRQ3VOCFZCY3Zh38v+rKTAWPcLx4hBAxCoQH+vxSh/Yp8dnU3g17vjFAjkBY1kH2kcldcVBOUgwbICTRZbZ68oV2ohhZaq5YE+/Pjh+hD0JbmzE7IpDUf9YOJXpGILfhItMTxCGx5qI5cxyZ9gnhzR+d3qCo4bNhXARRuMaI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773535889; c=relaxed/simple; bh=log4Wo3l5RDbgapviPP+X1VkM+IbIPb2uLC6TKfEvr4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tEDX0rGZ66Abi3IzS/vSsQaEfyuLrrtGLhELDeOG8znsroltmrMJHbb4565Y2rfYdqRfUezw3QWVPwNSLJ40e8P4YSG/mA2LQI5r3XM2jLI1dyYD8gY2RJiaMRYoJjm8gejxt1CLBrp1BlP0xvlZtwm3yIf+hSDTM8z4ljqkP9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool; spf=pass smtp.mailfrom=packett.cool; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b=DRvR4QUU; arc=none smtp.client-ip=95.215.58.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=packett.cool Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b="DRvR4QUU" Message-ID: <9c4dad2c-25bd-47d2-bc40-9b551d023615@packett.cool> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=packett.cool; s=key1; t=1773535875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pZtyxbHkiRBLwkPVgVeFtZ6s5sbnrf0HLktsBRDQ70o=; b=DRvR4QUUdqxmEinGhXNRb4gRM7g8mkFIpCHdTiH6PJE7H5JhibRgd4pS88h+hZv59j7Ex9 76KhGcl5ZJR+X8ifbpSeb7q7+4mP+da/nIYk3R5rhRn1y1v9Xm8FJXmrMNQ2TzW2PcbkO6 8XzVMUvK1nur0gdbg5XHAtwD8Qbzelbc0vIGw70deJxpjaQTE1Oal9Ehz3HBy+XlyedRcf nRVzZs8RN+56vj4D7Unllkyts2uMchL+tYWHYqCvpgaXXtvjih1K5x87r6Qt1KyIVN59R/ kK/WxLHJssPmgb4vtvzRJQoPl7p5VZcUmtcAReEfU3E6Roa4mxem0VJoRZ1Xag== Date: Sat, 14 Mar 2026 21:51:02 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v5 00/10] drm/msm/dp: Drop the HPD state machine To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh , Yongxing Mou Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Val Packett In-Reply-To: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 3/13/26 10:09 PM, Dmitry Baryshkov wrote: > Currently, all HPD interrupt handling must go through the HPD state > machine. > > This has caused many issues where the DRM framework assumes that DP is > in one state while the state machine is stuck in another state. > > As discussed here [1], this series: > > - Removes the state machine > - Moves link training to atomic_enable() > - Changes the detect() behavior to return true if a display is physically > plugged in (as opposed to if the DP link is ready). > - Remove event queue and move internal HPD handling to hpd_notify() > > To correctly detect the displays which are plugged on boot on the boards > which use dp-connector devices, this series depends on [2]. USB-C and > eDP panels are handled natively. > > [1] https://patchwork.freedesktop.org/patch/656312/?series=142010&rev=2#comment_1201738 > [2] https://lore.kernel.org/all/20260314-dp-connector-hpd-v1-0-786044cedc17@oss.qualcomm.com/ Unfortunately this currently seems to mostly break link training with USB-C, on x1e80100-dell-latitude-7455: [  102.190083] [drm:msm_dp_ctrl_link_train_1_2 [msm]] *ERROR* link training #2 on phy 1 failed. ret=-110 [  102.192846] [drm:msm_dp_ctrl_setup_main_link [msm]] *ERROR* link training of LTTPR(s) failed. ret=-110 [  102.211095] [drm:msm_dp_bridge_atomic_enable [msm]] *ERROR* Failed link training (rc=-104) [  102.211164] [drm:msm_dp_aux_isr [msm]] *ERROR* Unexpected DP AUX IRQ 0x01000000 when not busy [  102.247168] [drm:msm_dp_ctrl_link_train_1_2 [msm]] *ERROR* link training #2 on phy 1 failed. ret=-110 [  102.252859] [drm:msm_dp_ctrl_setup_main_link [msm]] *ERROR* link training of LTTPR(s) failed. ret=-110 Once I did get it to connect on one of the ports, but then on unplug it didn't detect the unplug properly and continued trying to use the link: [ 1418.418954] disp_cc_mdss_dptx1_link_clk status stuck at 'off' [ 1418.420950] Failed to enable clk 'ctrl_link': -16 [ 1418.420959] [drm:msm_dp_ctrl_enable_mainlink_clocks [msm]] *ERROR* Unable to start link clocks. ret=-16 [ 1418.421058] [drm:msm_dp_bridge_atomic_enable [msm]] *ERROR* Failed link training (rc=-16) [ 1418.423228] Failed to enable clk 'ctrl_link': -16 [ 1418.423234] [drm:msm_dp_ctrl_enable_mainlink_clocks [msm]] *ERROR* Unable to start link clocks. ret=-16 [ 1418.423325] [drm:msm_dp_ctrl_on_stream [msm]] *ERROR* Failed to start link clocks. ret=-16 [ 1418.476234] [drm:dpu_encoder_phys_vid_wait_for_commit_done:543] [dpu error]vblank timeout: 808208c0 [ 1418.476272] [drm:dpu_kms_wait_for_commit_done:527] [dpu error]wait for commit done returned -110 [ 1418.509204] [drm:dpu_encoder_frame_done_timeout:2731] [dpu error]enc37 frame done timeout [ 1419.163337] [drm:dpu_encoder_phys_vid_wait_for_commit_done:543] [dpu error]vblank timeout: 808208c0 [ 1419.163365] [drm:dpu_kms_wait_for_commit_done:527] [dpu error]wait for commit done returned -110 But after reboot, link training was failing on both ports.. Thanks, ~val