From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DF962EA169 for ; Wed, 18 Feb 2026 21:01:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771448509; cv=none; b=ded7WdDAY7oneq29BKKB/stKQ6ichwXLhkCDPDJxvOubFVO6sguvZ9JODDAMDlnORSedu0HSE2xfOnQYF6mpeE4q22dlRQTe2CD5uAZfWj9j44kzJtw60K/QKeaw+j8FzMDxZ7F2DmlAwI0uWs8MqplrEsy/QN5GCp+ArWMdj9k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771448509; c=relaxed/simple; bh=6a0ZkYIkfSu3QEiYO7GH1ClAORPx9Gwc6j/Tv9mc5vQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Hs66ntyT433mu2op1PUxOh5Y/PsUFHK/HX3gdyt0h7M1pFbLn821RkXC9nd3nrb6jEhcsXb/qy9kUA7XugfQXzjfOdq1s9cohZrJ/QU9Pa+AqbDJxJjv8gXf7tNwljvA/xg8fILJLzxkQugaXAW1YxkU1BqFLVGGOCqptsnLd6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FJXJWE/p; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SAaxnsdV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FJXJWE/p"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SAaxnsdV" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61IFeZfx421067 for ; Wed, 18 Feb 2026 21:01:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7NmYNRNDIu9PQmPwjd187/cOTc2VjLx/wjEu2SMagQM=; b=FJXJWE/pqPoXtIFz YHOLVgar6dkTfxeaQt6PE2bcp5MCUx/m/+QaT2uxugllhiqUtMgytGEyYKkE8Du+ uD+gJAkBPAjTtN7RnIEr3DsKWgoVb95kp2Je6d0uO95IvMtvVC2ZcXOU6R0DBZ5F Pm2AIntulnDB5Lp1wy5V5fhS66qd+6hb1t0JWNrxPfmWQhkdp2J6sluIZL9hWHW6 P5dzgYFpZTeSKBK8enYW0Opdg4Zat6ioqAi9Bw9uatB6nemKjAFtqqJUmPTpxCf3 QIc0alnXvzu1SQnAHDKslue7Y9m1xmjj0Yv5dv+seHEnjgTvTzwbq4JB8VZ1cdL8 RlmdZQ== Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cd76e2etm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Feb 2026 21:01:47 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-948aff549d5so372144241.0 for ; Wed, 18 Feb 2026 13:01:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771448505; x=1772053305; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=7NmYNRNDIu9PQmPwjd187/cOTc2VjLx/wjEu2SMagQM=; b=SAaxnsdVhVIxLXYw3fHVM01tTIGC+0O/QppirSKXVM9sOWY7c41DysIkZVbjENwcKc 6Bfg6PaLgNnd9t8wQ1TNpKxPCkBOcmNoKqJJolHjBM0uVaRVCVDSiRDq3/sp1s0CrDuE 0y7uO52Hsl0jWPnXxZwBsWl7gdokDJE67jvcrjN73ij2ux9E698ZtC3bZcXP70p/Hnke AJpCpNOzUAD/c4Gf9qv6W3HXLT0E9WaRprRG46ew7ewJ5Qe2fdJqh+Xes1Ad6M6RQHhP vf4v6OEgn6VLMX6b6zIeDklBgA3j8mmuh9/awRUWUxEdiLLVHIo+b2e5zOmCXvgD+40t DtKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771448505; x=1772053305; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7NmYNRNDIu9PQmPwjd187/cOTc2VjLx/wjEu2SMagQM=; b=L0Flv2cnrbHMEtZevudMoC5rZl9no/oP3EZMNhSQJBkHREKI0BYyyWYsVpNimvfvZg etv/npV8yxgL5/kbuMKZWdhGceeMJP3f2I081sHCYu76skg/e81Pwu2kYT4vknKdl1lO rRb5v498/jl0FvenqyQ3I0xAdNWna9UEsO5/dZCdAyp0PAEu7jGTpE1T/M+BCYUTJCwY iZ96Fs5ek3A705zX3QFrqub+hGChm/FCOsJiENdhyQUtfyJr62Wx4B/1jgpsTqv6WpMw +bSyoAN1CN7rll2csVYrV4PJgTAdxXbruUWiRcZXEq1jNtmMPCi595OSQlWe1zV6/w1T WH1w== X-Forwarded-Encrypted: i=1; AJvYcCXnFpbpm3lx2oNpUQjXenUWcg2DeujG/MAOKE5q9cx75XRK1UDlUjpH0oFGeo6SkOTySWIHIdyxcLEZjyA=@vger.kernel.org X-Gm-Message-State: AOJu0YwOOZhEwV6KY6zkkQL1ugpuCmj6fBqBxSKdAy+gSy9Qqu03absh b/jCH1M8db2/r1t4ictIuWDCEbg5SmiqxX+89+nKEGqB0iyjR29iegOBPXWtTAJoKnuT0cPEPm4 mvJk7zGNX7p+ei/9SfHXchBNYxl11Rn3dshpa4olAmndXiL/T3THncC83BlF1QQ2WC2c= X-Gm-Gg: AZuq6aIpgIZ+9s9U9KLUv7IiPnfw5xlYgCUxQEoUI3W5MxUxM7zROPQIdz5sk8zyJB7 sLO8W7rEFC42P9knCWdGoZRbugd4dvy/JgVLUrDycsqkKrjnDsZiYHDENtBKQ5wmunU6LU+gnEY d4e6SpdXH+hnixS4mJkFHqdb9Tf6QNleWIFyUkEIaH1XrZ4bVcErKMPLYjASSRDV+2qxQ5GYlud 2+9IRwXOCp53kPpSwv8MCvLcNSCc7vHs7L8OLu5K2hpAe5bwMuIfVT44P/l90kybjaYaRPbChPj vsvl2P9jPmQGljLvTkzVMG3KDRQneGNweNu6+D1dI+rIL6L0hhEFSCQeK+SN6o0JdElpn2SeXgP bAkIqxMWxYyE1GuZxEA0A0kBwK3We9v5dkp5s+X4lCqRgO4hNig== X-Received: by 2002:a05:6102:3054:b0:5ef:a247:4755 with SMTP id ada2fe7eead31-5fe2b02388bmr5025272137.44.1771448505159; Wed, 18 Feb 2026 13:01:45 -0800 (PST) X-Received: by 2002:a05:6102:3054:b0:5ef:a247:4755 with SMTP id ada2fe7eead31-5fe2b02388bmr5025213137.44.1771448504451; Wed, 18 Feb 2026 13:01:44 -0800 (PST) Received: from [192.168.1.29] ([178.197.223.140]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4835dcfafcdsm940702795e9.9.2026.02.18.13.01.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Feb 2026 13:01:43 -0800 (PST) Message-ID: <9c507768-c173-430f-82f5-10c7d0d8837b@oss.qualcomm.com> Date: Wed, 18 Feb 2026 22:01:42 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] USB: typec: tcpci: Make tcpci_pm_ops variable static To: Badhri Jagan Sridharan Cc: Heikki Krogerus , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260216110403.159945-2-krzysztof.kozlowski@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@oss.qualcomm.com; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTpLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQG9zcy5xdWFsY29tbS5jb20+wsGXBBMB CgBBFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmkknB4CGwMFCRaWdJoFCwkIBwICIgIGFQoJ CAsCBBYCAwECHgcCF4AACgkQG5NDfTtBYpuCRw/+J19mfHuaPt205FXRSpogs/WWdheqNZ2s i50LIK7OJmBQ8+17LTCOV8MYgFTDRdWdM5PF2OafmVd7CT/K4B3pPfacHATtOqQFHYeHrGPf 2+4QxUyHIfx+Wp4GixnqpbXc76nTDv+rX8EbAB7e+9X35oKSJf/YhLFjGOD1Nl/s1WwHTJtQ a2XSXZ2T9HXa+nKMQfaiQI4WoFXjSt+tsAFXAuq1SLarpct4h52z4Zk//ET6Xs0zCWXm9HEz v4WR/Q7sycHeCGwm2p4thRak/B7yDPFOlZAQNdwBsnCkoFE1qLXI8ZgoWNd4TlcjG9UJSwru s1WTQVprOBYdxPkvUOlaXYjDo2QsSaMilJioyJkrniJnc7sdzcfkwfdWSnC+2DbHd4wxrRtW kajTc7OnJEiM78U3/GfvXgxCwYV297yClzkUIWqVpY2HYLBgkI89ntnN95ePyTnLSQ8WIZJk ug0/WZfTmCxX0SMxfCYt36QwlWsImHpArS6xjTvUwUNTUYN6XxYZuYBmJQF9eLERK2z3KUeY 2Ku5ZTm5axvlraM0VhUn8yv7G5Pciv7oGXJxrA6k4P9CAvHYeJSTXYnrLr/Kabn+6rc0my/l RMq9GeEUL3LbIUadL78yAtpf7HpNavYkVureuFD8xK8HntEHySnf7s2L28+kDbnDi27WR5kn u/POwU0EVUNcNAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDy fv4dEKuCqeh0hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOG mLPRIBkXHqJYoHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6 H79LIsiYqf92H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4ar gt4e+jum3NwtyupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8 nO2N5OsFJOcd5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFF knCmLpowhct95ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz 7fMkcaZU+ok/+HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgN yxBZepj41oVqFPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMi p+12jgw4mGjy5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYC GwwWIQSb0H4ODFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92 Vcmzn/jaEBcqyT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbTh LsSN1AuyP8wFKChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH 5lSCjhP4VXiGq5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpF c1D/9NV/zIWBG1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzeP t/SvC0RhQXNjXKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60 RtThnhKc2kLIzd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7q VT41xdJ6KqQMNGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZ v+PKIVf+zFKuh0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1q wom6QbU06ltbvJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHp cwzYbmi/Et7T2+47PN9NZAOyb771QoVr8A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=OKsqHCaB c=1 sm=1 tr=0 ts=699628bb cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=6nO30s3o7FuWeffXwhKHTA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=nvk9TAkxJId0z3ZGeJsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=o1xkdb1NAhiiM49bd1HK:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE4MDE4MCBTYWx0ZWRfX6lnT+5YUcd51 hyya95VlER6F9kFdQRSp4UC31pfmzh8biL9TbzrrDkLdmcijbPUtxsVPFC2m43+yTca+yQgxOBp wms/1sJ6zbQdz0j8GlMxsEdWahw+7qYqY7DnyeMwc9dR9EsWvdA4++bkpIMi+1ddforNWoxjvph yI0lBmZPy/h1oRwwpkWGjNVLEkhRlbWsQATgIn0YTVgL95EYymNqhRPXS0WMx6AFt9ozc84uZiR 3DjyWiYfwE8p24mj+HY2ulQPTHnZsqn0viNQCIxWp0S3r/dYQIJ0QyKUgTij6x4eRlSRGeoH0iZ dGylS1NZj92A5NSCo/lboyhTFLcJo8zfzRIWKov30K8k38VTrJd1iEY/xq9coBFN0xZQijd21uY yLG+WjtlNbHNHkrgiYluvYqzYyUef6JsM3HJgCmokFSFEBCSyHllS+V71BmnRkL3AEElA25N0iH JEuOATaXBp5kl4GGgnw== X-Proofpoint-GUID: sxO_ZiH3vg-AoC9gR00BzR_hm-ukeLrT X-Proofpoint-ORIG-GUID: sxO_ZiH3vg-AoC9gR00BzR_hm-ukeLrT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-18_04,2026-02-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 impostorscore=0 adultscore=0 suspectscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602180180 On 18/02/2026 21:35, Badhri Jagan Sridharan wrote: > On Mon, Feb 16, 2026 at 3:04 AM Krzysztof Kozlowski > wrote: >> >> File-scope 'tcpci_pm_ops' is not used outside of this unit, so make it >> static to silence sparse warning: >> >> tcpm/tcpci.c:1002:1: warning: symbol 'tcpci_pm_ops' was not declared. Should it be static? >> > > Thanks for sending the patch Krzysztof ! > Can you also please add "Fixes:" and "Cc: stable@vger.kernel.org" ? This has no practical impact on users, so I don't think it is a fix. It is a code improvement, but not a fix. Best regards, Krzysztof