From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CCE13E2751 for ; Thu, 4 Jun 2026 11:08:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780571297; cv=none; b=Ixx6ToISJ8+ywK3O2lPPuefJgZlu9Q3WlVWdePbX9Rq+Ti+89HmWzUidVjadci1Hcd856+IShIQl2jlUi4zl1smEPmCAaGYjIRvBAXfaPcrzaOiMDIKOW7g/q9scKLA7H97NcanLgxrprsET6r8ajgfNLaIp/wmfgTLmyIZkZKw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780571297; c=relaxed/simple; bh=9IX+gIu/sipRp3+05MODF1oy1T42D+gNSJh3mYqvTk0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Y6FySz4WX4U2HHvg9h8Rtehg/YmPIjuoB169m/mi46PuoeOXjmFfkxo50qhnJpdG82mCGhLd9lqzOQP2CMoofOYae5TJdexrjXlxthVoqunGJ2bA7JglDtVLrNLdCOvkjBypHMGJ6hubNpT0cWRoq1MZaZg/KspUV5CwBwRdyE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AEfpjs33; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=dJ/7U2A/; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AEfpjs33"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="dJ/7U2A/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780571295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8kkXn9BTLdD6FDIZ8v4AArbMY80UOZLqgsOOXo2fDIE=; b=AEfpjs33r6YFFb0cCCbfoKw6zKuli1uv0zp29OYa/BdT+jK6yKKqqfO7uAa1EqrdIRPX/I Hds0XlvLncinyeWi5wGMYUMd75lWiFGCZsO09v3UJ9q82CBxP5uHFWwHeQiynIblTIvgBy BiqY5Mg8b19m0hOmvVMqK3UsiNjq/Vs= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-421-hhOV3RkgOY66eQscHkxEuA-1; Thu, 04 Jun 2026 07:08:14 -0400 X-MC-Unique: hhOV3RkgOY66eQscHkxEuA-1 X-Mimecast-MFC-AGG-ID: hhOV3RkgOY66eQscHkxEuA_1780571293 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4601daf4c65so379019f8f.2 for ; Thu, 04 Jun 2026 04:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780571293; x=1781176093; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=8kkXn9BTLdD6FDIZ8v4AArbMY80UOZLqgsOOXo2fDIE=; b=dJ/7U2A/hL5O6lPm4GBry2z/JRkPn+IQaIfs4xwv1xLjGtYplFOnXnAaXbDmIZY03k E1tJRVJegAQ1IG7rX08Frb+nrDyw5+ifmUpuqAV2Rg+UZkeiJv5Pb1N2nzd/8x0jap1Y f912ZVxK5qqar/VS6QqWnzrONmxSQcxl1UvFbGvC7Jk8SAaZKccDt7S0obdqW2DtrOI+ oAUdv5PIg9/Pb8STcodFBSpMVSmkQkHqrFuAzzux+jqH49mFSHjNCrMa9BT9vS/1C/Qh RCkNIC7c0KBaqeXMvvF/HIVkqNBQIOll1dqQpQPmJBHxFr/VteoF2TwktmWv/C7fEvN+ DU0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780571293; x=1781176093; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8kkXn9BTLdD6FDIZ8v4AArbMY80UOZLqgsOOXo2fDIE=; b=Rl0T6ifdaYPhi+XbJ80+kQ21ZZ95GaLRiQLXL1wOivFnB+jUKkwcBH5VCUyaZ1eHXT iY+Sq3LMm9Ds+W2EMo/bZfNwHCAXeNjnfA1UzIt3MPHjqoAUTWXUJ2s+p3SMiObbcfTY spSmmOa9h9HWN/dGfPMsZPuFInnLR9S2iVHbaSq4qcacdKQb8nQEoDQrgvYr4ECupbKw ysdYU7BKElxq02kgZvlxtpktO6Q/UzXlnYVgUfNj1xfpMhVsAI7JWoufshGMQdz87LW4 QybMDVjEx7oRgHUZn17uxnKUbqi1dVruIwPj+9HUK1EDx6NH3/oG0yMLNOpB/DvLfqra ecgg== X-Forwarded-Encrypted: i=1; AFNElJ+CDUgsfldPhXT+8G4gV7GXW+vE9UGN0NOLDPQo/Wn50RNqzBjeCwCe0qR7VJwB/fQYvDxsvpWPKV3O/Tw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx13PvUABxxmO3bG9GKh0uQj6ycwvkt61N9uW+kFeTsiFktG/gj umFiu7hDoeIh+m8PxVbtI+Gy23aGEGh/qquhQBS4eH4fm91MeHomafV9lOluJLMxNGPS+FZTv0s Py6Deoju0UCJ99kgEWsW6qMzUoNiMTcOwvWZqHwbkn/0C1q6po7BUkUavbX/QRhUuqQ== X-Gm-Gg: Acq92OHpszQb20ExfVgYum1eSnGCj+X54DUDmi1uPluszhm8x4eF98RmcdcU7ZTmaaq rphpxrMolnKdNLOaz/x6Jcjp+/ZXSmHyfGHTYeS2kOVGtV5ku9mvLYQWngl0Gw1Dh38sq5lxGy1 iUVcwV6j4QoltE2yCHUexgwm4tjpxjRFTGYUqU/PwXabwBhHnTvRPyW2935ZjdHEIYWVWoNplPw b0A04JS1u7pzIyS6p5GsBfQUr5ZPajAgOsHkhwGpf5UyJD+F8zdE6FGnkxmX3s8CHR36OTWeAQ4 0uboQrtWQzq14crJyExVsnw9hupHaFEoC0+TkCOYeBIeyNwpssmzUgA1G/xgcX7T6Ht0B8e7ue/ EDt+KyXESjdDhn7lXsc2sZVQ6J9QziDeBfkTE X-Received: by 2002:a05:6000:4188:b0:43d:6244:f8b with SMTP id ffacd0b85a97d-460217b976emr7618387f8f.13.1780571292829; Thu, 04 Jun 2026 04:08:12 -0700 (PDT) X-Received: by 2002:a05:6000:4188:b0:43d:6244:f8b with SMTP id ffacd0b85a97d-460217b976emr7618354f8f.13.1780571292460; Thu, 04 Jun 2026 04:08:12 -0700 (PDT) Received: from [192.168.1.167] ([185.168.96.228]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f35fb24sm16309633f8f.34.2026.06.04.04.08.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 04:08:12 -0700 (PDT) Message-ID: <9c5f9e0d9f115024afb8165057874905f7fd6567.camel@redhat.com> Subject: Re: [PATCH 1/1] tools/rv: ensure monitor name and desc are NUL-terminated From: Gabriele Monaco To: unknownbbqrx Cc: rostedt@goodmis.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 04 Jun 2026 13:08:10 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.1 (3.60.1-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2026-04-23 at 17:19 +0300, unknownbbqrx wrote: >=20 > ikm_fill_monitor_definition() copies monitor name and description > with strncpy(), but does not guarantee NUL termination when source > strings are equal to or longer than the destination buffers. >=20 > Clamp copies to sizeof(dst) - 1 and explicitly append '\0' for both > fields to keep them safe for later string operations. >=20 > Signed-off-by: unknownbbqrx Contributions need to be attributed to real people using official names. I'm going to re-send this patch with me as author and a Suggested-by: unknownbbqrx , unless you answer with an appropriate attribution (i.e. your real name) [1]. Thanks, Gabriele [1] - https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-= developer-s-certificate-of-origin > --- > =C2=A0tools/verification/rv/src/in_kernel.c | 7 ++++--- > =C2=A01 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/tools/verification/rv/src/in_kernel.c > b/tools/verification/rv/src/in_kernel.c > index 4bb746ea6..d32453824 100644 > --- a/tools/verification/rv/src/in_kernel.c > +++ b/tools/verification/rv/src/in_kernel.c > @@ -215,10 +215,11 @@ static int ikm_fill_monitor_definition(char > *name, struct monitor *ikm, char *co > =C2=A0 return -1; > =C2=A0 } > =C2=A0 > - strncpy(ikm->name, nested_name, MAX_DA_NAME_LEN); > + strncpy(ikm->name, nested_name, sizeof(ikm->name) - 1); > + ikm->name[sizeof(ikm->name) - 1] =3D '\0'; > =C2=A0 ikm->enabled =3D enabled; > - strncpy(ikm->desc, desc, MAX_DESCRIPTION); > - > + strncpy(ikm->desc, desc, sizeof(ikm->desc) - 1); > + ikm->desc[sizeof(ikm->desc) - 1] =3D '\0'; > =C2=A0 free(desc); > =C2=A0 > =C2=A0 return 0;