From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7E463F3288 for ; Thu, 3 Sep 2026 06:42:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788417763; cv=none; b=ZW+H7F/uU4NhzcsNWt7O7/ensW650ZWl/XBfYvql7COE5sZ0MyubiewCslsiD8GhTJOGIbDxSJlEiq2kS3DEC9A3IrQRCrhf4XJdQQV27ea4+DSaMY8NfFiwcJWuOAnYYvv9uOU/gPEiB3QT9ZbL8nNIBo0qWK5bN9UtnuAclMs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788417763; c=relaxed/simple; bh=coE+A/T6OYtv7EloBtl7FHeKXqEGRgr30Nuq5NB6xjw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FyTm4w7KRKSwJ5cBGLEn3Pwrx2XLhavJnjUaxO1stXxF2rTQXKO3S3hfSWCr8tXWJUSeWH+tmp/hYorSD9q027OEAcDqPI14CveeO5R5OD8KRvb3KcvR5djum/3MDHBmGjU7NCLVrC57XFIUegJXncO1dsfGSinFZnpQN3IxZ4A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Lu94deNH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DNhubKrC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Lu94deNH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DNhubKrC" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6835lVfc3244888 for ; Thu, 3 Sep 2026 06:42:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nY9b52v+DMvSwQj8tMDjZurLWIWOyHhy9GI9sNJbL/w=; b=Lu94deNH2niA1kju pvKGlpE3wf3qlQGsDZDywUPlfX4g3iBhdCbiGpO14W2c/hX+GaE730KDq/V3cQ4a S+afsGgl4PcasT1iiwvv8fCEsgExGvyaotTUYLy9/ONQ0pJ3uMlSIQB0y7d5alom /ufL38pp7nGr5jXdPetCbypJR9WLqeNVDls0jLq7zeTOkfk6reOiP0mT3tdjOFD2 m1Rj9tk8nPUyzABgwNU/bPyb4Ghge2Il3Duf1ekUq0KRitJRNkT5569II0afCJ8f 07rENu8bMnH1QtoJ55GuCFltRythCNEvIrPU4i9RhowoenuKzJpxtRz+itG7g3jL K50c9w== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gemcec40h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 03 Sep 2026 06:42:34 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-938fd633df7so39779785a.1 for ; Wed, 02 Sep 2026 23:42:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788417754; x=1789022554; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nY9b52v+DMvSwQj8tMDjZurLWIWOyHhy9GI9sNJbL/w=; b=DNhubKrCMl9JweXTot0xGOdGZKrNdMvxUAhpJOQrZoy3FVXqcef+I+IaragWnvgWN2 2hOx/VkFX+NoQPZU6k6v+1BUbAhlIc5Fbgwq2udIJW8kZ8ve4WiRG4shY5r7Of7noskq kvmGAVtiZKrNdYPhIqDCbGqycszqlPfbEWfFtA4CVPqxl3ZCd5jXbO/ZHyNsjcPEvWum wouRfBt23+TREx9QYf6fSoL32LlmW6FY3WQDoF0QyIgMN3xWrVa7q9yDDDjaoDD76E8q 1hVubkXpW+YzLauo2eaut38KIIdL1clTUIxJq3O4GWlPaIH2Cu14Xu9N8eSBNYAp5o4m LWWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788417754; x=1789022554; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nY9b52v+DMvSwQj8tMDjZurLWIWOyHhy9GI9sNJbL/w=; b=YT1UmZ+kitrNV+hmTBjGSy0ZE5WPLPwpLl2CkKzX4rgFqMj4yIUUYLUbXAcEOljAbx pwG9/QChMNQPWaBylMhiZV8pfvhugRNIFEzJMaxOWyZRtBTDD5D9auR8biPBmTWA8sty kvmO4Eqgkuz7lVzBdpNGEl1X8Eq7+Ei4s++P03R+MvDbqiL1OcDPr7tzcVkik+k6YIg+ YUUzkHySjMmIQg4SpDPwZVbxVyZ7/hpdJc8C6TFbpoZNpUgyUsZ4xfnRdjFHZsMpOeKS gPUz+C7SYD30g7XbVcNW4zmJxntbp1eEwbFyuvG1lhPyqiMADYfptxIkclGQgODyReES AcfQ== X-Forwarded-Encrypted: i=1; AKwUvBwCTMlonpzfcZApLxLKR6xxxFbdJhIixc3xUwCIyETxP2I+Y7aGc9qJT2BLT6pOTHi1op8iZiCMrBwqfC4=@vger.kernel.org X-Gm-Message-State: AFuF++l67152UiXrjinY9dCMGIh2t7KedqhA+a1T5xB7MgBhnT+Z6A1/ ukM5iHmVjYuhqXQcKqFckNEXwErH7opOTycB71vaF8E8gLZrLOUbzxU7GL3HMc5Tm5WNt4ecWJy rwTYAkMheANqAFXDsyyRH8EaV0WasoFYtRofa3EMATdPOOsykO7iEMIHpN4j6lBPt+Yg= X-Gm-Gg: AYBFou0KmiVpa7Tn6Xyvzwk3bEx7emzUu5O1w8dRstBkHR3V+FYijSHPadko11C20QL TkC0O/VdRqgG0YN3r98SQ7Jnkfs1Sf2j0peyGrSe4McpZdnVhpKVKfp7NTnUXsKKeevEFOEo1Ba gTLPM+6iNqLZzLOFUNQAZb0W+pK/GeahcoY6MtrtRX4GwWiRn9HIfexGLHKmznCpgKjfY8yU7ko UYgRycRVUBSeQwDzp/AjCxt7ftMDGFCxS1vGD7JPWJtOfM6YEoTCNRQaIyuOWkCVREf3NyiuJon 0FuDX5KgaDYXBsimxhFJsapcV5hQkzqX6jP8oDs11CtU/H3OOr/RQ/KLTYDVuMN3wDUXbckAfis t2ne/QEJefEGXKXqfg6cxhw== X-Received: by 2002:a05:620a:470e:b0:939:5924:e319 with SMTP id af79cd13be357-93960898d62mr721068985a.0.1788417753983; Wed, 02 Sep 2026 23:42:33 -0700 (PDT) X-Received: by 2002:a05:620a:470e:b0:939:5924:e319 with SMTP id af79cd13be357-93960898d62mr721067085a.0.1788417753456; Wed, 02 Sep 2026 23:42:33 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c25f4172516sm53588966b.21.2026.09.02.23.42.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Sep 2026 23:42:32 -0700 (PDT) Message-ID: <9c63c0a5-0730-4730-b210-18a36ce57287@oss.qualcomm.com> Date: Thu, 3 Sep 2026 08:42:30 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers To: Krzysztof Kozlowski , Krishna Kurapati Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260828081542.52796-1-krishna.kurapati@oss.qualcomm.com> <20260831-messy-ebony-warthog-cfd727@quoll> <6af2e860-ba7a-4f86-a0e7-872a312b47e4@oss.qualcomm.com> <06bce1c2-8498-4988-b5c0-ab42bfba86cb@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDA1OCBTYWx0ZWRfXyAFIJqzFX1C8 cUtNvOZlMpBj3DTRQXwPeBs0CSma42gWFuS1jnrg0fwlic+qtqcCptfqaJv8JQQyf7xnlvswVcS Z0zPF73A5th9iaXhtiH0df1YfCmnQW6/9u8G1b9H+YXVxngw4NRshLi5vFbYiJvnVdIg0lSMvsG +RwvU99HYj2MKXscKGDd6HSrlV4QQbsjD+J2U1DYV/YS+NeVvaVh7l45zUOLYEBp5MnPFTsgLOJ w2KGUoRGNix2kfxVRUxomwVjGMbRutSgwKetiS5sR4pdYCB/4WJVjUiD6Et7jrpotfbHR6O2WuV y2MeFxfSKaT4hwTaPU1foTbQH6/IsOUp7ozgQEY55gE4uXjZ2dfmMba/OOux0+7HvJ/QeLTg0u5 bK+B5tPblpt2YOHw8QHLqKgtfZd+I+PfR+4SFJzRTOOKfQqBaWwSrMLtoqnne1jQPj1I4FwCuJj jvGeO1aLJwxl62SNPwA== X-Proofpoint-ORIG-GUID: pN3ZizurjWY8XtyfLCG_JJD7U8x39Gmg X-Authority-Analysis: v=2.4 cv=QfpWeMbv c=1 sm=1 tr=0 ts=6a9916db cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=QueW_K6hlHS4BuxnnA0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: pN3ZizurjWY8XtyfLCG_JJD7U8x39Gmg X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDA1OCBTYWx0ZWRfX3LfLAtlv4K61 OLFThXhfucgFa477ZAMzonG33acS9hp2mIXfhbctSTHgsuiQ7Aee6SeKY3xU+mRw97yu7z0/VYa fVzcvikIjO2aEze2Uxk7L2XlLxnfdLk= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_02,2026-09-02_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 bulkscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030058 On 9/3/26 8:40 AM, Krzysztof Kozlowski wrote: > On 03/09/2026 08:32, Konrad Dybcio wrote: >> On 9/2/26 6:59 PM, Krishna Kurapati wrote: >>> >>> >>> On 9/2/2026 7:40 PM, Konrad Dybcio wrote: >>>> On 8/31/26 2:29 PM, Krzysztof Kozlowski wrote: >>>>> On 31/08/2026 11:03, Krishna Kurapati wrote: >>>>>> >>>>>> >>>>>> On 8/31/2026 2:07 PM, Krzysztof Kozlowski wrote: >>>>>>> On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote: >>>>>>>> Currently for Glymur non-multiport USB controllers, number of interrupts >>>>>>>> are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be >>>>>>>> present. >>>> >>>> [...] >>>> >>>>>>>>                  - qcom,eliza-dwc3 >>>>>>>> +              - qcom,glymur-dwc3 >>>>>>>>                  - qcom,ipq4019-dwc3 >>>>>>>>                  - qcom,ipq8064-dwc3 >>>>>>>>                  - qcom,kaanapali-dwc3 >>>>>>> >>>>>>> This changes the ABI without an explanation. >>>>>>> >>>>>> As per the harware specification, the controllers do have both >>>>>> hs_phy_irq and ss_phy_irq. Hence wanted the binding to capture that >>>>>> info. Will update the commit message accordingly. >>>>>> >>>>> >>>>> So the change in 99df63d20dabda8d7ae01bcca7cdb1e92110a555 was >>>>> incomplete? Lack of context here is not helping. >>>>> >>>>> If they have these IRQs but it does not matter, then it is not a good >>>>> reason to change ABI and you should just add the clock as optional to >>>>> the end. Was this binding already released? I think yes. >>>> >>>> IIUC the intent of the patch is to allow specifying the currently >>>> missing hs_phy_irq on non-multiport controllers (i.e. usb3_[012]). >>>> Bundling the DT change would have made that easier. >>> Yes, I wanted to add the missing hs_phy_irq. I didn't want to bundle in the DT along with the usb binding changes. DT change was posted separately: >>> >>> https://lore.kernel.org/all/20260803-glymur-dt-usb-fixes-v1-1-0f5f52853102@oss.qualcomm.com/ >> >> Shipping bindings and DT changes in a _series_ is preferred, what one >> must avoid is changing them within the same _patch_ > > No, DTS cannot be posted within USB patchset. Aah, I missed that point.. Konrad