From: YueHaibing <yuehaibing@huawei.com>
To: Kalle Valo <kvalo@codeaurora.org>,
Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: <j@w1.fi>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
<davem@davemloft.net>, Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] hostap: hide unused procfs helpers
Date: Fri, 27 Jul 2018 18:03:38 +0800 [thread overview]
Message-ID: <9c6401cd-c04c-1230-d360-922b476c6541@huawei.com> (raw)
In-Reply-To: <87r2jpvxme.fsf@codeaurora.org>
On 2018/7/27 17:25, Kalle Valo wrote:
> Arend van Spriel <arend.vanspriel@broadcom.com> writes:
>
>> + Randy
>>
>> On 7/13/2018 9:03 AM, YueHaibing wrote:
>>> When CONFIG_PROC_FS isn't set, gcc warning this:
>>>
>>> drivers/net/wireless/intersil/hostap/hostap_hw.c:2901:12: warning: ‘prism2_registers_proc_show’ defined but not used [-Wunused-function]
>>> static int prism2_registers_proc_show(struct seq_file *m, void *v)
>>>
>>> drivers/net/wireless/intersil/hostap/hostap_proc.c:16:12: warning: ‘prism2_debug_proc_show’ defined but not used [-Wunused-function]
>>> static int prism2_debug_proc_show(struct seq_file *m, void *v)
>>> ^
>>> drivers/net/wireless/intersil/hostap/hostap_proc.c:49:12: warning: ‘prism2_stats_proc_show’ defined but not used [-Wunused-function]
>>> static int prism2_stats_proc_show(struct seq_file *m, void *v)
>>> ^
>>> drivers/net/wireless/intersil/hostap/hostap_proc.c:177:12: warning: ‘prism2_crypt_proc_show’ defined but not used [-Wunused-function]
>>> static int prism2_crypt_proc_show(struct seq_file *m, void *v)
>>> ^
>>>
>>> fix this by adding #ifdef around them.
>>> hfa384x_read_reg is only used by prism2_registers_proc_show,so move it
>>> into #ifdef.
>>
>> There was already a fix for this posted by Randy Dunlap taking a
>> different approach, ie. use __maybe_unused classifier. To be honest I
>> prefer the ifdef approach as it is more explicit and does not feel
>> like a cheat.
>
> I also prefer the ifdef approach more so I'm planning to take this
> patch.
It's ok if you prefer pick this.
>
next prev parent reply other threads:[~2018-07-27 10:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 7:03 YueHaibing
2018-07-13 7:26 ` Arend van Spriel
2018-07-13 9:37 ` YueHaibing
2018-07-13 16:43 ` Randy Dunlap
2018-07-27 9:25 ` Kalle Valo
2018-07-27 10:03 ` YueHaibing [this message]
2018-07-27 15:46 ` Randy Dunlap
2018-07-31 7:21 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c6401cd-c04c-1230-d360-922b476c6541@huawei.com \
--to=yuehaibing@huawei.com \
--cc=arend.vanspriel@broadcom.com \
--cc=davem@davemloft.net \
--cc=j@w1.fi \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®