From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC579C433DF for ; Wed, 8 Jul 2020 12:43:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95C5920720 for ; Wed, 8 Jul 2020 12:43:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BdNai/0v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729288AbgGHMnY (ORCPT ); Wed, 8 Jul 2020 08:43:24 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:50300 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728803AbgGHMnX (ORCPT ); Wed, 8 Jul 2020 08:43:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594212202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WV6M1edub7XkEemGRBxIe4WR8aj11TMDUW7v+GRjIBg=; b=BdNai/0vhc4WR6gTgd1RnC0d+1FAbKAh7aB48pbCRsOo9mkLb7sO7uFza7YjM64ObaP6tz y4NjZPTEnoS+Swq4GMrwOMxbczwLnPO1CDK7EkeX1RgjloyfVHy2KRYO8xDh8aNg1a3z16 hev0TTVg32REvXTWFRguKPlcZ94emzk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-125-lm6Alc_UMluPBmmSuY7dPA-1; Wed, 08 Jul 2020 08:43:21 -0400 X-MC-Unique: lm6Alc_UMluPBmmSuY7dPA-1 Received: by mail-wm1-f70.google.com with SMTP id z11so2828464wmg.5 for ; Wed, 08 Jul 2020 05:43:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WV6M1edub7XkEemGRBxIe4WR8aj11TMDUW7v+GRjIBg=; b=VT9myqRizPP/5Qo2O5CXz6nd7RjFhnfVJKr5O00ONQbd4aoMJYFFywXMHUySiUscVW Zd49N8oSJrhM70YYmdnpsJE94wOnJRVA7bWg2AKpoZdkG6BaHuVRLqhwYK2h6nM9BpsJ IFBznygBOmweCy3eNFruEgU8Z67Td6UfoTznUQvRToVveYf/Ip+tw+CONypVT8+0vP+z hiOHv+TQfMROHBS5xgGJwPW0+n5SAMnl6dZX8EpJaho12xdJHZYZXhu5rRmX8umYku3G kxkJYEtRqhSpUQWJzliTyhhmGBmvbQqCXS5jpRa8Iq3FHiCIK0AGC3DhBQAimVYpBy37 ue4w== X-Gm-Message-State: AOAM532QJ69WRj+yNGQyDzgocYgnzvG0yMURgZzAIdPqQz8mj0OT83JA NgWKyd52Fm9I/hNIVKHhV4zH3QyE5CHDEdHSZsrknE/2rAcqxW6+NXKdJroU/tzYx/g0OjQ+Q8p CqoFk5dt35Q+yR9Hhx1hVQqsT X-Received: by 2002:a1c:7313:: with SMTP id d19mr8669915wmb.147.1594212200015; Wed, 08 Jul 2020 05:43:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkoQtC57N6nn9Fjhc1r7NZTTbvaPCCGsS00bdHLaY5V5WFB96pVfk+xMJs0avi9JF/QeP6gw== X-Received: by 2002:a1c:7313:: with SMTP id d19mr8669908wmb.147.1594212199839; Wed, 08 Jul 2020 05:43:19 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:9541:9439:cb0f:89c? ([2001:b07:6468:f312:9541:9439:cb0f:89c]) by smtp.gmail.com with ESMTPSA id 26sm5701946wmj.25.2020.07.08.05.43.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2020 05:43:19 -0700 (PDT) Subject: Re: [PATCH v3 3/8] KVM: X86: Introduce kvm_check_cpuid() To: Xiaoyao Li , Sean Christopherson , Jim Mattson Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel References: <20200708065054.19713-1-xiaoyao.li@intel.com> <20200708065054.19713-4-xiaoyao.li@intel.com> <3a085ea6-1f2b-904a-99a4-e10ed00e99a0@intel.com> From: Paolo Bonzini Message-ID: <9c691531-512a-41ef-883c-1831c75b8e8b@redhat.com> Date: Wed, 8 Jul 2020 14:43:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <3a085ea6-1f2b-904a-99a4-e10ed00e99a0@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/07/20 14:28, Xiaoyao Li wrote: >> @@ -202,12 +208,16 @@ int kvm_vcpu_ioctl_set_cpuid(struct kvm_vcpu *vcpu, >>           vcpu->arch.cpuid_entries[i].padding[2] = 0; >>       } >>       vcpu->arch.cpuid_nent = cpuid->nent; >> +    r = kvm_check_cpuid(vcpu); >> +    if (r) { >> +        vcpu->arch.cpuid_nent = 0; > > Paolo, > > here lack a kvfree(cpuid_entries); > Can you help fix it? > > Apologize for it. Actually I hadn't queued this patch; my mistake. You can fix it and resend. Paolo