mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "zhangjianhua (E)" <zhangjianhua18@huawei.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "ath9k-devel@qca.qualcomm.com" <ath9k-devel@qca.qualcomm.com>,
	"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Chenyi (Johnny)" <johnny.chenyi@huawei.com>
Subject: Re: [PATCH -next] drivers: net: CONFIG_ATH9K select LEDS_CLASS
Date: Tue, 30 Mar 2021 15:00:05 +0800	[thread overview]
Message-ID: <9c6989a1-614e-23af-dc90-58663aa7d9a1@huawei.com> (raw)
In-Reply-To: <20210327223811.GB2875@duo.ucw.cz>

hello Pavel,thanks for your reply.

for  the a point, I don't know the led lists and cannot find it.

for the b point, I look other configs who select LEDS_CLASS, almost all 
of them select NEW_LEDS,maybe you are right, CONFIG_ATH9K also need 
select NEW_LEDS too.


Best regards,

Zhang Jianhua

在 2021/3/28 6:38, Pavel Machek 写道:
> On Fri 2021-03-26 16:13:51, Zhang Jianhua wrote:
>> If CONFIG_ATH9K=y, the following errors will be seen while compiling
>> gpio.c
>>
>> drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_deinit_leds':
>> gpio.c:(.text+0x604): undefined reference to `led_classdev_unregister'
>> gpio.c:(.text+0x604): relocation truncated to fit: R_AARCH64_CALL26
>> against undefined symbol `led_classdev_unregister'
>> drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_init_leds':
>> gpio.c:(.text+0x708): undefined reference to `led_classdev_register_ext'
>> gpio.c:(.text+0x708): relocation truncated to fit: R_AARCH64_CALL26
>> against undefined symbol `led_classdev_register_ext'
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Zhang Jianhua <zhangjianhua18@huawei.com>
> a) please cc led lists with led issue.
>
> b) probably does not work as LED_CLASS depends on NEW_LEDS...?
>
> Best regards,
> 									Pavel
> 									

  reply	other threads:[~2021-03-30  7:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26  8:13 Zhang Jianhua
2021-03-27 22:38 ` Pavel Machek
2021-03-30  7:00   ` zhangjianhua (E) [this message]
2021-04-25 21:50     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c6989a1-614e-23af-dc90-58663aa7d9a1@huawei.com \
    --to=zhangjianhua18@huawei.com \
    --cc=ath9k-devel@qca.qualcomm.com \
    --cc=davem@davemloft.net \
    --cc=johnny.chenyi@huawei.com \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®