From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EBF837CD5D for ; Fri, 13 Mar 2026 12:51:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773406263; cv=none; b=L2z5/l2BR2NQ4Y88frkK0LOagHXh6gZVO3asfL7UofuCBDEL2bT3achEhx0nPy1mVTZQpPzTpFq57uLwM5s/WTcs7TRWAdfwdkTSO8Q1DUbMPjI8kO6Kzl8SPv/j6efVXgMFiG7/Q17Lc1C2d8Nqi/dulxlo/9X6zLLSUEgOvXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773406263; c=relaxed/simple; bh=J4wE2j1C0CwU+m4AqTI0TdWUyiuleTehv9zfq7Vqhik=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sTc+s95bws8u9LD6DYY5UL0EIIxpPaxwoUpZJaBBaqOd9dSqXSNzlNbMe8WyS33ocKgOH20tcjFbVCBw6/oMO0LWiQ+X2Ce8ebkbBomRGwVHzrS7kowHZFkxPAG9y0YaMwIxV4488yy55qA1yGtfNIRY7yyFwCs+JIAGRiSNsyQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=i/gLbCA+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QkKuNIPd; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="i/gLbCA+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QkKuNIPd" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62D7iLAj2262548 for ; Fri, 13 Mar 2026 12:51:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ct7QKCp/uLCcjZDRaN9aoF62KlQpTeXlak+8t4E5ZA8=; b=i/gLbCA++CKO2lzR jX4IbvFY0pApLF6DT8BPCKKW+EB3llBskjv+nQyrc2JsdhyuqHEAsQiBmV3WwMcH cHu6jvH0hCBhsniPP+U+mxgT8l5E/+tRhDzqjC+56osFonBovLRhWYK6NgC3IbHR alSR94mhHnFf9ZY7cBfZuGqrSSIhgVULch78ha1gbpR5emtSyZjDz3nAyHa1ONXx HiX/27x7RxXOgakJCq8nV5/zyfLsro3UcL5N0mcikauE68Y8r0NpYp6P+QHeNKQ/ P3iIn+nGHm+Tmt6sulVJ66oti1WixlOM1mAr0BIQlQ32w2flW71At2jB/VgvQBbP def2NA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvef4s1ha-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 12:51:01 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50906758d71so9066961cf.1 for ; Fri, 13 Mar 2026 05:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773406260; x=1774011060; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ct7QKCp/uLCcjZDRaN9aoF62KlQpTeXlak+8t4E5ZA8=; b=QkKuNIPdo1phwvMT1UAEBeCbVEzGmfYftbdjhk+g2ssg3jE36tF90y5PdZI6yhsLcQ x4hrDHz1OOneGEW2Xa1+d0QDlQYW8ocwaCCRYr+ttX73iSEUfz9234XcHSbKQL8EGW9R zm7YpQ9+BAl9eGHRfKncfzAivqVhqsB0QcZ+Z3kZ+4elYrJPujCs1eH6NTut7CLtLKzy NRgYovQ4sAHtZ07TbWBN3mYtFZLB41EXvBlVJIzB/E6EJLvQDIbXfrG4y4TiyEzMSe9z r21CY3zJSJIURiCQnIJW85NvrhB9tqLN+XBFhaIK+CG+O7pIyaghEI8wL1Sf6StjXsWD KUXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773406260; x=1774011060; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ct7QKCp/uLCcjZDRaN9aoF62KlQpTeXlak+8t4E5ZA8=; b=XauYXFmU7FIBQ0JmqK0h7ziJ+wT3g6H2PwOSx5I5a3TiihnxrTFgBwS4lYgSYGjByZ C1n1RU5K0hNBj0vItkV77yOGV44L2P/hi7FVNwwZL17jrsxNQYcDZNpV4hUHjGr2HJPB T6ZqoXGfJSbm45CmG2cWyq67pDZ7/gC5HR0PSnF7VvU52m8jlnmwtQePj736hpSX/lah dGXJVJfuhDP3/JqpWKoiF6kmDNwE92qGE02uNXfXFRJocrVpbyMSB2DOUHdLB9N6PkYA beiz/yiD24NYvPc/ySXUEPyc1XLE9r6KNVSWhz4UD1HlvpDiNBhXpSeTP12XzLgRREKX dh4g== X-Forwarded-Encrypted: i=1; AJvYcCVDNdtTTaVEW9EjQHA3qUCOTpvRdjf2DasgLpW7AdbL7tvHjyPziiy3Sm2Ds1vBOp0BROz5fT7j/wFEOfM=@vger.kernel.org X-Gm-Message-State: AOJu0YwZWk2fciVhYl2ls0YUXCXXkfF//bBm0aZhbrL9jQl2+jEBvXCf E7cW6WhCkpGh/JUTzruaAlIcAu25q8AUxDmVw+5b56MfX0sxt7h5rC2SPX8WWklOgTlgORdAbvU UgMOFfPGlfK8qkkVVskyYdPhW7xpwOjtRZx/NHWCHCy77WjKeI4U44L2xKuwdrJX8umw= X-Gm-Gg: ATEYQzwwCiaxAI/t6yiV+Uwf0x/fplLc1tb8BwLnB/NI9JBlud5GjvEwuf/ibJbwpGp zoP6GanL7sDeabFT911a6uL0ws3je7ssKnzD+HsH1Yj/l1tdDNKrRSMyciWPL0d3xHAw0bkWB09 QlJgBEwKZXNYN6JPjAa6jlMs2Ocq/gFM9+NqUto7atSpSx8W1I3M/mzENMZ2RsisghwUZtrObxO dqX6oqjpOCy8VyvsVXIatn0Lejz0iR4tnL7cjYeomVtjx7BQgjHfJfTb875M2nBCpet8/uGfpQA bllmR2864pUeGgTlfmkZWstkR8ks38UQqxEfNw/NGMpvw+iOE+ARmkGevlYIGT8+ZAl6IZ3jh45 rlOWv36vJMKiNAZGH1dtk4p3GAup+q7gIUM4rPojycQtKhZiaWFisNxNGITRKgQsObjrtQhcZCV qoe08= X-Received: by 2002:ac8:58c3:0:b0:509:2b5a:808 with SMTP id d75a77b69052e-50957ca0451mr33656781cf.2.1773406260502; Fri, 13 Mar 2026 05:51:00 -0700 (PDT) X-Received: by 2002:ac8:58c3:0:b0:509:2b5a:808 with SMTP id d75a77b69052e-50957ca0451mr33656551cf.2.1773406260086; Fri, 13 Mar 2026 05:51:00 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a156373888sm1487485e87.86.2026.03.13.05.50.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 05:50:58 -0700 (PDT) Message-ID: <9c6d140c-bcdb-4f9b-8419-aac35ea27584@oss.qualcomm.com> Date: Fri, 13 Mar 2026 13:50:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 02/10] usb: misc: qcom_eud: add sysfs attribute for port selection To: Greg Kroah-Hartman Cc: Elson Serrao , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Souradeep Chowdhury , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260309203337.803986-1-elson.serrao@oss.qualcomm.com> <20260309203337.803986-3-elson.serrao@oss.qualcomm.com> <2026031101-cornstalk-partner-a30e@gregkh> <6fe7a63c-a1b3-430b-a128-0e38754d6393@oss.qualcomm.com> <2026031327-sugar-disfigure-8034@gregkh> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <2026031327-sugar-disfigure-8034@gregkh> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: oqONIXi0E0FlPW65bvxg4A5PbkgjJqpf X-Proofpoint-GUID: oqONIXi0E0FlPW65bvxg4A5PbkgjJqpf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDEwMiBTYWx0ZWRfX4y57mV1e6njn x/XaaEWPehXeNPF/lvK2HBGwb8AQQIUFU4b4t5/VYZUZmC9StNT/Uoz171Duh1pJmzhKOpXpUoC wTSutpKjuqWNxzgs8bZJABln+/+IQhEkNBNox3R7Zc54W7ms9txtQd4TpLPHn77y0dg6sHXvhB0 QzY3jcrDXpikS3BwDp7kJXvIV9DmDe31O54Q9pZwtz3LN97RXeznC+uIEEgDzcGXIhm6qPZgtWW Z/eFHRHxePlB/JO9gUs146pn6xSqYq02iWrvOx0FrNNUVpHTTAoBFCHpO1cgucqHj5GHsFURS1t s0lfDhL3YAIs/jpJ56hjMSSaKklHBOyKxBnSiHMUjUtLFFQLtuQWn7DSPSLvHG5eyHVMm668XUP Cpzg0EhaP95Y5+4PZWjy+KhfqlG7hkZc6SPyFuES0OXF1wuKdsIDrF3Mh2rXY7tRErwbqkVKb6o KnftrTDl/9w9Mrd0dHg== X-Authority-Analysis: v=2.4 cv=S9nUAYsP c=1 sm=1 tr=0 ts=69b40835 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=XanBRYeQAFQoPGH1A-sA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_02,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130102 On 3/13/26 1:45 PM, Greg Kroah-Hartman wrote: > On Fri, Mar 13, 2026 at 01:10:10PM +0100, Konrad Dybcio wrote: >> On 3/11/26 2:16 PM, Greg Kroah-Hartman wrote: >>> On Mon, Mar 09, 2026 at 01:33:29PM -0700, Elson Serrao wrote: >>>> EUD can be mapped to either the primary USB port or the secondary USB port >>>> depending on the value of the EUD_PORT_SEL register. Add a 'port' sysfs >>>> attribute to allow userspace to select which port EUD should operate on >>>> and update the ABI documentation. This is needed for systems with dual >>>> USB ports where EUD needs to be accessible on either port depending on the >>>> system configuration and use case. >>>> >>>> Signed-off-by: Elson Serrao >>>> --- >>>> Documentation/ABI/testing/sysfs-driver-eud | 16 ++++++++ >>>> drivers/usb/misc/qcom_eud.c | 43 ++++++++++++++++++++++ >>>> 2 files changed, 59 insertions(+) >>>> >>>> diff --git a/Documentation/ABI/testing/sysfs-driver-eud b/Documentation/ABI/testing/sysfs-driver-eud >>>> index 2bab0db2d2f0..67223f73ee60 100644 >>>> --- a/Documentation/ABI/testing/sysfs-driver-eud >>>> +++ b/Documentation/ABI/testing/sysfs-driver-eud >>>> @@ -7,3 +7,19 @@ Description: >>>> EUD based on a 1 or a 0 value. By enabling EUD, >>>> the user is able to activate the mini-usb hub of >>>> EUD for debug and trace capabilities. >>>> + >>>> +What: /sys/bus/platform/drivers/qcom_eud/.../port >>>> +Date: January 2026 >>>> +Contact: Elson Serrao >>>> +Description: >>>> + Selects which USB port the Embedded USB Debugger (EUD) >>>> + is mapped to on platforms providing multiple High-Speed >>>> + USB ports. >>>> + >>>> + Valid values: >>>> + 0 - Primary USB port >>>> + 1 - Secondary USB port >>> >>> Why not use "primary" and "secondary" as values instead? That makes >>> this much simpler to understand. >> >> It's not inconceivable that future iterations of this hardware will let >> one mux between more than two USB PHYs/ports (there are already a multitude >> of SoCs where we have 4 or more USB controllers and >= that ports) > > Great, and how will that be defined? As a number? Name? Something > else? Perhaps it makes more sense to me, since if I look at the other computer, the controllers are named USB0, USB1 and so on.. We follow this naming in DT too, so it felt natural How they end up mapping to physical connectors is of course up to the implementer. Ultimately, I don't mind either Konrad