From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: codecs: wsa883x: add control, dapm widgets and map
Date: Wed, 29 Jun 2022 17:10:35 +0100 [thread overview]
Message-ID: <9c71f751-2f5e-4d1f-5f94-942cf7ad6a8a@linaro.org> (raw)
In-Reply-To: <YrxpgF2B5W7fyYVy@sirena.org.uk>
On 29/06/2022 16:02, Mark Brown wrote:
> On Wed, Jun 29, 2022 at 03:58:31PM +0100, Srinivas Kandagatla wrote:
>
>> +static const char * const wsa_dev_mode_text[] = {
>> + "speaker", "receiver", "ultrasound"
>
> Idiomatically these would be capitalised ("Speaker" and so on). Sorry,
> didn't notice on v1. Otherwise this looks good.
Make sense, Will send v3.
--srini
prev parent reply other threads:[~2022-06-29 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 14:58 Srinivas Kandagatla
2022-06-29 15:02 ` Mark Brown
2022-06-29 16:10 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c71f751-2f5e-4d1f-5f94-942cf7ad6a8a@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®