mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Sasha Levin <sashal@kernel.org>,
	Andy Whitcroft <apw@canonical.com>,
	 Andrew Morton <akpm@linux-foundation.org>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>,
	Lukas Bulwahn	 <lukas.bulwahn@gmail.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v2] checkpatch: add support for Assisted-by tag
Date: Thu, 12 Mar 2026 13:59:04 -0700	[thread overview]
Message-ID: <9c72e4b081931e0656caa54c577cecd5ac1f7304.camel@perches.com> (raw)
In-Reply-To: <20260311215818.518930-1-sashal@kernel.org>

On Wed, 2026-03-11 at 17:58 -0400, Sasha Levin wrote:
> The Assisted-by tag was introduced in
> Documentation/process/coding-assistants.rst for attributing AI tool
> contributions to kernel patches. However, checkpatch.pl did not
> recognize this tag, causing two issues:
> 
>   WARNING: Non-standard signature: Assisted-by:
>   ERROR: Unrecognized email address: 'AGENT_NAME:MODEL_VERSION'

Acked-by: Joe Perches <joe@perches.com>

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -641,6 +641,7 @@ our $signature_tags = qr{(?xi:
>  	Reviewed-by:|
>  	Reported-by:|
>  	Suggested-by:|
> +	Assisted-by:|
>  	To:|
>  	Cc:
>  )};
> @@ -3105,6 +3106,15 @@ sub process {
>  				}
>  			}
>  
> +			# Assisted-by uses AGENT_NAME:MODEL_VERSION format, not email
> +			if ($sign_off =~ /^Assisted-by:/i) {
> +				if ($email !~ /^\S+:\S+/) {
> +					WARN("BAD_SIGN_OFF",
> +					     "Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format\n" . $herecurr);
> +				}
> +				next;
> +			}
> +
>  			my ($email_name, $name_comment, $email_address, $comment) = parse_email($email);
>  			my $suggested_email = format_email(($email_name, $name_comment, $email_address, $comment));
>  			if ($suggested_email eq "") {
> 

      reply	other threads:[~2026-03-12 20:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-14  1:07 [PATCH] README: add AI Coding Assistants section Sasha Levin
2025-12-22 22:04 ` Jonathan Corbet
2025-12-23 12:21   ` [PATCH v2] docs: add AI Coding Assistants documentation Sasha Levin
2025-12-23 15:25     ` Jonathan Corbet
2026-01-06 21:56       ` Jonathan Corbet
2026-03-10 16:32     ` Bart Van Assche
2026-03-11 15:20       ` [PATCH] checkpatch: add support for Assisted-by tag Sasha Levin
2026-03-11 15:33         ` Joe Perches
2026-03-11 16:15           ` Sasha Levin
2026-03-11 21:58           ` [PATCH v2] " Sasha Levin
2026-03-12 20:59             ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c72e4b081931e0656caa54c577cecd5ac1f7304.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=bvanassche@acm.org \
    --cc=corbet@lwn.net \
    --cc=dwaipayanray1@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=sashal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®