From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 482C8C4332F for ; Wed, 16 Nov 2022 12:00:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232842AbiKPMAa (ORCPT ); Wed, 16 Nov 2022 07:00:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231501AbiKPMAE (ORCPT ); Wed, 16 Nov 2022 07:00:04 -0500 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 201AB51C33 for ; Wed, 16 Nov 2022 03:52:09 -0800 (PST) Received: by mail-lj1-x235.google.com with SMTP id b9so21517308ljr.5 for ; Wed, 16 Nov 2022 03:52:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9l4mQv9bpo9LzKh5UykNs3/PvBpNgjAZ8H6ymHxaNGo=; b=qJGuaKdHbo2gV1Gg1Uu5x7IHAm1tLva5UrbbDI5QDEjpDJYvJHijTlpFVbK1gEkx/Y DEFQ6wW6A+vms0D3V1CU3c7sF10nXfSNZU25BKvbRbZSU8fOnBGu7gutvlqYG5S0qWdU iPoNYwJ7rtkPoLsB5NCV9BbJcoZAbRxt39pTOC0hNjktdM2edzn/JXrpiK7nsBcLqNnL T7Ci7ZLV3l48QSTP1/24oWiGROfwbh+8Mp2JPDUYHvalzjVRFDqmR0o44EmCeT/qStE8 q2+6An13wpGskmpS3lsmuKE2IodXou4oQRCI0OtUEEoFw27OrdIdbardCIU7ne6Ii0zo OUZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9l4mQv9bpo9LzKh5UykNs3/PvBpNgjAZ8H6ymHxaNGo=; b=3k2r4OMB5rqqTIvrkOTm2jYqg7fls+aPbcCkuYMIdVhlNkUZWqBeQ5noHO66Les2Mi sqYdc4rlArWpPT/8Gz47reuJwfUUKT52bw545ob7bTO4BimU1ddt094PGEWZpj6OGio9 ZWIXc2rGTZF1d/eYr6GBiS9OgTjA4+yKMyuGQSQPRH94sCw8QUaGf7j4R2nQ7OqUthdO wiCiHbJf0KxscEQuDQ8NVvz2cRSv4ZE+VvLrdyhi0t14q2fwIH14kIuSThJEt69ZmzKL kuYek1X0gls6+2PVqYy+ghB4afA1v5l1DFvBSfMUIGEkdfAb0QGtib38cEzVOd7Z902O yX8g== X-Gm-Message-State: ANoB5pnhwIs4KAY/I5zM/DIJ3n6tBtSK0i4jmPdJiSKi8cJ0JaZw17n3 T86sSNwqyzDdZTZAfl7zUNtZQA== X-Google-Smtp-Source: AA0mqf40ymbSD4mZc17qz9uvVeqDU4zca4rDxD4azyNRwWW2p6AjRfYwkg5vNSqxHP173tFCRMK7Og== X-Received: by 2002:a05:651c:14d:b0:277:6c39:e543 with SMTP id c13-20020a05651c014d00b002776c39e543mr8173866ljd.513.1668599527466; Wed, 16 Nov 2022 03:52:07 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id o9-20020ac25e29000000b004b3b2a9f506sm2542947lfg.4.2022.11.16.03.52.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Nov 2022 03:52:07 -0800 (PST) Message-ID: <9c787dcf-f294-a93e-b357-2c04177b15ba@linaro.org> Date: Wed, 16 Nov 2022 12:52:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 2/4] dt-bindings: qcom-qce: document clocks and clock-names as optional Content-Language: en-US To: Neil Armstrong , Vinod Koul , Andy Gross , "David S. Miller" , Bjorn Andersson , Thara Gopinath , Rob Herring , Krzysztof Kozlowski , Herbert Xu , Bhupesh Sharma , Konrad Dybcio Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Abel Vesa , linux-arm-msm@vger.kernel.org References: <20221114-narmstrong-sm8550-upstream-qce-v1-0-31b489d5690a@linaro.org> <20221114-narmstrong-sm8550-upstream-qce-v1-2-31b489d5690a@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20221114-narmstrong-sm8550-upstream-qce-v1-2-31b489d5690a@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/11/2022 11:23, Neil Armstrong wrote: > On certain Snapdragon processors, the crypto engine clocks are enabled by If by "enabled" you mean "controlled", then looks fine. Otherwise without exclusive control by firmware, clock enabled e.g. by firmware or bootloader might still be disabled by SoC. Which case is here? Probably we should have dedicated compatibles for that. Best regards, Krzysztof