From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 309FB304BB3 for ; Thu, 26 Mar 2026 10:45:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774521944; cv=none; b=teQMO12W9fa43qJRrqjJ1FQ4EBh4fTmHBv3IoPCs1Q5E9vQv2Qw1aXPc1DNqgeIDWCORrgc/ZnNJw6saXRTkk6EQG76tUddXGTZmdCabk8ERlvpBeId/cJwNCNbwJHs/zqd2pkcKHHmnXI1VgJyTCXozDhOqz9EJCx0H2ejZkIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774521944; c=relaxed/simple; bh=KuE5wMXOF5HDbAynVpU3oy802Br8p58lz9x7bevUe5A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Wv4APHP2DrWxy0k7JIg/WlsFxxrqvBtLRUXeJ0UKbkXgNQu31Pqh6lsnx1SOCQnG+mLYKUDsw9Sucwx4CCX5gf8lmrTzfYMaS9DHF3m6r8YqqljY1KFeh+sTvkTRptV4dTcZhiBjXvIQvpQ5O4yv9UKUOYI+ckqqReyHVFidKFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DFM9xEKA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=U+1VSlyL; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DFM9xEKA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="U+1VSlyL" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62Q9UgRs3768843 for ; Thu, 26 Mar 2026 10:45:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wr11UVgqGoxu05TLkOfnjgR77V8kxzjaqIhhpa+9RfI=; b=DFM9xEKApWvq8G7d Phgz+UslHMg27+So/3F2w88xVAP//Sh81Bj/6kjF4mW+HhAkRnTG4gvhtsHestsH kHR6HlVA57FToqI9/IXk74tRAeKkzf4L2qg6JV+oH31fk44pve8Eng6y62S41arP Pf82j0BSgGm/UHwp4YPXuHicR3nPYZ8zYEukLNY6RJQb5siMSC6U+81t+o59x+Yp qqz0gk7wyN1PJFrN5Qfof+4Bv4w0w0wFJXSbSAwTOMlPC7GDC/ZLB7vtorbC1k1u 484ZJ+QQqyy1ojvmJfecUS6IwbJpvVIBrPXd5pnMfIBp6rntTnrOOFwCGK9etxm+ zfuNng== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d527yr87y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Mar 2026 10:45:42 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50b2955cc1eso2326961cf.2 for ; Thu, 26 Mar 2026 03:45:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774521941; x=1775126741; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wr11UVgqGoxu05TLkOfnjgR77V8kxzjaqIhhpa+9RfI=; b=U+1VSlyLp3zAkO7gD71k5G5rZv8qdwSRgMrRKF1HGUL4Yg7QnDnTsMo7ZTUmxBzrpy Qfa8ybSfw3DgrJVjIFEMEi6eObjVYL/P2s5NMBd3CYAdLvrb2h9/4Jiy2r6aBDrZH7X6 m14FHEucthxApvUIAg5HJLOr/wFUJKNqBbivtuduFNQxxuipr+ZUN9OPqxAvtXLQBD0p p4f/qE5HWmdzzZzZtSdYrzrEMzXlI0dRhrfD5DtMqAfa7/fai8QJyiTOvNt9wgAddsVi NSxWoTUZnQdJ2Vivq7Xdo2ANJe2u84RVjSu3QhIMOvp+9Mrl4JDJUxdczYmzqpdGYzDT xlXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774521941; x=1775126741; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wr11UVgqGoxu05TLkOfnjgR77V8kxzjaqIhhpa+9RfI=; b=P5OX2T0bPBEIoOO/gr5x63ip7uHLDvi7ND5sOjXVhu6q3Z22wobtgCX90kPaDjcZTO CnJm+ulOiUCcrSKA0+G+4vcePXebbMcLTW7I4Ut6sfSk11opqVlqL44CXrK7PYMaNypO pS+2AHApzsR4pCETRUFflYZbQizOmYzZpnIfk4nchhNsSX0VUlRclUIKWKdghT9Eo9Uu zORZphUlZJ+9sQRgkBW9yZ3QYmK/LaYxg8x5JpP7/zcO23swmFVONYBILfHhX7z1Bf2a n4nCsQCt1qJamq9FW5S8Lz7HBfAhYWLD0IuaVBOd0t69OznMxbWuO3E506vme2eoeEP6 qQOw== X-Forwarded-Encrypted: i=1; AJvYcCXXgVpo5OweXREpYEv49R0z5rMEofJa1FEfbeuAkSZr83juxkHjPiFGqzvAktKwBjZTeBGAGGO17yF/o0Q=@vger.kernel.org X-Gm-Message-State: AOJu0YyLrjQkWZQXa9NneLlFqIzyQN8+Xr2eBtvT7zceMHVbsh+7fSzw HV1QVCtkRTEOk9VFZQNW5i286sr5jXfX+yX4kwZQJ1yykFK053HF9Xf1xUJYdaIT/wwQIXlBh9K rqAMl7py2hWu7E33Z97Cke1blAgEzOZHtUaG9ALm0rIhDbgRv1mIZKHat1m4OcP5uesgFiDaqh0 k= X-Gm-Gg: ATEYQzyB6pYKUHOzfJnGlgrICwNcydH725sXVo4eVmQc8c+IjfwvW57gCLJh/pUWKU2 zl2Ezt7SF0MZC0obRvXdIVqhq3KDbdh6yoMwKBHCQmXDTpjxGy+WZKRfKIoh4Mn+3udfJKIZxbX G7+cjxR+nM1Bnpqi6uKQrGgfYvgAJ1MC0tN0qH0bCNGgzODJ6iYDQf1so4hxFKZ/wG/kUXqHszJ 82bhxYH5iQoBTouCNorcUmzvz6G09awPToKbAyy/9UlXvgWhZYVYZZwDKaTI9PEyR94QdIIsgef Ui1aAw+5wCbCryY9qE/tEliDGa/JfpvHwQJRWjuOAiOGAFpLdS9nPZSEOdoenraDtvjMk72wKbJ 14hWYDnTsHaXwJwcwX0srbWyRtYHxvpODUxZakXSq4xxwnY0/3NPxa68Ghz8B+oXU8baPKVG9/d re6rU= X-Received: by 2002:ac8:7d0a:0:b0:509:47e2:9df3 with SMTP id d75a77b69052e-50b80cf75f5mr70961171cf.1.1774521941414; Thu, 26 Mar 2026 03:45:41 -0700 (PDT) X-Received: by 2002:ac8:7d0a:0:b0:509:47e2:9df3 with SMTP id d75a77b69052e-50b80cf75f5mr70961001cf.1.1774521940881; Thu, 26 Mar 2026 03:45:40 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b20265120sm102392966b.16.2026.03.26.03.45.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 03:45:39 -0700 (PDT) Message-ID: <9c7b16f8-047a-4cec-b34a-28b94040f9d9@oss.qualcomm.com> Date: Thu, 26 Mar 2026 11:45:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] arm64: dts: qcom: Add the Lenovo IdeaCentre Mini X To: Bjorn Andersson , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260325-ideacentre-v1-0-768b66aaef30@oss.qualcomm.com> <20260325-ideacentre-v1-2-768b66aaef30@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260325-ideacentre-v1-2-768b66aaef30@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=dLurWeZb c=1 sm=1 tr=0 ts=69c50e56 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=oh5tWtvl8tmv48WKmsIA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: rAGQUaO965xnTAhcvbHSnm2vxAFRUB_X X-Proofpoint-GUID: rAGQUaO965xnTAhcvbHSnm2vxAFRUB_X X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI2MDA3NCBTYWx0ZWRfXwgZP+Rk0Y5dz QRYr+54UaoDPoYQTGkpbAWuWGtOIWEPR2bkN6psggrxWL8JIZ7ZTQpdYEjMBnKIaRJrYAltA82n YZ2befGr6hSs1cmDv1W8+E9VXsJe/AXSW2tQ2EgDs5hOfCtIJn/mjmMahdutLsqDr+KrE/XDiF4 oF+uiGM1h4/rmvAJS0CjlZOaGEUrJR+A9zvS/uH8Ra7hMP3o/2ijHY78zWYsxGJmtY9NDphBpJo 96jsfCyegZcsGWJd2iDZCqPKn8vwjmNP25iikPwixiibxJ81Gn7Y3vdFUDjpZufOo8OmVNOMRVk VEK5ZG/hRBI0fBfr+yNfySErrVj1zXeEVRge2wbSVugmp630bsyoCMwJXjoCyMZaktxkUlfgVJs QGNV3NUgTh911sv8ruM52TSxzS8uMLHzfoL8vb5aCsHibRX5ZUOCj0CCzYx1iXk0Yn0UkQRmIjq 9bR0nblWpS2CMFszlBg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_02,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 phishscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603260074 On 3/25/26 11:34 PM, Bjorn Andersson wrote: > The Lenovo IdeaCentre Mini X (Snapdragon) Desktop is a Hamoa-based > ultracompact desktop PC. It provides HDMI, DisplayPort, USB Type-C > display outputs, 5 additional USB ports, Ethernet, dual NVME slots, > headphone jack, WiFi, and Bluetooth. > > Introduce a DeviceTree describing this device. > > Signed-off-by: Bjorn Andersson > --- [...] > +&iris { > + firmware-name = "qcom/x1e80100/LENOVO/91B6/qcvss8380.mbn"; > + status = "okay"; nit: \n before status, please [...] > +&usb_1_ss1_qmpphy { > + vdda-phy-supply = <&vreg_l2j>; > + vdda-pll-supply = <&vreg_l2d>; > + > + /delete-property/ mode-switch; > + /delete-property/ orientation-switch; > + > + status = "okay"; > + > + ports { > + port@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /delete-node/ endpoint; > + > + /* XXX: why @0? */ Because the binding defined it that way Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml -> ports: port@0: endpoint@0: Display Port Output lanes of the PHY when used with static mapping [...] > + usb_1_ss1_qmpphy_out_dp: endpoint@0 { > + reg = <0>; > + > + data-lanes = <3 2 1 0>; > + remote-endpoint = <&dp_port_in>; > + }; > + }; > + }; > +}; > + > +&usb_1_ss2_qmpphy { > + vdda-phy-supply = <&vreg_l2j>; > + vdda-pll-supply = <&vreg_l2d>; > + > + /delete-property/ mode-switch; > + /delete-property/ orientation-switch; > + > + status = "okay"; > + > + ports { > + port@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /delete-node/ endpoint; > + > + /* XXX: why @0? */ Same here other than that, please fix up the odd misordered pinctrl-n/pinctrl-names and feel free to add my: Reviewed-by: Konrad Dybcio Konrad