mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Qinxin Xia <xiaqinxin@huawei.com>
To: Sasha Levin <sashal@kernel.org>, Barry Song <baohua@kernel.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Cc: <stable@vger.kernel.org>, <iommu@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tools/dma: fix building with O=
Date: Tue, 13 Oct 2026 10:09:25 +0800	[thread overview]
Message-ID: <9c81fb51-ba0d-4b4a-b08b-7bdfaf3b51ff@huawei.com> (raw)
In-Reply-To: <20261011223358.2327625-3-sashal@kernel.org>



On 2026/10/12 06:33:31, Sasha Levin <sashal@kernel.org> wrote:
> With O= set, "all" depends on $(OUTPUT)dma_map_benchmark, but the only
> rule builds dma_map_benchmark in the source directory, and built-in
> rules are disabled:
> 
>    make: *** No rule to make target '<O>/dma_map_benchmark', needed by 'all'.  Stop.
> 
> Build $(OUTPUT)dma_map_benchmark.
> 
> Fixes: f74ee32963f1b ("tools/dma: move dma_map_benchmark from selftests to tools/dma")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>   tools/dma/Makefile | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/dma/Makefile b/tools/dma/Makefile
> index e4abf37bf020c..0c239a6b9eae5 100644
> --- a/tools/dma/Makefile
> +++ b/tools/dma/Makefile
> @@ -38,8 +38,8 @@ prepare: $(OUTPUT)include/linux/map_benchmark.h
>   FORCE:
>   
>   DMA_MAP_BENCHMARK = dma_map_benchmark
> -$(DMA_MAP_BENCHMARK): prepare FORCE
> -	$(CC) $(CFLAGS) $(DMA_MAP_BENCHMARK).c -o $(DMA_MAP_BENCHMARK)
> +$(OUTPUT)$(DMA_MAP_BENCHMARK): prepare FORCE
> +	$(CC) $(CFLAGS) $(DMA_MAP_BENCHMARK).c -o $@
>   
>   clean:
>   	rm -f $(ALL_PROGRAMS)

Acked-by: Qinxin Xia <xiaqinxin@huawei.com>
-- 
Thanks,
Qinxin


  reply	other threads:[~2026-10-13  2:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20261011223409eucas1p2100147e14b9393639235b1858cd48e20@eucas1p2.samsung.com>
2026-10-11 22:33 ` Sasha Levin
2026-10-13  2:09   ` Qinxin Xia [this message]
2026-10-13 11:42   ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c81fb51-ba0d-4b4a-b08b-7bdfaf3b51ff@huawei.com \
    --to=xiaqinxin@huawei.com \
    --cc=baohua@kernel.org \
    --cc=iommu@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®