From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
Alexandre Mergnat <amergnat@baylibre.com>,
CK Hu <ck.hu@mediatek.com>,
"Jason-JH.Lin" <jason-jh.lin@mediatek.com>
Cc: dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/mediatek: Fix child node refcount handling in early exit
Date: Mon, 28 Oct 2024 10:09:43 +0100 [thread overview]
Message-ID: <9c83ea27-1221-4920-920e-9e7876ceaf90@collabora.com> (raw)
In-Reply-To: <20241011-mtk_drm_drv_memleak-v1-1-2b40c74c8d75@gmail.com>
Il 11/10/24 21:21, Javier Carrasco ha scritto:
> Early exits (goto, break, return) from for_each_child_of_node() required
> an explicit call to of_node_put(), which was not introduced with the
> break if cnt == MAX_CRTC.
>
> Add the missing of_node_put() before the break.
>
> Cc: stable@vger.kernel.org
> Fixes: d761b9450e31 ("drm/mediatek: Add cnt checking for coverity issue")
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2024-10-28 9:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 19:21 [PATCH 0/2] drm/mediatek: Fix child node refcount handling and use scoped macro Javier Carrasco
2024-10-11 19:21 ` [PATCH 1/2] drm/mediatek: Fix child node refcount handling in early exit Javier Carrasco
2024-10-23 2:49 ` CK Hu (胡俊光)
2024-10-28 7:00 ` Chen-Yu Tsai
2024-10-28 9:09 ` AngeloGioacchino Del Regno [this message]
2024-10-11 19:21 ` [PATCH 2/2] drm/mediatek: Switch to for_each_child_of_node_scoped() Javier Carrasco
2024-10-23 2:50 ` CK Hu (胡俊光)
2024-10-28 7:00 ` Chen-Yu Tsai
2024-10-28 9:09 ` AngeloGioacchino Del Regno
2024-11-04 12:39 ` [PATCH 0/2] drm/mediatek: Fix child node refcount handling and use scoped macro Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c83ea27-1221-4920-920e-9e7876ceaf90@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=airlied@gmail.com \
--cc=amergnat@baylibre.com \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason-jh.lin@mediatek.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®