Re: [PATCH v10 9/9] riscv: select HAVE_CMPXCHG_LOCAL

[bot+bpf-ci@kernel.org]

[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]

> riscv: select HAVE_CMPXCHG_LOCAL

TL;DR: Nit only, no runtime problem: selecting HAVE_CMPXCHG_LOCAL on riscv may
need the cmpxchg-local arch-support.txt feature table updated from TODO to ok
in the same patch.

> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -155,6 +155,7 @@ config RISCV
>  	select HAVE_ARCH_VMAP_STACK if MMU && 64BIT
>  	select HAVE_ASM_MODVERSIONS
>  	select HAVE_BUILDTIME_MCOUNT_SORT
> +	select HAVE_CMPXCHG_LOCAL
>  	select HAVE_CONTEXT_TRACKING_USER

This isn't a runtime problem, but should the feature table be updated in
this patch as well?

Documentation/features/locking/cmpxchg-local/arch-support.txt is keyed on
this Kconfig symbol and still lists riscv as TODO:

    |       riscv: | TODO |

Nothing later in the series changes it.  Other riscv patches that select a
feature symbol update the matching arch-support.txt in the same commit, for
example d1f014012571 ("riscv: enable HAVE_IOREMAP_PROT").  LoongArch
selected the same symbol without updating the table, and it needed a
follow-up in 0c4c9abbf68b ("Documentation/features: Mark cmpxchg-local as
supported on loongarch").  Would changing the riscv row to "ok" here keep
the table accurate?


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/43205409812