From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3006A363C73 for ; Tue, 13 Jan 2026 05:53:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768283606; cv=none; b=Q2zhon+lLms7QrnbYmx1TTS+iKAAUmAnY/qOIH9G/sY66HUWYzwi9kdmjglN8C6JuDUhqkM+gWR9Yoc4z+SuZsGsy3CMEFTyrHV95Y797FaHJ5QiS2/xuEOQHth6N525woQDI1eVbiCluFEGNySrYAQUF0950sECIFd+FmjY0Cc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768283606; c=relaxed/simple; bh=19vdQo6pYfLOqyUW2a2rZf9ayU9mlx5fbadNgHNsOsU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cgaoCq735cJTlSmDocJBs6vZg6s91xoayejziepboPzAVkYXCp3gGVCRO3FKDiZIcCWsvdUk7mEwWxBkG7XTr3ZABzTULhcIjTJR1o9UKn+52xtBK3zi2BOkCAOFuXXF+gw+NUCb+CQ09LpFXAuUbRBydanVXZcFzlGuZAs2+mc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CUhY7zAC; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CUhY7zAC" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-432d256c2e6so3646198f8f.3 for ; Mon, 12 Jan 2026 21:53:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768283601; x=1768888401; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=88pm3P6g81XtGnprrTXJfTCXXLwIxJufnowFgUK1NPI=; b=CUhY7zACyQqSbtyWkASj38wKtk3Qx+ufSfDyWRcAFPP2aoXqPpf7mPmDlv3/ym436L CPEGfO7jpYDy/IXrLBWiQkXujXCK6jlKBzHQu1Bd1/Plvq+RLTWwHU5McINusb9vkn1d PLTBDM747TQKhWS8Q95+HLxaJoY1yBf2I7gfRQiUQsf8kGbJoFvdF1bQbsn4tT8UL/mU BsWt50uqTYWGmuWmDoIrAXjeMQv1V/DLn4dLe+ft6x9zT/2AGO+pGLcvjcNVgaihGzGd fU+/lZbrYsb92JBBf9KywTexTU4CbO91CmMmSY3Re0SFWPA/Z9yYTza5wnW4auYK8/vM cZrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768283601; x=1768888401; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=88pm3P6g81XtGnprrTXJfTCXXLwIxJufnowFgUK1NPI=; b=EFK6oK/86iwjW8owOV9aCNW0rHjf3d8j/fVAI02SMhRng1qSxaNtwXdI1oL7aOaJ0o Ea7VRF67Rw9ST4Wm4Ld6rnPfAKQNhRXhcDUTBIPsHjQ6Tlon5As0wBxus6kllfqeB3gy PK83OLySMIqeOJXgFl+ZhplqqxZIuCvmZKDehfUP3tZnk18rNIxltrPY3TvKIVyCNPcI n37Vs4oKdR24GXZEW0PWEcSoIXv0tKQrOPnMUjb1O4Qa3C3JZKJwEMGNuopo4E5ei7Ob CZdzahV3LYXAowH7O5W825NkG4jhl0eMBs3yeYiGsGkH0WChBTtrz9G1cvwe42723Nkv 3TZA== X-Forwarded-Encrypted: i=1; AJvYcCVsOSxC2j2+MvHBG21nck8s9HVweambbO9MliVDEUlna3+AkhnFUBA4mTybX/9Sej1/xB8u5OD2HkJIPRM=@vger.kernel.org X-Gm-Message-State: AOJu0YyRxtSjwDe0h74NHtMmTwDuz2nerpb/P+/rHIVGySM3tHkUKXJQ U5581PgYHXI5PIHvkAQ5UC2kvvVhwYXX67Gi73d/ecosr5KS7odm9Abg X-Gm-Gg: AY/fxX7L1IkRYAsaCXisgkCyv5qXT02QhS51UdQfWimkBPBqKonVf8+Z5yVW7PxrnL6 mp6mum7Z7zWbX93+vWfxUsfm7U0Qw1A41rzM/LiazdxO9WP6TqCmJ/db9Rk2+cXasRlP7mp2QGT +TZpa3pEa05bm/C8bDaLcb6tVCM7KZIFNvhBoeo4nt0MY97hq6I2uroWqKIXivL4rsuoNIpbIGk PcHUuYiQCrAxo6/xGup+yJ3sSp+/AMrmhOvuVclpO8sd05ctFgyopk/TC8ZvT2HzeRfJisMAWxh mvgekrmegejwU5xKxehIGIHL0lUTDj9zT184uEu25PLxdEetSA/zdZoqLBqldnSVpfrXHYF+CRR lzsGDqK9wyPcfvB6tTz5d2/8yfUbfge8zoSoB9zb8YP73GgtZ4UEbNKt1LiC7CGJTIVTz+Zh9/b oDCzUqU+UBJnP53tv/a9lewCQg4Wu5IqBmL9y/3MB95D2qnA== X-Google-Smtp-Source: AGHT+IF68TWf4Pq2Z9GvExTY2L9ytnAtr4ik5TJl9gx8maZgQ9A4SM9KuPGxVZgVMoqKVWvHWhCqpQ== X-Received: by 2002:a05:6000:4387:b0:42c:b8fd:21b3 with SMTP id ffacd0b85a97d-432c37a756bmr26203367f8f.57.1768283601377; Mon, 12 Jan 2026 21:53:21 -0800 (PST) Received: from [10.221.200.118] ([165.85.126.46]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432dfa6dc4esm20377651f8f.23.2026.01.12.21.53.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jan 2026 21:53:21 -0800 (PST) Message-ID: <9c8a5d43-2c1e-4a3b-8708-c92a11ad56ff@gmail.com> Date: Tue, 13 Jan 2026 07:53:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/mlx5: Fix return type mismatch in mlx5_esw_vport_vhca_id() To: Zeng Chi , saeedm@nvidia.com, leon@kernel.org, tariqt@nvidia.com, mbloch@nvidia.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, zengchi@kylinos.cn References: <20260109090650.1734268-1-zeng_chi911@163.com> Content-Language: en-US From: Tariq Toukan In-Reply-To: <20260109090650.1734268-1-zeng_chi911@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/01/2026 11:06, Zeng Chi wrote: > From: Zeng Chi > Thanks for your patch. Please specify target branch. > The function mlx5_esw_vport_vhca_id() is declared to return bool, > but returns -EOPNOTSUPP (-45), which is an int error code. This > causes a signedness bug as reported by smatch. > > This patch fixes this smatch report: > drivers/net/ethernet/mellanox/mlx5/core/eswitch.h:981 mlx5_esw_vport_vhca_id() > warn: signedness bug returning '(-45)' > Missing Fixes tag. > Signed-off-by: Zeng Chi > --- > drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h > index ad1073f7b79f..e7fe43799b23 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h > +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h > @@ -1009,7 +1009,7 @@ mlx5_esw_host_functions_enabled(const struct mlx5_core_dev *dev) > static inline bool > mlx5_esw_vport_vhca_id(struct mlx5_eswitch *esw, u16 vportn, u16 *vhca_id) > { > - return -EOPNOTSUPP; > + return false; > } > > #endif /* CONFIG_MLX5_ESWITCH */ Regards, Tariq