From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 682B03B3890 for ; Tue, 24 Mar 2026 10:34:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774348444; cv=none; b=UohetP7h0KdteCVSozzEMD9WVBAbWIZzsSvSLhgfHuGrvnG851K/7vTOzlV5IykHBkYPjJCkcnrwgmSUWm7jmpb3UY1SrB4LZPIH0eRNn9kjdOFsMLi797/etqe72/DSmCs4oKwqBZYXvLBti5FvCkOGNpQcCO46SL8VqyadpKk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774348444; c=relaxed/simple; bh=0XW7qq/cYCeR9OCvHLhwCJaTaNC5jevWMmJPP9v5ty8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=T2il3RCdTYd9mBYLW2pCjFf7YREYQf7dbXOhCdiFpQO5/FIDm90h9f+uRSfXuNKSVE2SUD4XChOME4ENKz8Auzs8N0fGAvDwLZb6iy2bSQwPCMCiOgwO7mlalmMqDqsBnSETi2lUVdcgfIawO/zWUZ22ZxmtcIDLmMzRnzGP4Yo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Pe6ghYhQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AR0v01Va; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Pe6ghYhQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AR0v01Va" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62OAEUOq1761821 for ; Tue, 24 Mar 2026 10:34:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GUHL7c2p6O7qQg+zZiT8+TPwPHsQTYr0YGPYhMhdOb0=; b=Pe6ghYhQNzOwwkOS 8Gps9Fz/tTbU8hgNy77E931fsS+tBNOCA3Acu/yKP7wELYlCVBJ4PsRei9fqQpMV t73oEnnZInzoySAhis0ZsPyYjp1NUC6GCPVLam6MDg4WjvQ36F7AD6FjQ0Vn5UE5 Klzung+YGfqF7gmuU/XE4wXiBiViM1UbHRTBVPN1QmhqMkByd+IQ9e5j3/gNnMEw jqZH2MKTn1w6XGNq99VW2skJGYy0Qlj3BEAAEr0xmCYLqQWnpklS1UA4ZCvaOriN mG6P8XivfGTXAaDfmcgtuOuqNPGBX/JTSZQ/gdQGZqklZUozBlJhMd3KYnlzMb7G m+TEwQ== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d36f0c2bu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 10:34:01 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c70dd30025fso17682237a12.2 for ; Tue, 24 Mar 2026 03:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774348440; x=1774953240; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GUHL7c2p6O7qQg+zZiT8+TPwPHsQTYr0YGPYhMhdOb0=; b=AR0v01VaAegcbc/+SG/xqOjkAZMKc6lgUwoM0sVlP9GZBXO6uLR7jnUvRsEEGWBNqf iE0Vsbj+fFzSSvGRti8bkTwXuM52Ry1sx30aEODGLliNriaaEw/RLd5Kz1GSGAlfGhBs XgswrYZLBg5sXFgK7VbCZw13D1J1V8ij8brM2xP/Elyk8nqM+nSnZ3FedC0uNx7toqs+ ul9H/IqoXXS4uKMrtHbTC2nCHNSF7DOSGbGD//ifkZIxyeEIbvlIKMAV0XiG/QWLcbBI sNj+Lk6rcJT+/BemPvJiPytVP8Cotjt/2AamaBjEu7OTdKUP0OE9yPJQTwJAUyp1oLeU aCwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774348440; x=1774953240; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GUHL7c2p6O7qQg+zZiT8+TPwPHsQTYr0YGPYhMhdOb0=; b=U8lw8bKRG6sheFp0BkWrmU029CP6VYNO2Dak8YHBMsY6g/5uTiiH+s+reNG7lPAJ0i O1jWReDEYzJbJg7zkdj61JgbmDcJdLFBqLzwBewaOAKkmsoHh/0Pon9ionC/2jg3JA52 S2YL9JuE5NrrjaHy0RMitsMykhWungT8u9ouUoJqDYWkY3GFzbZTRSpacaR4ENj4t9Tt v7TH4fg4B77fV/qHNq95zmulzsDs6sH3b1LQcQa5MHF2wEHvoRYnUgBQfmZC1HJVfWs5 i2KNnhf0gaUsXUsz/1Ua9d2KK5JdoaLzvs2XvLLQqE8dOsPmWzuNQSN9K8zCxcFWquHL 0jNg== X-Forwarded-Encrypted: i=1; AJvYcCWeEFqarz4xmQpiu6HSjZbIJx63du9B3I4zn4Lb4gICxUJx6Ao90drvsbxVb9d8KY7kDC7lEc3A7886Sz0=@vger.kernel.org X-Gm-Message-State: AOJu0YwaqpFhBgtHGI8LOI7fVIG4Y6MGLfoHcDCpt9npsDs5Hm0dbb3m GjtLY0o3CFgkdSOZCGdPPv5r0xp9Ytrz/LFa33LbvXrXSCLner2gDX0JYsw5FB0kUStEHl9yMkg xBU8GWeTX++AIMQLVe4OElEIjDu0via/db97ynJuaNKV6ogGVcAC73VrOFZv1xv17Uag= X-Gm-Gg: ATEYQzxDqhMrjNs6FA6IWjMxJhR/xVP8jz4b6aFAKGD71gtxjNADgpTABFY9qHknNXY GEII9vzJwkj1tAi/WAs3rlndE0SUotGOGm8GGnKu2LECyyOJeupcMWt+wrBnyTZcIOu2HyJ+wRu DE+T7fGcqq1WqVhRf8nNsc5YvB8B7UkQFXpjEhQUMYPy3UXtsmKmCLtcnruVeUtgsfu5efe+C/0 haHd01wQtJ3aS5wkO7iDZ646rbNN/FInB03eeNfqhenqYrPuk8dd2xPV236zQyLX7RS5VI1u4z4 2OEiP8bggi+Jul1hhouuCzWV2y+454PDi2ezUJYbfaGhhZk5UDggGguGYqPqVJV6KUqjGOrUNU8 2oki/hlP3tLhQVWikxCDCxl78ctuEUlrm5ItMt0OTLFUbSkC3/W9m X-Received: by 2002:a05:6a00:139e:b0:829:9382:50ba with SMTP id d2e1a72fcca58-82a8c3b3bc0mr14523341b3a.60.1774348440315; Tue, 24 Mar 2026 03:34:00 -0700 (PDT) X-Received: by 2002:a05:6a00:139e:b0:829:9382:50ba with SMTP id d2e1a72fcca58-82a8c3b3bc0mr14523307b3a.60.1774348439776; Tue, 24 Mar 2026 03:33:59 -0700 (PDT) Received: from [10.218.44.178] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b03bbebb2sm13264445b3a.14.2026.03.24.03.33.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 03:33:58 -0700 (PDT) Message-ID: <9c8dfa88-f820-438e-8418-4919e1175edd@oss.qualcomm.com> Date: Tue, 24 Mar 2026 16:03:49 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 04/11] arm64: dts: qcom: lemans: Add power-domain and iface clk for ice node To: Harshal Dev , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Krzysztof Kozlowski References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> <20260323-qcom_ice_power_and_clk_vote-v4-4-e36044bbdfe9@oss.qualcomm.com> Content-Language: en-US From: Kuldeep Singh In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-4-e36044bbdfe9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=b+q/I9Gx c=1 sm=1 tr=0 ts=69c26899 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=RcdfdvLsBkETvr5PKcUA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-ORIG-GUID: _honI-valxL7B4Wcam_EumJRcH3aGbVu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDA4NCBTYWx0ZWRfX/vR7WWCpSr3I KOkMj2s7kj2/hvIO2pdym9tSZki9qWbtxxuYYH9GCyVqhYP8ZSzjlfFHmhtif1BdNY9StdE64PM xpsOZs2es0XKarFrDTw5vWpqmp0e4Qye1PCkhhTxzQ8Y5IjI3O2bW6DXwxv1XGLuasU1Q8HqTsW NtMwlmFRmRsXVNslU7ZKULLfqtBlOgQaJ85xCcwPNvo2Fa8A/B2+3SurF1Cyi4OKpN4htnVm5SQ GFEWsFpdOFkliVlEb2/0nExCUWuJ2tf8q5DoNxDhTC8QBn5gqaDRM+6rJ/p/CwkIceN8fTHjG1Z 0YM9l9/y+Nvs3NaMPZ66AvLrX27o5gDnEKDtERnf9zgpGNkxWCVO0d8iFo9OZLmFNQuz9OIq4Kq kJKVPlQ3j5XvmERSBJnjLLUHI8u/FxfHu9tgKU7vwfRbg3JxgkeO90lkUpEmwgKKyyYjzjCZ39k dsS1W7wJa2xR6fI61hQ== X-Proofpoint-GUID: _honI-valxL7B4Wcam_EumJRcH3aGbVu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_02,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240084 On 3/23/2026 2:47 PM, Harshal Dev wrote: > Qualcomm in-line crypto engine (ICE) platform driver specifies and votes > for its own resources. Before accessing ICE hardware during probe, to > avoid potential unclocked register access issues (when clk_ignore_unused > is not passed on the kernel command line), in addition to the 'core' clock > the 'iface' clock should also be turned on by the driver. This can only be > done if the UFS_PHY_GDSC power domain is enabled. Specify both the > UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for lemans. > > Fixes: 96272ba7103d4 ("arm64: dts: qcom: sa8775p: enable the inline crypto engine") > Reviewed-by: Konrad Dybcio > Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh -- Regards Kuldeep