From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A6A234D4EE for ; Wed, 22 Oct 2025 15:36:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761147424; cv=none; b=pMbf4B8+QlkcLGcWvUn5K1ccLZPScp928TE2VoXi7p3DoI0pw++FMcoAvkmNJBgQHjO3Bic1Q5piFNTnfsB7zIS+bcFFdVk1m8HEq1G/mU34osXSexeJIIAixvAo+ojG/zh3eOP9PobvrGt/4yxrqpr1MFWXvyimdEWpDHCjEJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761147424; c=relaxed/simple; bh=yw7MYPuJwxskvEnV1slIcH19SvjfzztecTsuaNiUHWM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RwgUbZ8UWmPuuGOeGqQqGxtlS79isyTxkXc39532sN2mlf2cHS8MLSPXgsojAcZs7aSBKypQjofleYPLJWFO++jiWZ1qMRny8LSQTocq/XH0ymbhc5+KXHEo9hmivgorG4PlkYlPt/Od2mcRtYCA2uqZjNz+7Y4BKOfnm17yPhY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N+mR72vB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N+mR72vB" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59MApOYW025477 for ; Wed, 22 Oct 2025 15:36:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= U+mhibcr3KvxpGvWKRaEQkH0yOEvTS11FzM0f/Yj4IM=; b=N+mR72vB8fZvYrOf Z7+8pw13DC6cpHEGOJaOqLWxI7uFt7PYW9q1skSuc8cvf10FTfjiqrT4FSKP8je6 aKjJegJ1MZka/ym+FAv2gjmvhVzyGycQRz639NZrtjJybBbPl6YSjNXPL6mB9UWM NFFWPdtm1w6CcSqAF/WfNHh5+2oWQvWcT28fRsiCkOY/+loj76uMf12X32x1A56m GQN2kxHDm3tmOmDt5GCezopMY42p/Cesdntl9kCVMO4+zQax+3N8zAqtutq+FhEX p3ss9ylZeg6tvXC71TRCwQyNh1TQQzr+87D7i9kmMP0yuKmYiIwW+yRNoBVgif4L tdfm2w== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49v1w857sj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 22 Oct 2025 15:36:53 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-87c2d14fc1bso12735476d6.3 for ; Wed, 22 Oct 2025 08:36:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761147412; x=1761752212; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U+mhibcr3KvxpGvWKRaEQkH0yOEvTS11FzM0f/Yj4IM=; b=bwd+fzYoNU4YmY45NuZ6WPCGz0BFu93cc51cd5ILA3jogZmOf/zIvElhEE/CLvs9Y8 /GCwfl1f+ybLs9BXisJr6xq5JNtb/W7px02/535iQxf74fxlu+m9KEoZxjQc9z7Ryp05 G8fj+IuaABEBGod6WK7sTYtcg6SRO03D1HANvBtOY2DXrT7JRWAPTPljSDzuL6q+gfmC SHjy/3UDHNtYInPlqflhvwopv7Z4dUNXQ8vTgqXzmtxRFW31Jh9D2Mawi9DbxsbmWgsf +XGi9ZVOfRbkLnv45uNPV+1XEGwayEBmrOuou0vQPYyPmn8xA4mumOk+ziviWL+oWBU6 knFw== X-Forwarded-Encrypted: i=1; AJvYcCVKSJFTzKBO+9hBEig4b7ewlw0X/ZvXtQA4A0j7EAXs7LKwzzSKjlcDpmYHSN51yULYTkHBKhDItdwK7s0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxjogst758TqdS6C6sCYdPWtx0S2kRVdSvjC+9RvtusBuXSVO0h 1raupL9Z4kUiKcuNHwMhgqJbjNIn8p9fSnwR4asG5MqHAancnfIt8hrE9fE66FFVftkIkiBGBRq 3HlxemdNTer2EtBMhdiwJECaJb/l6yopEJyQq8p0fnGpN9akMDIlJVIWR9UmequjLlLc= X-Gm-Gg: ASbGncuvn5MyK6YJf6da4cha1b9MqL5Z+RQNdWPTPhjVMS191HVNRRPPhS8zeelFUy6 97zyPE7ytHCOxAyrD8IN693CVEdQbm3PY4SJpW7+am0Q4laLAheLi1LRxgW+ni/pCpp00tMoeKj HQZiimTC7hp7Gg1vQdfwrf31dQbkGpw3Z3mDdZr7tPqm28AT9BSp/R8q5EKhsTTyTXBvYZZbirJ 7oKz3VfuqGIMouq5j7R4Gmf63VjS91mVPxYBnfUbDmGi/GG3Ur83OyeO9xiFa037EdGECup0FWq lhd5wvVohc1f8wzEzWoUWXsgjUiXQH1RxKZImCsBLKlhOA8so0A++iFs3nHu/QfyPbbvJomsEAh PQ87B4dm6m9mp6NqGA6w2B8rxHggVRASdtg7s+GTVnJzfDFydpISlZG8R X-Received: by 2002:ac8:5843:0:b0:4b7:94ee:4fb2 with SMTP id d75a77b69052e-4ea116b05d0mr59506911cf.5.1761147412394; Wed, 22 Oct 2025 08:36:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF5FuP8hgpkFIa3uP3XvrbHL/HJQny7T4MX9pzM+xYE09ja+BdsOTDkZo9VZA53gUib6HSKPw== X-Received: by 2002:ac8:5843:0:b0:4b7:94ee:4fb2 with SMTP id d75a77b69052e-4ea116b05d0mr59506401cf.5.1761147411728; Wed, 22 Oct 2025 08:36:51 -0700 (PDT) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-63c48ab54desm12600892a12.13.2025.10.22.08.36.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Oct 2025 08:36:51 -0700 (PDT) Message-ID: <9c920cdf-1985-4656-bee2-8bfacc15bfa9@oss.qualcomm.com> Date: Wed, 22 Oct 2025 17:36:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/8] media: dt-bindings: qcom-kaanapali-iris: Add kaanapali video codec binding To: Vikash Garodia , Krzysztof Kozlowski , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vishnu Reddy References: <20251017-knp_video-v2-0-f568ce1a4be3@oss.qualcomm.com> <20251017-knp_video-v2-1-f568ce1a4be3@oss.qualcomm.com> <034bf6f4-0a49-4973-8536-28526b3409d1@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <034bf6f4-0a49-4973-8536-28526b3409d1@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAxNSBTYWx0ZWRfX7N2XDc2hjJQF bPhU3DGEulZsDrh/N/7EMZuv/kSMo7diVFUd9NO8JjeqccD/x906lTyh6AB3sAjQjCxlQpYP/Kx xdtXgJtjUgqdMoDxJoR3Be6sevX8xKaVd/z1l1N5uc2+wmMrLfijuRWuz1P3k6rneyP2w5rfWgJ yJnzU2SWE+pQENzX7Uiwm05gTRCubPpi/U6/p+GuDSuZao4z7gcJLfd6euyatZo6EGG+VbA5JtO KcLKjRljac/E8E/1GGJ3n+/xBkrUT4Hf/d+S9A/CFiHmo02NmXon418jNP6DstPvdY6YXdQ2Jgz nh3ZXvdFW84+CbId6/4Hn4uJ6QmIynQQ0AUh0M3Pkn2kwBZGI8Jos8SDyg2uByABa5xJLzD/Dvh JlY74ww+MMCDq/H7MVWahHc0Vj53Sw== X-Authority-Analysis: v=2.4 cv=bNUb4f+Z c=1 sm=1 tr=0 ts=68f8fa15 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=MY7ZD1EjAs5gof5aNy0A:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-GUID: K1C-YBPQJCjaz6WSMXm8-VsswFl8GrbP X-Proofpoint-ORIG-GUID: K1C-YBPQJCjaz6WSMXm8-VsswFl8GrbP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-22_06,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 adultscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180015 On 10/21/25 8:55 PM, Vikash Garodia wrote: > > On 10/18/2025 9:28 PM, Krzysztof Kozlowski wrote: >> On 17/10/2025 16:16, Vikash Garodia wrote: >>> + clock-names: >>> + items: >>> + - const: iface >>> + - const: core >>> + - const: vcodec0_core >>> + - const: iface1 >>> + - const: core_freerun >>> + - const: vcodec0_core_freerun >>> + - const: vcodec_bse >>> + - const: vcodec_vpp0 >>> + - const: vcodec_vpp1 >>> + - const: vcodec_apv >>> + >>> + dma-coherent: true >>> + >>> + firmware-name: >>> + maxItems: 1 >>> + >>> + interconnects: >>> + maxItems: 2 >>> + >>> + interconnect-names: >>> + items: >>> + - const: cpu-cfg >>> + - const: video-mem >>> + >>> + interrupts: >>> + maxItems: 1 >>> + >>> + iommus: >>> + minItems: 3 >>> + maxItems: 8 >> >> I don't understand why this is flexible. Make it fixed size and anyway - >> list the items. > > kaanapali vpu generates 8 different stream-ids. Now, boards running kernel in > EL2 mode can list all of them, while boards running in EL1 can have only non > secure stream IDs. Min have the list of stream ids which can be enabled for all > type of boards, while max is for boards which can list all in HLOS given kernel > is in EL2 mode. > > Below crash would be seen if boards running kernel in EL1 mode lists the secure > ones. > > [ 1.361157] pc : qcom_smmu_write_s2cr+0x64/0xa4 > [ 1.361165] lr : arm_smmu_write_s2cr+0x2c/0xbc > [ 1.361168] sp : ffff80008005b8f0 > [ 1.361169] x29: ffff80008005b8f0 x28: 0000000000000000 x27: ffffc7f252f45320 > .... > [ 1.361195] x2 : ffff800081200c48 x1 : 0000000000000048 x0 : ffff800081200000 > [ 1.361198] Call trace: > [ 1.361199] qcom_smmu_write_s2cr+0x64/0xa4 (P) > [ 1.361203] arm_smmu_master_install_s2crs+0x7c/0xac > [ 1.361207] arm_smmu_attach_dev+0xb0/0x1d4 > > Could you please suggest on listing the iommu items ? I did not find the > relevant references in other bindings where flexible iommus is being listed. Krzysztof would probably like to see what I believe someone else somewhere sometime suggested in the iommus discussions (sorry it's not possible to keep track of it all), where the DT can list every possible required iommu sid, but the driver ensures only the ones that are necessary are utilized. This will require big changes to the iommu framework though, I'm afraid >> I already asked this. >> >>> + >>> + memory-region: >>> + minItems: 1 >>> + maxItems: 2 >> >> Same comment. I already asked this about iommus. > > Same here, there aren't any bindings which lists for flexible memory-region. > Please suggest if there are any such references. Similarly, we can define the additional memory region that's necessary for $reasons and leave it unused in the driver (actually I don't know why there may be two, but let's assume it's a QTEE/noQTEE detail), because for the hw to operate, it must be set up by some entity in the system either way (i.e. the memory is reserved even if it's not done by Linux) Konrad