mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chuyi Zhou <zhouchuyi@bytedance.com>
To: tj@kernel.org, void@manifault.com, arighi@nvidia.com,
	changwoo@igalia.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched_ext: Fix the incorrect bpf_list kfunc API in common.bpf.h.
Date: Wed, 12 Feb 2025 15:30:20 +0800	[thread overview]
Message-ID: <9c9498a0-342f-4ade-8310-b5a9aaa485b0@bytedance.com> (raw)
In-Reply-To: <20250212071936.1406029-1-zhouchuyi@bytedance.com>



在 2025/2/12 15:19, Chuyi Zhou 写道:
> Now BPF only supports bpf_list_push_{front,back}_impl kfunc, not bpf_list_
> push_{front,back}.
> 
> This patch fix this issue. Without this patch, if we use bpf_list kfunc
> in scx, the BPF verifier would complain:
> 
> libbpf: extern (func ksym) 'bpf_list_push_back': not found in kernel or
> module BTFs
> libbpf: failed to load object 'scx_foo'
> libbpf: failed to load BPF skeleton 'scx_foo': -EINVAL
> 
> With this patch, the bpf list kfunc will work as expected.
> 

Sorry, I missed the Fixes tag.

Fixes: 2a52ca7c98960 ("sched_ext: Add scx_simple and scx_example_qmap 
example schedulers")

> Signed-off-by: Chuyi Zhou <zhouchuyi@bytedance.com>
> ---
>   tools/sched_ext/include/scx/common.bpf.h | 12 ++++++++++--
>   1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/sched_ext/include/scx/common.bpf.h b/tools/sched_ext/include/scx/common.bpf.h
> index d72b60a0c582..7849405614b1 100644
> --- a/tools/sched_ext/include/scx/common.bpf.h
> +++ b/tools/sched_ext/include/scx/common.bpf.h
> @@ -270,8 +270,16 @@ void bpf_obj_drop_impl(void *kptr, void *meta) __ksym;
>   #define bpf_obj_new(type) ((type *)bpf_obj_new_impl(bpf_core_type_id_local(type), NULL))
>   #define bpf_obj_drop(kptr) bpf_obj_drop_impl(kptr, NULL)
>   
> -void bpf_list_push_front(struct bpf_list_head *head, struct bpf_list_node *node) __ksym;
> -void bpf_list_push_back(struct bpf_list_head *head, struct bpf_list_node *node) __ksym;
> +int bpf_list_push_front_impl(struct bpf_list_head *head,
> +				    struct bpf_list_node *node,
> +				    void *meta, __u64 off) __ksym;
> +#define bpf_list_push_front(head, node) bpf_list_push_front_impl(head, node, NULL, 0)
> +
> +int bpf_list_push_back_impl(struct bpf_list_head *head,
> +				   struct bpf_list_node *node,
> +				   void *meta, __u64 off) __ksym;
> +#define bpf_list_push_back(head, node) bpf_list_push_back_impl(head, node, NULL, 0)
> +
>   struct bpf_list_node *bpf_list_pop_front(struct bpf_list_head *head) __ksym;
>   struct bpf_list_node *bpf_list_pop_back(struct bpf_list_head *head) __ksym;
>   struct bpf_rb_node *bpf_rbtree_remove(struct bpf_rb_root *root,


  reply	other threads:[~2025-02-12  7:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-12  7:19 Chuyi Zhou
2025-02-12  7:30 ` Chuyi Zhou [this message]
2025-02-13 16:48 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c9498a0-342f-4ade-8310-b5a9aaa485b0@bytedance.com \
    --to=zhouchuyi@bytedance.com \
    --cc=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®