From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCC7C1BDA94 for ; Fri, 16 Aug 2024 15:50:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723823426; cv=none; b=Ne8XnlubM3L4Fd8U4swh055mrYth7wJHvE1kk8lnnTIjRLUlFDCbEezowXj5DfHhc3NXNYP5HJBoHwptkruX//NYLvUacWmswLo0erRnml7/V/qqzMtCeQqMiQa9WbKGBU6/zpd5NT1+P5UPP9FOqLb9rwAkKGnkM1Ryw+2YK0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723823426; c=relaxed/simple; bh=WQdmIL3ebAOO0xVkHMynMFWZBLZgYyRqLYq+hICJS8o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kE95ow4UVR++Ss/LmBDlbKoioljlqwKYD2pH58mxw3CGS399cB5xPpfqcezA7HnJ3n/KFiK88n4kyBgXZqE4Y6XJXMhVlIs5NigJ2qQ9BATWJLSBakNqoyhnLzHBW0sdmH5T9GlrNXjDVZLuwFwdh4E2EG8HkHwoe8Aw7SAlqbY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=d6IGlsnA; arc=none smtp.client-ip=209.85.217.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="d6IGlsnA" Received: by mail-vs1-f45.google.com with SMTP id ada2fe7eead31-493e8ef36b4so809194137.2 for ; Fri, 16 Aug 2024 08:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1723823424; x=1724428224; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=04UNYulrmBw5at1Th7g14Wg4WZSr6HgYutjIS185Fn8=; b=d6IGlsnALB0KOhf6915sdlOrwIHOvuslI0NYMn9bSidLj/7Bwl/MFfh7MWG3fdUOvP sNw+ltCpWGPMpa+drLV7WdfCfxcfPUKpgtkA64am+grybUrmuVst/UowkV8cikzyPfpF tg9kS8Qdlrt8NFTWMhPHju7AcrMgQTPY8LZ5c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723823424; x=1724428224; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=04UNYulrmBw5at1Th7g14Wg4WZSr6HgYutjIS185Fn8=; b=AQl+3KAUouFQJ9eFm2qlm6pSQMrYYAS/KlnkLOt3vs3fa6EQauAjuJNKhUOdIFWgr1 ORoHK5U8Lfqo3kVj7L7WwD8/WZ3iwEBVIK0O4LAZrftrLEoZKQ5w3iQ9kk0z4rICh51Y u1fvSAzwelmU9eGAMwu7zd5gmtXbatBqtSqUj3zGQwFtXjo6M2I8xQ9ZmimEnrbWlu/9 F91XBl/bdQenBY7l6IJKUOJ3qgOv/+KUPmw4UAeSKLXuuKwBo09DtW9OQ0EOf+RqP0dW a8v04u/lufjiI0N4tSgaiP5rhnCXFbZMkyM6fBZMRe2kEGSKdcNWTffb5zG4SSWbPRZc PWSw== X-Forwarded-Encrypted: i=1; AJvYcCW+8iUdya5PEukVJBj5vmFRBdCBjrroFXu/4yFED6fHG0+Zsd1u0rlE8hmt3Y5bfIJbSqdiL+TbEJwzk18I9vDYbwwTKXPkqyiABbHp X-Gm-Message-State: AOJu0YzSDZiLTFh5cMqvVcsFT90iowVCHiDX4/fswzva5WxiI12BxgwJ 394HOvWQqRNaYVTaGEjP5Tu5x5NxShupPJr1M50rRoZCHG5tRRMcapFC6NpAuA== X-Google-Smtp-Source: AGHT+IE2SAN3rGBjCvJuW576PqD2U+6D8iHOvypWNA4L+rUXdZYnB1HrLenKMMJE5odaPgj8kD4R3A== X-Received: by 2002:a05:6102:511e:b0:48f:831d:cea6 with SMTP id ada2fe7eead31-497799a592dmr4404272137.25.1723823423697; Fri, 16 Aug 2024 08:50:23 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45369fd9e39sm17816701cf.2.2024.08.16.08.50.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Aug 2024 08:50:23 -0700 (PDT) Message-ID: <9c9a050c-f35b-47b8-823d-96535614b5bb@broadcom.com> Date: Fri, 16 Aug 2024 08:50:19 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 04/13] PCI: brcmstb: Use common error handling code in brcm_pcie_probe() To: Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Manivannan Sadhasivam , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Philipp Zabel , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list References: <20240815225731.40276-1-james.quinlan@broadcom.com> <20240815225731.40276-5-james.quinlan@broadcom.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20240815225731.40276-5-james.quinlan@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/15/24 15:57, Jim Quinlan wrote: > Refactor the error handling in the bottom half of the probe > function for readability. The invocation of clk_prepare_enable() > is moved lower in the function and this simplifies a couple > of return paths. dev_err_probe() is also used when it is apt. > > Signed-off-by: Jim Quinlan Reviewed-by: Florian Fainelli -- Florian