mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH V4 2/2] ptr_ring: try vmalloc() when kmalloc() fails
Date: Sun, 11 Feb 2018 10:45:56 +0800	[thread overview]
Message-ID: <9c9bcbf9-02df-20ee-55ea-7234558ceded@redhat.com> (raw)
In-Reply-To: <20180209173914-mutt-send-email-mst@kernel.org>



On 2018年02月09日 23:53, Michael S. Tsirkin wrote:
> On Fri, Feb 09, 2018 at 05:45:50PM +0800, Jason Wang wrote:
>> This patch switch to use kvmalloc_array() for using a vmalloc()
>> fallback to help in case kmalloc() fails.
> Above isn't really saying anything about the motivation, it
> just explains what kvmalloc_array does.
>
> How about:
>
> Switch ptr_ring from kmalloc to kvmalloc. This way it can support larger
> ring sizes.
>
>> Reported-by:syzbot+e4d4f9ddd4295539735d@syzkaller.appspotmail.com
>> Fixes: 2e0ab8ca83c12 ("ptr_ring: array based FIFO for pointers")
> I don't see this as a bugfix - it's more of an enhancement.
>
> Do we need this in net or can we defer this to net-next?

Consider they are users of tx_queue_len of more than 1000000 from google 
searching. We'd better have this in -net.

Thanks

>
> I'm not sure myself. For now
>
> Acked-by: Michael S. Tsirkin<mst@redhat.com>
>

  reply	other threads:[~2018-02-11  2:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09  9:45 [PATCH V4 1/2] ptr_ring: fail early if queue occupies more than KMALLOC_MAX_SIZE Jason Wang
2018-02-09  9:45 ` [PATCH V4 2/2] ptr_ring: try vmalloc() when kmalloc() fails Jason Wang
2018-02-09 15:53   ` Michael S. Tsirkin
2018-02-11  2:45     ` Jason Wang [this message]
2018-02-09 19:29   ` David Miller
2018-02-09 15:39 ` [PATCH V4 1/2] ptr_ring: fail early if queue occupies more than KMALLOC_MAX_SIZE Michael S. Tsirkin
2018-02-09 19:29 ` David Miller
2018-02-10 19:32 ` Eric Biggers
2018-02-11  2:46   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c9bcbf9-02df-20ee-55ea-7234558ceded@redhat.com \
    --to=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome