From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A75F7C48BD6 for ; Wed, 26 Jun 2019 10:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D7D020656 for ; Wed, 26 Jun 2019 10:52:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726862AbfFZKwV (ORCPT ); Wed, 26 Jun 2019 06:52:21 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:19080 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726347AbfFZKwU (ORCPT ); Wed, 26 Jun 2019 06:52:20 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 6E58F3CB74AA66A3D694; Wed, 26 Jun 2019 18:52:18 +0800 (CST) Received: from [10.151.23.176] (10.151.23.176) by smtp.huawei.com (10.3.19.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 26 Jun 2019 18:52:08 +0800 Subject: Re: [PATCH RESEND] staging: erofs: remove unsupported ->datamode check in fill_inline_data() To: Yue Hu , , CC: , , , , Miao Xie References: <20190626103936.9064-1-zbestahu@gmail.com> From: Gao Xiang Message-ID: <9c9c656e-2f29-d086-362e-76bf1760191a@huawei.com> Date: Wed, 26 Jun 2019 18:51:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190626103936.9064-1-zbestahu@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.151.23.176] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yue, On 2019/6/26 18:39, Yue Hu wrote: > From: Yue Hu > > Already check if ->datamode is supported in read_inode(), no need to check > again in the next fill_inline_data() only called by fill_inode(). > > Signed-off-by: Yue Hu > Reviewed-by: Gao Xiang > Reviewed-by: Chao Yu Bump the patch version in the title as Greg said... Otherwise, it is hard to differ which patch is the latest patch... Thanks, Gao Xiang > --- > drivers/staging/erofs/inode.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c > index e51348f..d6e1e16 100644 > --- a/drivers/staging/erofs/inode.c > +++ b/drivers/staging/erofs/inode.c > @@ -129,8 +129,6 @@ static int fill_inline_data(struct inode *inode, void *data, > struct erofs_sb_info *sbi = EROFS_I_SB(inode); > const int mode = vi->datamode; > > - DBG_BUGON(mode >= EROFS_INODE_LAYOUT_MAX); > - > /* should be inode inline C */ > if (mode != EROFS_INODE_LAYOUT_INLINE) > return 0; >