From: Paolo Abeni <pabeni@redhat.com>
To: Yunsheng Lin <linyunsheng@huawei.com>,
davem@davemloft.net, kuba@kernel.org,
MPTCP Upstream <mptcp@lists.linux.dev>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@openeuler.org, edumazet@google.com,
yoshfuji@linux-ipv6.org, dsahern@kernel.org
Subject: Re: [PATCH net-next] tcp: add tcp_tx_skb_cache_key checking in sk_stream_alloc_skb()
Date: Wed, 01 Sep 2021 12:52:05 +0200 [thread overview]
Message-ID: <9c9ef2228dfcb950b5c75382bd421c6169e547a0.camel@redhat.com> (raw)
In-Reply-To: <1630492744-60396-1-git-send-email-linyunsheng@huawei.com>
On Wed, 2021-09-01 at 18:39 +0800, Yunsheng Lin wrote:
> Since tcp_tx_skb_cache is disabled by default in:
> commit 0b7d7f6b2208 ("tcp: add tcp_tx_skb_cache sysctl")
>
> Add tcp_tx_skb_cache_key checking in sk_stream_alloc_skb() to
> avoid possible branch-misses.
>
> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Note that MPTCP is currently exploiting sk->sk_tx_skb_cache. If we get
this patch goes in as-is, it will break mptcp.
One possible solution would be to let mptcp usage enable sk-
>sk_tx_skb_cache, but that has relevant side effects on plain TCP.
Another options would be re-work once again the mptcp xmit path to
avoid using sk->sk_tx_skb_cache.
Cheers,
Paolo
next prev parent reply other threads:[~2021-09-01 10:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 10:39 Yunsheng Lin
2021-09-01 10:52 ` Paolo Abeni [this message]
2021-09-01 15:06 ` Eric Dumazet
2021-09-01 15:16 ` Eric Dumazet
2021-09-01 15:25 ` Paolo Abeni
2021-09-01 15:29 ` Eric Dumazet
2021-09-01 16:01 ` Paolo Abeni
2021-09-01 16:02 ` Eric Dumazet
2021-09-02 0:47 ` Yunsheng Lin
2021-09-02 1:13 ` Eric Dumazet
2021-09-02 2:05 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c9ef2228dfcb950b5c75382bd421c6169e547a0.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=linyunsheng@huawei.com \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®