From: Joe Perches <joe@perches.com>
To: Michael Straube <straube.linux@gmail.com>, gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8188eu: remove redundant definition of ETH_ALEN
Date: Sun, 02 Jun 2019 13:07:30 -0700 [thread overview]
Message-ID: <9ca0c459d047c72fc459313ad570ecc59cf5d300.camel@perches.com> (raw)
In-Reply-To: <20190602163528.28495-1-straube.linux@gmail.com>
On Sun, 2019-06-02 at 18:35 +0200, Michael Straube wrote:
> ETH_ALEN is defined in linux/if_ether.h which is included by
> osdep_service.h, so remove the redundant definition from ieee80211.h.
[]
> diff --git a/drivers/staging/rtl8188eu/include/ieee80211.h b/drivers/staging/rtl8188eu/include/ieee80211.h
[]
> @@ -14,7 +14,6 @@
>
> #define MGMT_QUEUE_NUM 5
>
> -#define ETH_ALEN 6
> #define ETH_TYPE_LEN 2
> #define PAYLOAD_TYPE_LEN 1
While you're at it:
neither ETH_TYPE_LEN nor PAYLOAD_TYPE_LEN appear to be used.
next prev parent reply other threads:[~2019-06-02 20:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 16:35 Michael Straube
2019-06-02 16:35 ` [PATCH 2/2] staging: rtl8188eu: remove unused definitions from ieee80211.h Michael Straube
2019-06-02 20:07 ` Joe Perches [this message]
2019-06-03 6:10 ` [PATCH 1/2] staging: rtl8188eu: remove redundant definition of ETH_ALEN Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ca0c459d047c72fc459313ad570ecc59cf5d300.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®