From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f100.google.com (mail-ua1-f100.google.com [209.85.222.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B12B33F58D for ; Sun, 26 Jul 2026 19:21:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785093664; cv=none; b=VxWOPaMA5xbcAxYABgAT702uFArqfMpQSez5vPJhqznvzU5Iip+u7j8RzHGUDUGkcpDyfw6nCKcdizcs5at1G+QtCqEpcAZkt7FEnTtGVaCQ6bzSotU15oKELa02nml2mCdDASny6ijV24vTjJEH8o/ybH9DQjUdLnoswiOgEBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785093664; c=relaxed/simple; bh=fyLOzs4S/leSr8Df5qHayjyTwwiwPthIuUyGjrAo7uI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EjxomySif9+o3TzBU1Albg5T2YSDB6rc9QqTcbNY6PnsZwbuOXipchoJ3inztMRqqsB7Dn2dYh4e8lP/tKu6zoutklJurYPSLCFsEp7BlzzACVDtiiKteCjLPOA7+59ap/WnW8RYXWRVGBbB33/wzXil23uB5Kcngeu2BuH0eIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=iJGOK+AG; arc=none smtp.client-ip=209.85.222.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="iJGOK+AG" Received: by mail-ua1-f100.google.com with SMTP id a1e0cc1a2514c-96944741eaeso700410241.1 for ; Sun, 26 Jul 2026 12:21:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785093661; x=1785698461; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=f/GC7/JY8dkQF9VYMmOxneNdfen5EFzs8r5WpvRe5Po=; b=rZIUZ2sHnFjoHO7Utvf7yUhNRk4mBEzS1LfglC7+zsYianituGT22TxS/M7PQhM94k a5SC7zxzVHlzMg3Ldo+4ZXsQnU/58Eeohi6wjeXwBQG0ODt4yzSMuP0XuDOWbRpTUq4+ X6IL7PqJefbaSf3XDEABRK+ogghl539clSAN9d/lfbivzKsut7hvFn/8+EU0GLmcihy1 koX147GJ7BXVmwjPPhs4odVNKnjhBfsA0kpB0vCc58CjLjew/7NEP2oekIJyk3+Yq6ud NVAZqBWjgWYYyOPEtphnR/6WQ4tAgb06VGmNsNmPpOF2gkTP/tfjxZhj3VvQD7ibhOJD /4Ow== X-Forwarded-Encrypted: i=1; AHgh+RrOBjdpnL95NP0QCNIREOlaja9PoECgkt5aD8IEoExalU/QGzYQ2LT8bIido+qL1CUnDMaRUxxEVp9YCCI=@vger.kernel.org X-Gm-Message-State: AOJu0YyyiAsqDhX8kGIkUgUmvf+wRQG98QM2LWMMrXrVYrqApJAN/nkJ ssWF0i1CA6Kfsn+LHJ7MTjVXkfQM8lKjAz8hCB8EmH5IInGRlLXb7dkoO8XXzBqXTeSLo9G98jA fMTzSKD4niAfYMWksSARna33oUKxhzpNTbh4P4Gl7IhWRSGePe+dZaipQHUmvgjXBPbhbw0/gY2 PEk9WIKmdFpR/JbGK7hMfSnhO3jmeUlMOGumpIyFuHd+wIJuUIRmmpgCOAG7yaf9EfJ4v0SPjkY ynvl397MpK5ZtaE8csNwpvpkQ== X-Gm-Gg: AR+sD12O0GW5ODSp2DaDOCIvbBvfU7WAO3eBp9NukFCqM2Ltu/cFdJ5uAbwSbXullhN 3ZLqqtxmzWTgIWZbe5JpkTpGooElOQ8a7O1vm0QfCzkre0yCFR5njvxw4EAuDOj8p9zDLI7Grnt +nHJYadqu2YpSmBRfqSEubUcJNNJtGHHmFXCm7c4drGoBhoZa6Z3T74aHXWL1YUR1G2NMQSC6od tgOSJEK0AmMWcFzAiE2n2obgHheioi3KtzuE63b08bmIftgT8GnjXtGR3fz1Glc0qpkPZvrIejG o7y1Iq/U2B5xhojGDBz2Ye/uCBQJuW+i5cFOEGfVrDuflKVOnRJeROPfNutjaSqqF+wBWYNp5q1 nll+VNbNy7ZXGmrqFAzVtspsv8r1V+helf89rls2yi3u0Ijy9r7rg6zWUe/DoyzZ+7BqEoB7KnB SfRa7hFNMNezEcQLpXYhoM69P4yeCNEqQOeCdKIXI= X-Received: by 2002:a05:6122:46aa:b0:5bf:4522:fca7 with SMTP id 71dfb90a1353d-5c306bc397dmr2432977e0c.4.1785093661307; Sun, 26 Jul 2026 12:21:01 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-26.dlp.protect.broadcom.com. [144.49.247.26]) by smtp-relay.gmail.com with ESMTPS id 71dfb90a1353d-5c3051150d2sm467160e0c.0.2026.07.26.12.21.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Jul 2026 12:21:01 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-ca7c1e22995so3433361a12.3 for ; Sun, 26 Jul 2026 12:21:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1785093660; x=1785698460; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=f/GC7/JY8dkQF9VYMmOxneNdfen5EFzs8r5WpvRe5Po=; b=iJGOK+AGpw2CkEbnj50wcebYkiwi6YAdYtW9uy6mi/MfJR3/sZbkcjBaX63QKIPGsx YsuKL0MY4qmRgNpcct6/N4B8ReBFlErLiIrvQvPKKI6+NAFDzh1muAdtz6AQMBQFq2Jh cCytyiJPwD7azc6SUGVKyg91HXLTl3/aaGS9M= X-Forwarded-Encrypted: i=1; AHgh+Rr5rkAExc+hM+q7PfxWZkHN03bZOM76TPcwS6p3OMOQ5d4gs7o0VXHc9QmPSvkKEarBAYs/z96R6Vg4D48=@vger.kernel.org X-Received: by 2002:a05:6a21:6da8:b0:3bf:7c02:c46f with SMTP id adf61e73a8af0-3c67dae4388mr6673904637.14.1785093660099; Sun, 26 Jul 2026 12:21:00 -0700 (PDT) X-Received: by 2002:a05:6a21:6da8:b0:3bf:7c02:c46f with SMTP id adf61e73a8af0-3c67dae4388mr6673881637.14.1785093659625; Sun, 26 Jul 2026 12:20:59 -0700 (PDT) Received: from [10.229.42.29] ([192.19.176.250]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13d13015052sm43706517c88.5.2026.07.26.12.20.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jul 2026 12:20:59 -0700 (PDT) Message-ID: <9ca181db-7bec-4f6c-9f42-4a66068af354@broadcom.com> Date: Sun, 26 Jul 2026 21:20:52 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] wifi: brcmfmac: cyw: set a unique cookie for mgmt tx To: Bogdan Nicolae Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org References: <20260725014411.170340-1-bogdan.nicolae@gmail.com> Content-Language: en-US From: Arend van Spriel In-Reply-To: <20260725014411.170340-1-bogdan.nicolae@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 25/07/2026 03:44, Bogdan Nicolae wrote: > Set cookie using an increasing atomic counter. Avoids mismatches of completion > events later in brcmf_notify_mgmt_tx_status, where packet_id != vif->mgmt_tx_id > is checked. Thanks for the split. I increased the scope and been looking in the cookie usage in the wireless subsystem. So I have a series lined up to change the cookie to an input parameter and have cfg80211 hand out the cookie value (it already has cfg80211_assign_cookie() function). This will also cover zero cookie fix here. So I would suggest to drop this patch and only let the PMKID patch go in. Regards, Arend