From: Oliver Neukum <oneukum@suse.com>
To: Nicolas Bouchinet <nicolas.bouchinet@oss.cyber.gouv.fr>,
Oliver Neukum <oneukum@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Kannappan R <r.kannappan@intel.com>,
Sabyrzhan Tasbolatov <snovitoll@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Stefan Eichenberger <stefan.eichenberger@toradex.com>,
Thomas Gleixner <tglx@linutronix.de>,
Pawel Laszczak <pawell@cadence.com>, Ma Ke <make_ruc2021@163.com>,
Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
Luc Bonnafoux <luc.bonnafoux@ssi.gouv.fr>,
Luc Bonnafoux <luc.bonnafoux@oss.cyber.gouv.fr>,
Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [RFC PATCH 3/4] usb: core: Plug the usb authentication capability
Date: Mon, 30 Jun 2025 15:07:00 +0200 [thread overview]
Message-ID: <9ca2c058-d562-4c9e-8d0c-695703573ed7@suse.com> (raw)
In-Reply-To: <6dce47fd-01fb-4401-88a3-d9e85ee5529a@oss.cyber.gouv.fr>
Hi,
On 30.06.25 14:34, Nicolas Bouchinet wrote:
> Hi Olivier,
>
> Thank you for your review.
>
> Indeed our current implementation of the usb authentication is still a bit
> crude.
that is understood, but the question here is not just whether they
are crude, but whether they are sensible. You are putting the use of
the authentication code in usb_new_device(). This means that the admin
cannot change the settings of currently connected devices. It would seem
to me that the check should go into usb_claim_interface().
Regards
Oliver
next prev parent reply other threads:[~2025-06-30 13:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 14:27 [RFC PATCH 0/4] Support for usb authentication nicolas.bouchinet
2025-06-20 14:27 ` [RFC PATCH 1/4] usb: core: Introduce netlink usb authentication policy engine nicolas.bouchinet
2025-06-21 9:37 ` Sabyrzhan Tasbolatov
2025-06-30 11:42 ` Nicolas Bouchinet
2025-06-20 14:27 ` [RFC PATCH 2/4] usb: core: Introduce usb authentication feature nicolas.bouchinet
2025-06-20 14:54 ` Greg Kroah-Hartman
2025-06-30 11:07 ` Nicolas Bouchinet
2025-06-30 11:43 ` Greg Kroah-Hartman
2025-06-21 10:21 ` Sabyrzhan Tasbolatov
2025-06-30 11:56 ` Nicolas Bouchinet
2025-06-25 9:59 ` Oliver Neukum
2025-06-30 12:38 ` Nicolas Bouchinet
2025-06-20 14:27 ` [RFC PATCH 3/4] usb: core: Plug the usb authentication capability nicolas.bouchinet
2025-06-20 19:11 ` Alan Stern
2025-06-30 11:20 ` Nicolas Bouchinet
2025-06-30 18:04 ` Alan Stern
2025-06-21 11:09 ` Sabyrzhan Tasbolatov
2025-06-30 12:25 ` Nicolas Bouchinet
2025-06-23 18:15 ` Oliver Neukum
2025-06-30 12:34 ` Nicolas Bouchinet
2025-06-30 13:07 ` Oliver Neukum [this message]
2025-06-20 14:27 ` [RFC PATCH 4/4] usb: core: Add Kconfig option to compile usb authorization nicolas.bouchinet
2025-06-21 7:22 ` Greg Kroah-Hartman
2025-06-30 11:22 ` Nicolas Bouchinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ca2c058-d562-4c9e-8d0c-695703573ed7@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=luc.bonnafoux@oss.cyber.gouv.fr \
--cc=luc.bonnafoux@ssi.gouv.fr \
--cc=make_ruc2021@163.com \
--cc=nicolas.bouchinet@oss.cyber.gouv.fr \
--cc=nicolas.bouchinet@ssi.gouv.fr \
--cc=pawell@cadence.com \
--cc=r.kannappan@intel.com \
--cc=snovitoll@gmail.com \
--cc=stefan.eichenberger@toradex.com \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®