mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Mirsad Todorovac <mtodorovac69@gmail.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Nilesh Javali <njavali@marvell.com>,
	GR-QLogic-Storage-Upstream@marvell.com,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v1 1/1] scsi: gla2xxx: use flexible array member at the end of structures
Date: Wed, 23 Oct 2024 15:25:58 -0700	[thread overview]
Message-ID: <9ca3fb4b-85d9-493c-8b90-5210f5530e7f@acm.org> (raw)
In-Reply-To: <20241023221700.220063-2-mtodorovac69@gmail.com>

On 10/23/24 3:17 PM, Mirsad Todorovac wrote:
> Fixes: 21038b0900d1b ("scsi: qla2xxx: Fix endianness annotations in header files")

The "Fixes:" tag is wrong. The one-element arrays were introduced long
before I fixed the endianness annotations.

> diff --git a/drivers/scsi/qla2xxx/qla_dbg.h b/drivers/scsi/qla2xxx/qla_dbg.h
> index 54f0a412226f..ca9304df484b 100644
> --- a/drivers/scsi/qla2xxx/qla_dbg.h
> +++ b/drivers/scsi/qla2xxx/qla_dbg.h
> @@ -31,7 +31,7 @@ struct qla2300_fw_dump {
>   	__be16 fpm_b1_reg[64];
>   	__be16 risc_ram[0xf800];
>   	__be16 stack_ram[0x1000];
> -	__be16 data_ram[1];
> +	__be16 data_ram[];
>   };
>   

How has this patch been tested? Has it even been compile-tested? This
patch probably breaks at least the following statement:

	BUILD_BUG_ON(sizeof(struct qla2300_fw_dump) != 136100);

Thanks,

Bart.

  reply	other threads:[~2024-10-23 22:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 22:17 Mirsad Todorovac
2024-10-23 22:25 ` Bart Van Assche [this message]
2024-10-24  4:22   ` Mirsad Todorovac
2024-10-24 16:55     ` Bart Van Assche
2024-10-26  7:56       ` Mirsad Todorovac
2024-10-24 20:03 ` kernel test robot
2024-10-25 10:57 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ca3fb4b-85d9-493c-8b90-5210f5530e7f@acm.org \
    --to=bvanassche@acm.org \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mtodorovac69@gmail.com \
    --cc=njavali@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®