From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Colin Ian King <colin.i.king@gmail.com>,
Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko@kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] tpm: remove extraneous space after newline \n
Date: Tue, 29 Apr 2025 19:00:45 +0200 [thread overview]
Message-ID: <9ca8a48c-dc5f-4c4d-a829-c94107d852c2@wanadoo.fr> (raw)
In-Reply-To: <20250429163859.823531-1-colin.i.king@gmail.com>
Le 29/04/2025 à 18:38, Colin Ian King a écrit :
> There is an extraneous space after a \n in a printk statement.
> Remove it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/char/tpm/eventlog/tpm1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c
> index 12ee42a31c71..566f4df58d48 100644
> --- a/drivers/char/tpm/eventlog/tpm1.c
> +++ b/drivers/char/tpm/eventlog/tpm1.c
> @@ -258,7 +258,7 @@ static int tpm1_ascii_bios_measurements_show(struct seq_file *m, void *v)
>
> eventname = kmalloc(MAX_TEXT_EVENT, GFP_KERNEL);
> if (!eventname) {
> - printk(KERN_ERR "%s: ERROR - No Memory for event name\n ",
> + printk(KERN_ERR "%s: ERROR - No Memory for event name\n",
> __func__);
> return -EFAULT;
> }
Hi,,
kmalloc() is already verbose, so I think that the whole printk() could
be removed.
CJ
next prev parent reply other threads:[~2025-04-29 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 16:38 Colin Ian King
2025-04-29 17:00 ` Christophe JAILLET [this message]
2025-04-30 5:20 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ca8a48c-dc5f-4c4d-a829-c94107d852c2@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=colin.i.king@gmail.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®