From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69FAC13C9D4 for ; Mon, 30 Dec 2024 03:12:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735528337; cv=none; b=aQ1RRk6adu8+JLvR8DCu7egwC+ywtvEaHE9tHCGRDMhSzO7sESpRGm8f1l0f+DfAMQqQRrDLtIiWs2UYPvzuTIyRIH2clWNUbv/ncC35kFDjrP9E+eNpI8QBFHhlqiye59VQhCwweD4SzODx2BZQ/hFbmxUhRDEufXpZvlrbVbM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735528337; c=relaxed/simple; bh=RByHVD3bvwf9OBgmvjYl7zmyuddvG3+m7GzmELh8Ojk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BsCwKjsXLpGGkDYJ5gq8uLy4xJBoxzFTeN7NPwAioKmxD+QZUtzN1Y6s8GmMVlXV4JLQrUjJoABv8SgSbbTuFnTRKjAh8KtivgTKZwxNJYmRiY+Aw/MxB3iwmUhw7zsif05MLHyGrORRd4nrm9VaNyULb89Bfr9iVE6SMvePiZ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=U4TKcd5D; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="U4TKcd5D" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2166f1e589cso136672225ad.3 for ; Sun, 29 Dec 2024 19:12:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1735528335; x=1736133135; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=00MV44O/wLuPQ/RpQp8S/rpHXiOskq9DnLB00pReqmw=; b=U4TKcd5D4yLghx2l4BTUej/I4g4Z33Z5EuOg4tqgR1jpnnlPEVnqdX27VklOCdJMzj VZOfTwRmpJpqPi2m4SQzuJdbXiHWuvKAigs0JOvPTR6wkY9L7u/t/zIoZO0s8AjE8VtS 2w7VNScCKvWQoQOa2cMwoDCdd6PpS3fw9sgx5WOBebldyJ9PZyFhF/9oGjf23X3wufGz /8QxukHxfuamu8NP0HHvE/qQoFJfPM5DZGjRXAzmsJWZzDqGRubur3XHHzqmQrPPdktj FPk97rpDrbb1LkLj+b2zZKuczfGTh5ngsdYU1MFuNTe13Mf/JBkMCsTv8QN52rmjXrVU MyNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735528335; x=1736133135; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=00MV44O/wLuPQ/RpQp8S/rpHXiOskq9DnLB00pReqmw=; b=g+5RA3tpk/vMVOIARFQWoFmUaBAoCORWQyhsJ7h0iM6BKPg4M6CtVT3R1HstniTZXa 09bFk1r/uLavWIKXT4GnEq0Sqr2PFvflxWg9AhAGTAxaKF9ba/tZVkLJI5mcbuOC/Ps3 J8UL4bDA8BLUvjOJnPiyCXD20ty7eCkXXvuJ4qpExh0S/eevj3qPDsUYr1rFldkM6IOw 7WD+xSoYdw7r5rNgzK1V+0IlxaYY2KnM08zlr5iI1dN8x1VMHQznLUmCPmMkegLXtxO6 TIRaTugkH92TpvvzCA26VcUVi2zOE86M/wwGb25T9rYmiwpLk1HKtCGoTitULXB2sQsI TFtA== X-Forwarded-Encrypted: i=1; AJvYcCVp4NDKs6/6Gylm8u4hVK1/V2FR+KmDUybwz/EU5B4oRcjhGygXtFkOVvDukmRnXDEvaObAEm5vLjc1h/E=@vger.kernel.org X-Gm-Message-State: AOJu0YxqmoC6z4YQo6GszEzpZfz3O1V7z2mh+Lv6lfmqFgWdTF/nPaSL UPqvzMKgezh2+DHyQtXdvQooqRJULLZz+H3s/dIdXMR8dhwfPAE/Av+/bjupDng= X-Gm-Gg: ASbGncsyTkSMMnYXg9k/xHaPokbYzoXriMIzqx/vP6Q/xPJFwzFByGkIvR+DeSbrVon CnJw+BEXettRLoAX2eel4ggQg81F56hb2EJ/BDFBa5VnB7JKDtjDQ9sNOgth82m/krefdDqu9Eb Wj0P87/rsjrGVti9ZggVBQ5lBOqbxkSWzJKDPfbLsGDMa1GfZ/AxAjkr42OgUuFgERD0CxowYoi 4TqluRSCw1DhqoSpdmTL9p5AoW+0P3/qTXhg61yhZMSRoBxynAnuyv64e4UpaMFiPsuE+xXYY8+ 8WlmRQ== X-Google-Smtp-Source: AGHT+IHVtuGTDJKnXgo1JS5AtVrvj0I/cg1dyieo6seko5BYBtWvsXqnYPIAVAFKhaTndzKmWg8VgQ== X-Received: by 2002:a05:6a20:9185:b0:1e5:7db5:d6e7 with SMTP id adf61e73a8af0-1e5e083f019mr66304616637.46.1735528334820; Sun, 29 Dec 2024 19:12:14 -0800 (PST) Received: from [10.84.148.23] ([203.208.167.148]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad84eb45sm18191842b3a.88.2024.12.29.19.12.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Dec 2024 19:12:14 -0800 (PST) Message-ID: <9cac5690-c570-4d43-a6bc-2b59b85497ae@bytedance.com> Date: Mon, 30 Dec 2024 11:12:00 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 15/17] mm: pgtable: remove tlb_remove_page_ptdesc() Content-Language: en-US To: Mike Rapoport , akpm@linux-foundation.org, kevin.brodsky@arm.com, peterz@infradead.org Cc: agordeev@linux.ibm.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org References: From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Mike, On 2024/12/28 17:26, Mike Rapoport wrote: > On Mon, Dec 23, 2024 at 05:41:01PM +0800, Qi Zheng wrote: >> Here we are explicitly dealing with struct page, and the following logic >> semms strange: >> >> tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); >> >> tlb_remove_page_ptdesc >> --> tlb_remove_page(tlb, ptdesc_page(pt)); >> >> So remove tlb_remove_page_ptdesc() and make callers call tlb_remove_page() >> directly. > > Please don't. The ptdesc wrappers are there as a part of reducing the size > of struct page project [1]. > > For now struct ptdesc overlaps struct page, but the goal is to have them > separate and always operate on struct ptdesc when working with page tables. OK, so tlb_remove_page_ptdesc() and tlb_remove_ptdesc() are somewhat intermediate products of the project. Hi Andrew, can you help remove [PATCH v3 15/17], [PATCH v3 16/17] and [PATCH v3 17/17] from the mm-unstable branch? For [PATCH v3 17/17], I can send it separately later, or Kevin Brodsky can help do this in his patch series. ;) Thanks, Qi > > [1] https://kernelnewbies.org/MatthewWilcox/Memdescs >