From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D004E2F49EB for ; Mon, 24 Nov 2025 09:09:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763975368; cv=none; b=F8AuYJi+rv2IYsFRGdJ9IsOnWZPEEYejuaS4ciNugpdp+YgLkvxbBBodv4SNTCxRZsjx3QLbPeess2K9C0bSeiDy/CBXOL7PKikQHtAVOdklt7q3xj5CFZ/+0+p0cgqd5y7ASQKL4D46bFQNgtQdM9xlIn5ThH2PQjJPAAO8xh0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763975368; c=relaxed/simple; bh=7cucVKRF1i3U03wQQZLLaXMd6VYekFa/vhwxJjBb0wM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=miUtyEvIzRIPRuP+PblCYUvn4Gnml7MYAlFGhv/gmzCDY7E90i+n5G7SmzgUs9wBM5PUY3aii5dCuFN9Dlqtpty4rNLUYMxFxFweQG0t7mLACcZRrxDbXL2Gwcmu2tZnRmWPob7uab0ES9AK+Jqi1eti9PDj5R0xkZvt4zZ/H0Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=X9EVSicO; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X9EVSicO" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-42b3377aaf2so2273931f8f.2 for ; Mon, 24 Nov 2025 01:09:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763975365; x=1764580165; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=OvXHuoRgH+XIUx292dJAYC+bXU3Y0ChyF2IbAzcMS/Q=; b=X9EVSicOG5kFedBvxTqDIIeuZHrgVhbmsI9Le4AlBj6Ihivl6ynbpfuufKRyy1ex3s jx1nXKjlbLynhnWJUpG31IwszI9yHnUsGs3Kafbm7Gdx+oTA71dMmslVU/2YxUCf9z8L 8zbtDaUkx6Um0kcRoEOVmKxv/F+4/1OmtjIH6ESm0NxDivD3Q6SklCKmb/cQl9S33MKg 6HrSjIAXyAKgEjNPuBjYqirBPJ5pprxr4fX6mkJL5cHn1hgvRbK0pOlZZk5PVythSGy7 Tf4plCwzPYl8NmAzDJ90x6dzXZkBviqbXTHrqHh7nj9AYr3OmLlwKyUIBfd0n3WN/Tj4 m9Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763975365; x=1764580165; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OvXHuoRgH+XIUx292dJAYC+bXU3Y0ChyF2IbAzcMS/Q=; b=fyIOSvLCoF3x1Y3IwVVgcMsfU1vID1eU6dU2B+5ci2fX+KG383G4D8WBhw9uwpIFOt YV3XofJB8MFIhOPdA15B4pmCxIpu1PXMYFW8OxGT3nhsY12LkU4ci0z1pMfjFVvDHVIH hW6ID9i5fUMJLQTo1+g3DZ1g2b+uUKU9CzdjPLRAYk9rsPe8NJw5xdEQgz8Fq1ssFfmj RNhnblLmHlgHBGh//p9WfCAksYRLLDeWSbtzoiiPoYHaux2iieEuNUCFEof/uH7DR0/3 uV9rr4G70Eo/GZhm9B2E4Y/54U77D8tKxkQQHFzsThhxuwI5X3iEOXizwFM1pwxxflSV 7LoA== X-Gm-Message-State: AOJu0YzHztF67WMIq75OsmvtyLPMF6cvPMNTh0UVFs23V6UvFMX3RSWq gZ5ke2V4kc5Vq1G+zvIv/XwJa547ClDMzL81p9oLrsF8B1hQidG18Q6bpaCUTePX8xI= X-Gm-Gg: ASbGnctIN/4oEPkqR1RZdtpJT/QanU35lzffqhh9Ub40+QSwStTHzqluPHQYBBcVK7k ltZ/QT/dEHHLg/1/q5CavWPT1syxZBcnxOELaRmVTseol6hQURuhVk8csYjBCsxK4Hzyp7WRdh4 aPjAuPYelzi3cgE2hiomOtrDJFI5XlY5jA2DAfV/E/sr7cxQ8esHQ6lmLG+L1eJ5EztDfXSWnYV EnAy8kHOLST175WK+iCHREBB7Hft0PCDxCO+8AmiZ69jLLCZ9LGQ+FW/mGB+tAmiclPlx4vbTTz jcUmfyoaiMQ9nG8UmuYwzyDaMdtjzeXzctMxsM4YlRD7bJdwj1Ep2J/xXkhPGRjrolb/V5Tdb9L 43q8uoyIwceXvVjYuMsNjo6HbWGXdmsq+3odHetCBZDPkRd6X/tbsZPz7qHwywM353TvqxzNgff MBvMsO3QvQUFv1dA+Y5g== X-Google-Smtp-Source: AGHT+IGb2anSnU9yUNqdmZbv+SeaRHh1StnydsjMu/nMg2MY1ixTXj9wwNITrqgGCjoJ7tz/T/jZVA== X-Received: by 2002:a5d:5f44:0:b0:42b:41dc:1b58 with SMTP id ffacd0b85a97d-42cc1d19957mr11009024f8f.45.1763975365182; Mon, 24 Nov 2025 01:09:25 -0800 (PST) Received: from draszik.lan ([212.129.72.170]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fb9190sm27162766f8f.33.2025.11.24.01.09.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 01:09:24 -0800 (PST) Message-ID: <9cad7b42dbfea351fb3b708736bf6f6715bcf694.camel@linaro.org> Subject: Re: [PATCH 6/6] usb: typec: tcpm/tcpci_maxim: deprecate WAR for setting charger mode From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: amitsd@google.com, Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Greg Kroah-Hartman , Badhri Jagan Sridharan , Heikki Krogerus , Peter Griffin , Tudor Ambarus , Alim Akhtar Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, RD Babiera , Kyle Tso Date: Mon, 24 Nov 2025 09:09:37 +0000 In-Reply-To: <20251123-max77759-charger-v1-6-6b2e4b8f7f54@google.com> References: <20251123-max77759-charger-v1-0-6b2e4b8f7f54@google.com> <20251123-max77759-charger-v1-6-6b2e4b8f7f54@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-2+build3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Amit, On Sun, 2025-11-23 at 08:35 +0000, Amit Sunil Dhamne via B4 Relay wrote: > From: Amit Sunil Dhamne >=20 > TCPCI maxim driver directly writes to the charger's register space to > set charger mode depending on the power role. As MAX77759 chg driver > exists, this WAR is not required. >=20 > Instead, use a regulator interface to set OTG Boost mode. >=20 > Signed-off-by: Amit Sunil Dhamne > --- > =C2=A0drivers/usb/typec/tcpm/tcpci_maxim.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = |=C2=A0 1 + > =C2=A0drivers/usb/typec/tcpm/tcpci_maxim_core.c | 48 ++++++++++++++++++++= +---------- > =C2=A02 files changed, 34 insertions(+), 15 deletions(-) >=20 > diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.h b/drivers/usb/typec/tcp= m/tcpci_maxim.h > index b33540a42a95..6c82a61efe46 100644 > --- a/drivers/usb/typec/tcpm/tcpci_maxim.h > +++ b/drivers/usb/typec/tcpm/tcpci_maxim.h > @@ -60,6 +60,7 @@ struct max_tcpci_chip { > =C2=A0 struct tcpm_port *port; > =C2=A0 enum contamiant_state contaminant_state; > =C2=A0 bool veto_vconn_swap; > + struct regulator *otg_reg; > =C2=A0}; > =C2=A0 > =C2=A0static inline int max_tcpci_read16(struct max_tcpci_chip *chip, uns= igned int reg, u16 *val) > diff --git a/drivers/usb/typec/tcpm/tcpci_maxim_core.c b/drivers/usb/type= c/tcpm/tcpci_maxim_core.c > index 19f638650796..6d819a762fa1 100644 > --- a/drivers/usb/typec/tcpm/tcpci_maxim_core.c > +++ b/drivers/usb/typec/tcpm/tcpci_maxim_core.c > @@ -10,6 +10,7 @@ > =C2=A0#include > =C2=A0#include > =C2=A0#include > +#include > =C2=A0#include > =C2=A0#include > =C2=A0#include > @@ -202,32 +203,49 @@ static void process_rx(struct max_tcpci_chip *chip,= u16 status) > =C2=A0 tcpm_pd_receive(chip->port, &msg, rx_type); > =C2=A0} > =C2=A0 > +static int get_otg_regulator_handle(struct max_tcpci_chip *chip) > +{ > + if (IS_ERR_OR_NULL(chip->otg_reg)) { > + chip->otg_reg =3D devm_regulator_get_exclusive(chip->dev, > + =C2=A0=C2=A0=C2=A0=C2=A0 "otg-vbus"); > + if (IS_ERR_OR_NULL(chip->otg_reg)) { > + dev_err(chip->dev, > + "Failed to get otg regulator handle"); > + return -ENODEV; > + } > + } > + > + return 0; > +} > + > =C2=A0static int max_tcpci_set_vbus(struct tcpci *tcpci, struct tcpci_dat= a *tdata, bool source, bool sink) > =C2=A0{ > =C2=A0 struct max_tcpci_chip *chip =3D tdata_to_max_tcpci(tdata); > - u8 buffer_source[2] =3D {MAX_BUCK_BOOST_OP, MAX_BUCK_BOOST_SOURCE}; > - u8 buffer_sink[2] =3D {MAX_BUCK_BOOST_OP, MAX_BUCK_BOOST_SINK}; > - u8 buffer_none[2] =3D {MAX_BUCK_BOOST_OP, MAX_BUCK_BOOST_OFF}; You should also remove the corresponding #defines at the top of this file. > - struct i2c_client *i2c =3D chip->client; > =C2=A0 int ret; > =C2=A0 > - struct i2c_msg msgs[] =3D { > - { > - .addr =3D MAX_BUCK_BOOST_SID, > - .flags =3D i2c->flags & I2C_M_TEN, > - .len =3D 2, > - .buf =3D source ? buffer_source : sink ? buffer_sink : buffer_none, > - }, > - }; > - > =C2=A0 if (source && sink) { > =C2=A0 dev_err(chip->dev, "Both source and sink set\n"); > =C2=A0 return -EINVAL; > =C2=A0 } > =C2=A0 > - ret =3D i2c_transfer(i2c->adapter, msgs, 1); > + ret =3D get_otg_regulator_handle(chip); > + if (ret) { > + /* > + * Regulator is not necessary for sink only applications. Return > + * success in cases where sink mode is being modified. > + */ > + return source ? ret : 1; > + } > + > + if (source) { > + if (!regulator_is_enabled(chip->otg_reg)) > + ret =3D regulator_enable(chip->otg_reg); > + } else { > + if (regulator_is_enabled(chip->otg_reg)) > + ret =3D regulator_disable(chip->otg_reg); > + } Given otg_reg is the fake regulator created by a previous patch in this series, this means that the regulator API is really used to configure two out of 16 possible charger modes here. That doesn't look right. Cheers, Andre'