From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3803C32E128 for ; Mon, 10 Aug 2026 15:59:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786377565; cv=none; b=Pjz+9jGqEv+YHB02kLgwavmHnKJZ8c0SFDLIkYV627rWWOMzhBrdZMrWnzP9UTsxgqQXreeiYHQuC8R1Zw8mFe/SvXedoXJXw/WZA5y2v8k/6goJo4GYmDrlfO1XHN8L4kcTIDucirZVcqo4PYIMZgXeyqRUqbr77P+XsF48ZCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786377565; c=relaxed/simple; bh=+y9BmG5ECYGZ7PTxJcCnYcGfDIEGHs+9VHyg7Z1lJ+Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fROcg6E0Ywj3J1PpiqzNT2WxuXN+smROwEOm5Vm0fIGB9OspKbM7DAvDJmg1Doza5nW5OuVK+qchyIpbHTllII+oV2/NZsmXbwOtuGQ2PNylqAdkxGiLZZZRLlcAPu8z1WkEk+s4X24RAf0PHcosYq4Z1O5Ms9knaPbJBU1iQ6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=DfB2/MeI; arc=none smtp.client-ip=209.85.210.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="DfB2/MeI" Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-7ea9c6ea7deso1258737a34.3 for ; Mon, 10 Aug 2026 08:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1786377562; x=1786982362; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2tmRYBxMWUfk/nrkAvGvFxCo8PUNTkvQH/ufUyuPgMg=; b=DfB2/MeIkLcQwHHUy5u5EEOnfMwx+qcbV3zrr3kjHI4FvcJ5Lf8Z5rvoF6eWZzDpLa 4z6t2uegpGufLUi4xHjdtXv0mwjXu0+D01f/zr75pgzVU4I4SNHjQ9MU5shkQEDXmziu VTE6MBb4txQPW2fKZublAsParTIYBVsXJcZf4iPao9haUf2D+VE4BL59GUAV1Ssm09Gk MB1aNkELKEMLa3SPCD5IOVLbYJ1smRE9OaN+IBZxFcJce8G7SRZ4imL0iKrSXgNlZ8aV LoxzE7xmKOtdO+bE4o6tCl9wwM58Wkb8H8n54O4lkCZkHzy2gW8l55CFD3pDQCd2UGjY HUxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786377562; x=1786982362; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2tmRYBxMWUfk/nrkAvGvFxCo8PUNTkvQH/ufUyuPgMg=; b=JluUcv77hWKVxyWL6h+lkdjOeGUa8/OvhITkxQdSx/JziAE6630/9W1t5ZgNESyqz+ YNmvl0ajiHTOYF/S3jfxEBJvPJPgNRdcW2RrAv1uumfZaVGJE+CGulvF/10aFPGpjzpX 1H1VjmGjeivrU691jLuYbna+u0FH9uEgnHgzv8UAikGuLw88me6gLKxUn/BQZCKbPvTm ztRytdVXBc5zuTH4bsNEDqjKNApmrhgVGircilctp70Yt6uBf05XFDmfcCjB93sGD18A 5uv7h8HVidyiJxWUNfFbF9piAa+h0RE2T3THm+4HqV4kwa/Z893X/WnLJVN1D2cwfXy0 DN4A== X-Forwarded-Encrypted: i=1; AHgh+Rrg5megzMooYHk04U7bNZT+55Bj1z7r4VpW8CTrXS68kdWuJ51fRYK5WKhTsbr5VGfq2Lsqi7y2hJFzguQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxIL/ucL/4dqkTm6OA4ehi1313wZADpjDrIeYkSHn4DYq2dyj5G gNOSGfSXcEsJzb3pWEUJtC/5yjEnEh+Pn5WSxpE1kaftw7CN+XcnSepUqGtVexdzAFM= X-Gm-Gg: AR+sD137Apn2c0V4Rpc/KjeNSGsBKCBOO93OQvJNm8BYEWKxpw8TJRN5KBO30oqW1Bh mW1Se0cRFUcuv4YN/FQRx4sEkccgIJfI+JMMd/AB6vLsG6sFZqj+MTYp9gOxcBiXL6xTsnzdCpY yVcWPsMOgEdgsT0aGN7LfO/5Gswm9b132/suPt9sSPtwiTwHUQAvMosbu9vGQ1qgkQSd9WiPEtF xJiBGkWTSfopXKahFJMfqjxF+n8zflLi9wvNiF+N1PqjOtcfmZtkm16/uWlkxPcVayEe9t8OXrm ruuxOl3qJAtsoWf31tY6I5xumUho29/5HTfM+XijQFJEVw6fHat9yn2GAWDPNBvzxGdUsSbfQEo 1FuLqFGrpw48y5wN8FkycvYI5ct0LZGbj7gCuNrv1GzDj1NVQdAxZYdlwKTMTSqi9hiizgUrwzj SUiX8IcSMW7XdJpJ5dtoajwtizMzlrH8rhElKf3+YnSEjLh0B27XCnnmXGYgjneyP1EehT4HRy8 R7AZV1sZCl5pnexGCsgCae6C/kh+FzWKzFHAY1sgfaxaVx+xic= X-Received: by 2002:a05:6808:c40a:b0:495:e1b6:2c5 with SMTP id 5614622812f47-4afadd36ea4mr23140067b6e.1.1786377562035; Mon, 10 Aug 2026 08:59:22 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:e05b:7923:cf50:e4cf? ([2600:8803:e7e4:500:e05b:7923:cf50:e4cf]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4b1aeda740csm6801267b6e.0.2026.08.10.08.59.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2026 08:59:21 -0700 (PDT) Message-ID: <9caea0d2-3fad-4a47-a437-096c269938d5@baylibre.com> Date: Mon, 10 Aug 2026 10:59:20 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] iio: adc: ti-ads112c14: add DRDY interrupt support To: Andy Shevchenko Cc: Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Chris Hall , Patrick Edwards , Kurt Borja , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260807-iio-adc-ti-ads112c14-continuous-mode-v3-0-76e0d30e6c6b@baylibre.com> <20260807-iio-adc-ti-ads112c14-continuous-mode-v3-1-76e0d30e6c6b@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/10/26 3:50 AM, Andy Shevchenko wrote: > On Fri, Aug 07, 2026 at 04:19:46PM -0500, David Lechner (TI) wrote: >> Add handling for the DRDY interrupt to wait for data ready events rather >> than polling (only when it is wired up). > > ... > >> +static irqreturn_t ads112c14_drdy_irq_handler(int irq, void *private) >> +{ >> + struct iio_dev *indio_dev = private; >> + struct ads112c14_data *data = iio_priv(indio_dev); > > I have seen some discussion about this, but what's the problem with the > > struct ads112c14_data *data = iio_priv(private); > > ? indio_dev gets used in a later patch, so point is to avoid churn. > >> + complete(&data->drdy_completion); >> + >> + return IRQ_HANDLED; >> +} > > ... > >> + if (device_property_present(dev, "interrupts")) { > > Unfortunately this is no-go for ACPI-enabled systems. > On ACPI we expect to have 'interrupt-names' but 'interrupts' is OF-only. So device_property_present(dev, "interrupt-names") is OK? > >> + data->drdy_irq = fwnode_irq_get_byname(dev_fwnode(dev), "drdy"); >> + if (data->drdy_irq < 0) >> + return dev_err_probe(dev, data->drdy_irq, >> + "failed to get drdy interrupt\n"); >> +