From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.com>
Cc: kernel@collabora.com, kernel-janitors@vger.kernel.org,
James Smart <jsmart2021@gmail.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: lpfc: correct size for wqe for memset
Date: Mon, 4 Mar 2024 11:19:26 +0100 [thread overview]
Message-ID: <9cb2001f-77d5-47c3-9e8a-588bd83b01df@collabora.com> (raw)
In-Reply-To: <20240301144458.2810597-1-usama.anjum@collabora.com>
Il 01/03/24 15:44, Muhammad Usama Anjum ha scritto:
> The wqe is of type lpfc_wqe128. It should be memset with the same type.
>
> Fixes: 6c621a2229b0 ("scsi: lpfc: Separate NVMET RQ buffer posting from IO resources SGL/iocbq/context")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> drivers/scsi/lpfc/lpfc_nvmet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
> index 8258b771bd009..29bc6cd10fd69 100644
> --- a/drivers/scsi/lpfc/lpfc_nvmet.c
> +++ b/drivers/scsi/lpfc/lpfc_nvmet.c
> @@ -1586,7 +1586,7 @@ lpfc_nvmet_setup_io_context(struct lpfc_hba *phba)
> wqe = &nvmewqe->wqe;
>
> /* Initialize WQE */
> - memset(wqe, 0, sizeof(union lpfc_wqe));
> + memset(wqe, 0, sizeof(union lpfc_wqe128));
memset(wqe, 0, sizeof(*wqe));
Cheers,
Angelo
prev parent reply other threads:[~2024-03-04 10:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 14:44 Muhammad Usama Anjum
2024-03-01 19:02 ` Justin Tee
2024-03-04 8:45 ` Muhammad Usama Anjum
2024-03-04 10:19 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cb2001f-77d5-47c3-9e8a-588bd83b01df@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=dick.kennedy@broadcom.com \
--cc=hare@suse.com \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=jsmart2021@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®