From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0ED4C433FE for ; Thu, 28 Apr 2022 18:38:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351173AbiD1Sld (ORCPT ); Thu, 28 Apr 2022 14:41:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232896AbiD1Slb (ORCPT ); Thu, 28 Apr 2022 14:41:31 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E2B5BE9EE for ; Thu, 28 Apr 2022 11:38:16 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 26DAB1F45BA6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1651171094; bh=LUoHkp961qm9ko1OBtouQWFIA8PMdZVSkHc/jw1XS44=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Gfq++VVz0zfr6JFt1ax6Utc5gsxcHoJIm5n0+6KpdFYaHipbvdGcXdvSCeE4iToqp du8kN1/0uHwQg8uWiF4B+RQF5Sww9YSZq5/uKMtVA/iMrJpoVHRwu4GzEK3pbolvUJ jg1ZmnkE/osv2uVCh8aVrQt6C9IQJD2ZKuWW/JoS9vAPlelhwOMVOvLFQLl7P1FcXo 5BjvLzIPrhmEhbIj7WYtdUGHWEGPE3rQG5GyqHDmwLWPDVIdQ4bc52/kZKjn1F1+7s 0Yigqu3B//kV5MYZE6/sAzQ/uWp1VvY/pqlAFb2lGpLqAc3b5QYXQLKoaz7OW+Muev m55mWpLIa2xKQ== Message-ID: <9cb2e7fb-1597-999e-59b8-586b5fd7f04d@collabora.com> Date: Thu, 28 Apr 2022 21:38:10 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v5 15/17] drm/shmem-helper: Make drm_gem_shmem_get_pages() private Content-Language: en-US To: David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Almeida , Gert Wollny , Gustavo Padovan , Daniel Stone , Tomeu Vizoso , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Steven Price , Alyssa Rosenzweig , Rob Clark , Emil Velikov , Robin Murphy , Qiang Yu , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Dmitry Osipenko References: <20220424190424.540501-1-dmitry.osipenko@collabora.com> <20220424190424.540501-16-dmitry.osipenko@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 28.04.2022 15:33, Daniel Vetter пишет: > On Sun, Apr 24, 2022 at 10:04:22PM +0300, Dmitry Osipenko wrote: >> VirtIO-GPU driver was the only user of drm_gem_shmem_get_pages() >> and it now uses drm_gem_shmem_get_pages_sgt(). Make the get_pages() >> private to drm_gem_shmem_helper. >> >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/gpu/drm/drm_gem_shmem_helper.c | 3 +-- >> include/drm/drm_gem_shmem_helper.h | 1 - >> 2 files changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c >> index 25e9bc2803ee..7ec5f8002f68 100644 >> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c >> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c >> @@ -490,7 +490,7 @@ static int drm_gem_shmem_get_pages_locked(struct drm_gem_shmem_object *shmem) >> * Returns: >> * 0 on success or a negative error code on failure. >> */ > > We also delete the kerneldoc for functions not exported (kerneldoc is > geared towards driver writes). If there's anything critical the comment > explains about the internals, you can keep that as a normal C style > comment without the /** but generally there's no need for these anymore. Noted for v6.