mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Denis Benato <denis.benato@linux.dev>
To: AbdElRahman Soliman <abdelrahman7987@gmail.com>,
	hansg@kernel.org, ilpo.jarvinen@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: asus-armoury: add support for FX517ZR
Date: Sun, 16 Aug 2026 16:48:59 +0200	[thread overview]
Message-ID: <9cb5f4f9-223f-4162-8b9a-81486944be54@linux.dev> (raw)
In-Reply-To: <20260729110941.26794-1-abdelrahman7987@gmail.com>


On 7/29/26 13:09, AbdElRahman Soliman wrote:
> Add DMI match and power-limit table entry for the ASUS TUF Dash F15
> (2022), board FX517ZR, an Alder Lake + RTX 3070 laptop.
>
> AC and DC min/max values for ppt_pl1_spl, ppt_pl2_sppt,
> nv_dynamic_boost and nv_temp_target were read from the sliders in
> ASUS Armoury Crate's manual performance-tuning mode on Windows for
> this exact model, since ASUS does not publish these limits on the Web.
>
> Tested locally: values now report correctly via 'asusctl armoury
> list' instead of unavailable, and Dynamic Boost via nvidia-powerd
> measurably raises GPU power limit under load, consistent with the
> 80W base + 25W boost = 105W max TGP in ASUS's own spec sheet for
> this configuration.
>
> Assisted-by: Claude:claude-sonnet-5
Hi,

Thanks for this.

I would say remove the "Tested locally" paragraph: guidelines says
that commit messages are to be written in the second person as if
you were telling git what to do.

Also I personally never used a commit message so long and
a shorter one will be absolutely be fine too.

Next revision use the -v2 flag and don't forget to email me too.

If you need further help just tell me, thanks!
> Signed-off-by: AbdElRahman Soliman <abdelrahman7987@gmail.com>
> ---
>  drivers/platform/x86/asus-armoury.h | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-armoury.h b/drivers/platform/x86/asus-armoury.h
> index bc899bec7..46c308ba8 100644
> --- a/drivers/platform/x86/asus-armoury.h
> +++ b/drivers/platform/x86/asus-armoury.h
> @@ -975,6 +975,32 @@ static const struct dmi_system_id power_limits[] = {
>  			.requires_fan_curve = true,
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_NAME, "FX517ZR"),
> +		},
> +		.driver_data = &(struct power_data) {
> +			.ac_data = &(struct power_limits) {
> +				.ppt_pl1_spl_min = 28,
> +				.ppt_pl1_spl_max = 85,
> +				.ppt_pl2_sppt_min = 28,
> +				.ppt_pl2_sppt_max = 135,
> +				.nv_dynamic_boost_min = 5,
> +				.nv_dynamic_boost_max = 25,
> +				.nv_temp_target_min = 75,
> +				.nv_temp_target_max = 87,
> +			},
> +			.dc_data = &(struct power_limits) {
> +				.ppt_pl1_spl_min = 25,
> +				.ppt_pl1_spl_max = 45,
> +				.ppt_pl2_sppt_min = 35,
> +				.ppt_pl2_sppt_max = 60,
> +				.nv_temp_target_min = 75,
> +				.nv_temp_target_max = 87,
> +			},
> +			.requires_fan_curve = true,
> +		},
> +	},
>  	{
>  		.matches = {
>  			DMI_MATCH(DMI_BOARD_NAME, "FX607VU"),

      reply	other threads:[~2026-08-16 14:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 11:09 AbdElRahman Soliman
2026-08-16 14:48 ` Denis Benato [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9cb5f4f9-223f-4162-8b9a-81486944be54@linux.dev \
    --to=denis.benato@linux.dev \
    --cc=abdelrahman7987@gmail.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®